Web Animations: discrete-animation.html WPT fails due to issue with test |
||||
Issue description
I have yet to root-cause this bug, but it is the reason that we fail the following tests:
external/wpt/web-animations/animation-model/animation-types/discrete-animation.html
- Test the 50% switch point for discrete animation is based on the effect easing
- Test the 50% switch point for discrete animation is based on the keyframe easing
A simpler test shows that Chrome does not appear to support animating the fontStyle at all:
var div = document.getElementById("testDiv");
var anim = div.animate({ fontStyle: [ 'italic', 'oblique' ] },
{ duration: 1000, fill: 'forwards' });
for (var time = 0; time <= 1000; time += 100) {
anim.currentTime = time;
console.log("time " + time + ", getComputedStyle(div).fontStyle: " + getComputedStyle(div).fontStyle);
}
In Firefox this produces:
time 0, getComputedStyle(div).fontStyle: italic
time 100, getComputedStyle(div).fontStyle: italic
time 200, getComputedStyle(div).fontStyle: italic
time 300, getComputedStyle(div).fontStyle: italic
time 400, getComputedStyle(div).fontStyle: italic
time 500, getComputedStyle(div).fontStyle: oblique
time 600, getComputedStyle(div).fontStyle: oblique
time 700, getComputedStyle(div).fontStyle: oblique
time 800, getComputedStyle(div).fontStyle: oblique
time 900, getComputedStyle(div).fontStyle: oblique
time 1000, getComputedStyle(div).fontStyle: oblique
In Chrome this produces:
time 0, getComputedStyle(div).fontStyle: italic"
time 100, getComputedStyle(div).fontStyle: italic
time 200, getComputedStyle(div).fontStyle: italic
time 300, getComputedStyle(div).fontStyle: italic
time 400, getComputedStyle(div).fontStyle: italic
time 500, getComputedStyle(div).fontStyle: italic
time 600, getComputedStyle(div).fontStyle: italic
time 700, getComputedStyle(div).fontStyle: italic
time 800, getComputedStyle(div).fontStyle: italic
time 900, getComputedStyle(div).fontStyle: italic
time 1000, getComputedStyle(div).fontStyle: italic
As far as the spec says, all properties are animatable so this should work (https://w3c.github.io/web-animations/#procedures-for-animating-properties):
"Unless specifically defined otherwise, all CSS properties are considered animatable."
,
Oct 6 2017
,
Oct 6 2017
As per https://github.com/w3c/web-platform-tests/issues/6518 the correct approach is to fix the test. UAs are allowed to treat italic and oblique as synonyms, and Chrome does so for getComputedStyle.
,
Oct 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bfbadbb7c9571996081fe100fe9ccdcca31813c0 commit bfbadbb7c9571996081fe100fe9ccdcca31813c0 Author: Stephen McGruer <smcgruer@chromium.org> Date: Wed Oct 11 03:07:00 2017 Fix discrete-animation.html to not use synonymous values Fixes #6518 in web-platform-tests Bug: 771985 Change-Id: I0cb542c266cdb483f8022d81560d2a7e5b293d0d Reviewed-on: https://chromium-review.googlesource.com/705434 Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#507880} [modify] https://crrev.com/bfbadbb7c9571996081fe100fe9ccdcca31813c0/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/bfbadbb7c9571996081fe100fe9ccdcca31813c0/third_party/WebKit/LayoutTests/external/wpt/web-animations/animation-model/animation-types/discrete-animation.html
,
Oct 11 2017
,
Oct 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c48db31689105ce81dcbe640416e45860299c248 commit c48db31689105ce81dcbe640416e45860299c248 Author: Stephen McGruer <smcgruer@chromium.org> Date: Thu Oct 12 20:34:35 2017 Update crbug links for some failing WPT web-animations tests Bug: 600248 , 771722, 771751, 771977, 771985 , 772014 , 772048, 772060, 772076 Change-Id: Ie08474f751fd45484627c8a52d84db13ca6b39ac Reviewed-on: https://chromium-review.googlesource.com/702536 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#508447} [modify] https://crrev.com/c48db31689105ce81dcbe640416e45860299c248/third_party/WebKit/LayoutTests/TestExpectations |
||||
►
Sign in to add a comment |
||||
Comment 1 by shend@chromium.org
, Oct 5 2017