New issue
Advanced search Search tips

Issue 771978 link

Starred by 1 user
Status: Fixed
Owner:
tzik@chromium.org
Closed: Oct 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

blink_platform_unittests failing on Linux Trusty (dbg)

Project Member Reported by wjmaclean@chromium.org, Oct 5 2017 
Seems to be crashing the following tests:

RendererSchedulerImplTest.SYNCHRONIZED_GESTURE_TimerTaskThrottling_task_expensive
RendererSchedulerImplTest.UnthrottledTaskRunner
RendererSchedulerImplTest.SYNCHRONIZED_GESTURE_TimerTaskThrottling_TimersStopped
RendererSchedulerImplTest.SYNCHRONIZED_GESTURE_TimerTaskThrottling_task_not_expensive

Suspecting:

https://chromium-review.googlesource.com/c/chromium/src/+/700334

as it makes a change to blink refptrs, which could conceivably lead to crashes. It seems like the best candidate cause in the regression range.

Assigning to tzik@ - please re-assign if you feel this is incorrect.

Comment 1 by wjmaclean@chromium.org, Oct 5 2017 

The same tests are also failing on 

https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20CFI

with a slightly different regression range, that still includes the suspect CL.

Comment 2 by tzik@chromium.org, Oct 5 2017

Status: Assigned (was: Untriaged)

Comment 3 by wjmaclean@chromium.org, Oct 5 2017 

I reverted your CL, and it looks like the bots are starting to green-up, so this bug may be a no-op.
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cffe0b3a56727366ebfc5c2eab7832a86517be6d

commit cffe0b3a56727366ebfc5c2eab7832a86517be6d
Author: tzik <tzik@chromium.org>
Date: Sat Oct 07 13:52:48 2017

Remove RefPtr auto unwrap in WTF::Bind and add WTF::RetainedRef

BindUnwrapTraits specialization for RefPtr in Function.h causes ODR
violation after the unification of RefPtr and scoped_refptr, as the
BindUnwrapTraits specialization is not necessarily visible from where
it's needed. I.e. if a source file includes "base/bind.h" and
"base/memory/ref_counted.h", and uses base::Bind with scoped_refptr,
then unspecialized BindUnwrapTraits is used on the callback invocation.
However, if the source file includes "Functional.h", specialized
BindUnwrapTraits is used.

Bug:  763844 ,  771978 
Change-Id: I37f6cb2d99a93656811a14d4f94d6643552340c4
Reviewed-on: https://chromium-review.googlesource.com/705834
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507293}
[modify] https://crrev.com/cffe0b3a56727366ebfc5c2eab7832a86517be6d/third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.cpp
[modify] https://crrev.com/cffe0b3a56727366ebfc5c2eab7832a86517be6d/third_party/WebKit/Source/platform/CrossThreadCopier.h
[modify] https://crrev.com/cffe0b3a56727366ebfc5c2eab7832a86517be6d/third_party/WebKit/Source/platform/graphics/ImageFrameGeneratorTest.cpp
[modify] https://crrev.com/cffe0b3a56727366ebfc5c2eab7832a86517be6d/third_party/WebKit/Source/platform/wtf/Functional.h
[modify] https://crrev.com/cffe0b3a56727366ebfc5c2eab7832a86517be6d/third_party/WebKit/Source/platform/wtf/FunctionalTest.cpp

Comment 5 by tzik@chromium.org, Oct 7 2017

Status: Fixed (was: Assigned)
The reverted change should no longer cause the crash after #c4.
►

Sign in to add a comment