New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 771972 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug-Security



Sign in to add a comment

Heap-buffer-overflow in v8::internal::wasm::ModuleDecoderImpl::DecodeFunctionBody

Project Member Reported by ClusterFuzz, Oct 5 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5604860472066048

Fuzzer: ochang_js_fuzzer
Job Type: linux_asan_d8_dbg
Platform Id: linux

Crash Type: Heap-buffer-overflow WRITE 8
Crash Address: 0x607000000718
Crash State:
  v8::internal::wasm::ModuleDecoderImpl::DecodeFunctionBody
  v8::internal::wasm::AsyncStreamingProcessor::ProcessFunctionBody
  ProcessFunctionBody
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_d8_dbg&range=48124:48125

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5604860472066048

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Owner: mstarzinger@chromium.org
Status: Assigned (was: Untriaged)
Assingning to v8 cf sheriff. 
Owner: ----
Status: Unconfirmed (was: Assigned)
Removing owner to give predator a chance to auto-assign...
Project Member

Comment 3 by ClusterFuzz, Oct 5 2017

Components: Blink>JavaScript>WebAssembly
Labels: Test-Predator-AutoComponents
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 4 by ClusterFuzz, Oct 5 2017

Labels: Test-Predator-AutoOwner
Owner: kschimpf@google.com
Status: Assigned (was: Unconfirmed)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/v8/v8/+/87713b37562e0be06419005fe05363bc10e748a2 (Fix UMA stats for WASM functions).

If this is incorrect, please remove the owner and apply the Test-Predator-Wrong-CLs label.
At tip of tree and works for me.

Cc: eholk@chromium.org
Owner: ----
Status: Untriaged (was: Assigned)
I can reproduce this locally. You need to make sure to pass the flags in the ClusterFuzz report:

d8 --random-seed=1660774973 --invoke-weak-callbacks --omit-quit --disable-in-process-stack-traces --future --wasm-test-streaming clusterfuzz-testcase-minimized-5604860472066048.js

Comment 9 by eholk@chromium.org, Oct 5 2017

Cc: kschimpf@chromium.org
Owner: ahaas@chromium.org
Status: Assigned (was: Untriaged)
Ahh, That probably explains it. It is probably due to --wasm-test-streaming which implements a streaming version of the buffer. Redirecting to ahaas.
Project Member

Comment 11 by sheriffbot@chromium.org, Oct 6 2017

Labels: M-63
Project Member

Comment 12 by sheriffbot@chromium.org, Oct 6 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 13 by sheriffbot@chromium.org, Oct 6 2017

Labels: Pri-1
Labels: -Pri-1 -Security_Impact-Head -Security_Severity-High -ReleaseBlock-Stable Pri-2
This check fails only with a testing flag turned on, in a feature which is turned off by default at the moment. This is no release blocker.
Labels: Security_Impact-None
Project Member

Comment 16 by ClusterFuzz, Nov 4 2017

ClusterFuzz has detected this issue as fixed in range 49116:49117.

Detailed report: https://clusterfuzz.com/testcase?key=5604860472066048

Fuzzer: ochang_js_fuzzer
Job Type: linux_asan_d8_dbg
Platform Id: linux

Crash Type: Heap-buffer-overflow WRITE 8
Crash Address: 0x607000000718
Crash State:
  v8::internal::wasm::ModuleDecoderImpl::DecodeFunctionBody
  v8::internal::wasm::AsyncStreamingProcessor::ProcessFunctionBody
  ProcessFunctionBody
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_d8_dbg&range=48124:48125
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_d8_dbg&range=49116:49117

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5604860472066048

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 17 by ClusterFuzz, Nov 4 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5604860472066048 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 18 by sheriffbot@chromium.org, Nov 4 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -Test-Predator-AutoComponents Test-Predator-Auto-Components
Labels: -Test-Predator-AutoOwner Test-Predator-Auto-Owner
Labels: Security_Severity-High
> This check fails only with a testing flag turned on, in a feature which is turned off by default at the moment.

The correct label for features turned off by default is Security_Impact-None. Please use that instead of dropping the Security-Severity label, as the severity label is still useful for tracking. (we are updating the docs to clarify this)
Project Member

Comment 22 by sheriffbot@chromium.org, Feb 10 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment