Mute/unmute icon shapes in the menu item should toggle Please see screenshot. Becca - do you have the asset you need for this? :)
Yes I do, the state is just not persisted.
Pending CL: https://chromium-review.googlesource.com/c/chromium/src/+/704716
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0502f56e5ba44fdd5c10ffaeb4f863979c692efe commit 0502f56e5ba44fdd5c10ffaeb4f863979c692efe Author: Becca Hughes <beccahughes@chromium.org> Date: Thu Oct 12 16:19:14 2017 Media Controls: Mute / unmute icon should toggle. Icons are updated by the "UpdateDisplayState" function which was not being called on the child overflow elements. Now if the parent updates it's display type we will update the display state of the child overflow element too. BUG= 771949 Change-Id: I383cb5095e7841c1ff63b5af142b7cac9364986e Reviewed-on: https://chromium-review.googlesource.com/704716 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#508363} [modify] https://crrev.com/0502f56e5ba44fdd5c10ffaeb4f863979c692efe/third_party/WebKit/Source/modules/media_controls/elements/MediaControlCastButtonElement.cpp [modify] https://crrev.com/0502f56e5ba44fdd5c10ffaeb4f863979c692efe/third_party/WebKit/Source/modules/media_controls/elements/MediaControlCastButtonElement.h [modify] https://crrev.com/0502f56e5ba44fdd5c10ffaeb4f863979c692efe/third_party/WebKit/Source/modules/media_controls/elements/MediaControlInputElement.cpp [modify] https://crrev.com/0502f56e5ba44fdd5c10ffaeb4f863979c692efe/third_party/WebKit/Source/modules/media_controls/elements/MediaControlInputElement.h [modify] https://crrev.com/0502f56e5ba44fdd5c10ffaeb4f863979c692efe/third_party/WebKit/Source/modules/media_controls/elements/MediaControlMuteButtonElement.cpp [modify] https://crrev.com/0502f56e5ba44fdd5c10ffaeb4f863979c692efe/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverlayPlayButtonElement.cpp [modify] https://crrev.com/0502f56e5ba44fdd5c10ffaeb4f863979c692efe/third_party/WebKit/Source/modules/media_controls/elements/MediaControlPlayButtonElement.cpp [modify] https://crrev.com/0502f56e5ba44fdd5c10ffaeb4f863979c692efe/third_party/WebKit/Source/modules/media_controls/elements/MediaControlToggleClosedCaptionsButtonElement.cpp
Verified in M64-64.0.3243.0. Not see the icons before overflow options like in the attached screen shot. Here I am attaching the testing screenshot
You need the "Icons on Media Controls Overflow Menu" enabled in chrome://flags
Comment 1 by beccahughes@chromium.org
, Oct 6 2017