New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 771949 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

[Media controls] Mute / unmute icon should toggle

Project Member Reported by rachelis@chromium.org, Oct 5 2017

Issue description

Mute/unmute icon shapes in the menu item should toggle

Please see screenshot. Becca - do you have the asset you need for this? :)
 
Screen Shot 2017-10-05 at 1.50.21 PM.png
978 KB View Download
Status: Started (was: Untriaged)
Yes I do, the state is just not persisted.
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0502f56e5ba44fdd5c10ffaeb4f863979c692efe

commit 0502f56e5ba44fdd5c10ffaeb4f863979c692efe
Author: Becca Hughes <beccahughes@chromium.org>
Date: Thu Oct 12 16:19:14 2017

Media Controls: Mute / unmute icon should toggle.

Icons are updated by the "UpdateDisplayState" function which
was not being called on the child overflow elements. Now if the
parent updates it's display type we will update the display state
of the child overflow element too.

BUG= 771949 

Change-Id: I383cb5095e7841c1ff63b5af142b7cac9364986e
Reviewed-on: https://chromium-review.googlesource.com/704716
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508363}
[modify] https://crrev.com/0502f56e5ba44fdd5c10ffaeb4f863979c692efe/third_party/WebKit/Source/modules/media_controls/elements/MediaControlCastButtonElement.cpp
[modify] https://crrev.com/0502f56e5ba44fdd5c10ffaeb4f863979c692efe/third_party/WebKit/Source/modules/media_controls/elements/MediaControlCastButtonElement.h
[modify] https://crrev.com/0502f56e5ba44fdd5c10ffaeb4f863979c692efe/third_party/WebKit/Source/modules/media_controls/elements/MediaControlInputElement.cpp
[modify] https://crrev.com/0502f56e5ba44fdd5c10ffaeb4f863979c692efe/third_party/WebKit/Source/modules/media_controls/elements/MediaControlInputElement.h
[modify] https://crrev.com/0502f56e5ba44fdd5c10ffaeb4f863979c692efe/third_party/WebKit/Source/modules/media_controls/elements/MediaControlMuteButtonElement.cpp
[modify] https://crrev.com/0502f56e5ba44fdd5c10ffaeb4f863979c692efe/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverlayPlayButtonElement.cpp
[modify] https://crrev.com/0502f56e5ba44fdd5c10ffaeb4f863979c692efe/third_party/WebKit/Source/modules/media_controls/elements/MediaControlPlayButtonElement.cpp
[modify] https://crrev.com/0502f56e5ba44fdd5c10ffaeb4f863979c692efe/third_party/WebKit/Source/modules/media_controls/elements/MediaControlToggleClosedCaptionsButtonElement.cpp

Status: Fixed (was: Started)
Verified in M64-64.0.3243.0.
Not see the icons before overflow options like in the attached screen shot.

Here I am attaching the testing screenshot
Overflowicons.png
393 KB View Download
You need the "Icons on Media Controls Overflow Menu" enabled in chrome://flags

Sign in to add a comment