New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 771924 link

Starred by 1 user
Status: Fixed
Owner:
█ jialiul@chromium.org
Last visit > 30 days ago
Closed: Oct 2017
Cc:
ajha@chromium.org
emilyschechter@chromium.org
nyerramilli@chromium.org
ligim...@chromium.org
vakh@chromium.org
mac-bugs-priority@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug

Blocked on:
issue 771872


Sign in to add a comment

Chrome crashes on clicking "Site is legitimate" on scary warning

Project Member Reported by hdodda@chromium.org, Oct 5 2017 
Chrome Version: 63.0.3233.0
OS: Mac OS 10.12.6

What steps will reproduce the problem?
(1) Launch chrome through command line with flags "--enable-features="PasswordProtectionGoogleBrandedPhishingWarning<GaiaPasswordReuse" and "--force-fieldtrials=GaiaPasswordReuse/ScaryWarning "
(2) Verify "Protect you and your device from dangerous sites [checked]" in chrome://settings and People → Sync  -->▶  Passwords [checked],  “Encrypt synced passwords with your Google username and password [selected]
(3) Navigate "http://testsafebrowsing.appspot.com/s/bad_login.html" and enter password and the scary warning dialog appears.
(4) Click on ignore and click on “/!\ Dangerous”  security state to open page info bubble .
(5) Click on “Site is legitimate” button and observe that chrome crashes.

What is the expected result?

Chrome shouldn't crash and security state should change to “Secure”

What happens instead?

Chrome crashes.

Please use labels and text to provide additional information.

Crash id : 485d6ced64bdffdc

 This crash is already been associated with issue 682229 and is duped into issue 583049..

Attached screencast of crash for reference. This issue is seen only on Mac OS. This crash is seen in M63 #63.0.3232.0.
UseCase3_site legitimate_click_crash.mp4
451 KB View Download

Comment 1 by jialiul@chromium.org, Oct 5 2017

Labels: SafeBrowsing-Triaged
investigating....
Cannot reproduce locally. Based on the stacktrace, it might be some code outside PhishGuard triggered this crash. 

I'll give a try on the next Canary version.

Comment 2 by jialiul@chromium.org, Oct 5 2017

Blockedon: 771872
 crbug.com/771872  is blocking the repro of this issue.

Comment 3 by jialiul@chromium.org, Oct 6 2017

Status: Started (was: Assigned)
Successfully reproduced in 63.3234.* on Mac OS when the material design flag is off. 
I'm still investigating the root cause. It is most likely caused by cocoa code in chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.mm
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7ffc412029188fe9f2ec7b155d32f57dbff4544

commit f7ffc412029188fe9f2ec7b155d32f57dbff4544
Author: Jialiu Lin <jialiul@chromium.org>
Date: Mon Oct 09 16:47:31 2017

Fix browser crash when clicking "Change Password" or "Site is legitimate"

Bug:  771924 
Change-Id: Ib4feb9a121bef8d76ba3ec07a531e3504b37865a
Reviewed-on: https://chromium-review.googlesource.com/706137
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507392}
[modify] https://crrev.com/f7ffc412029188fe9f2ec7b155d32f57dbff4544/chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.mm

Comment 5 by jialiul@chromium.org, Oct 9 2017

Status: Fixed (was: Started)
Should be fixed. I'll wait for the next Canary to verify.

Comment 6 by hdodda@chromium.org, Oct 12 2017

Labels: TE-Verified-63.0.3238.0 TE-Verified-M63
verified the issue on mac os 10.12.6 using chrome M63 #63.0.3238.0 and issue seems fixed.

No crash is seen when clicking site is legitimate.

Adding TE-Verified labels.

Thanks!
►

Sign in to add a comment