New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 771923 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 12
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

[Media controls] Overflow menu typeface treatment should be consistent with dialog/overflow spec

Project Member Reported by rachelis@chromium.org, Oct 5 2017

Issue description

Hwi identified this inconsistency (see attached). 

Hannah - is there high level guidance on the right type treatment for overflow menus? I see the stickersheet uses the styles in the attached screenshot. Should we match for that here? I don't see the long-press menu in the stickersheet. :)
 
Screen Shot 2017-10-05 at 11.41.50 AM.png
248 KB View Download
Screen Shot 2017-10-05 at 11.49.01 AM.png
144 KB View Download
Screen Shot 2017-10-05 at 12.04.47 PM.png
100 KB View Download
For the overflow menu we currently use Material specs at 16sp. https://material.googleplex.com/components/menus.html#menus-specs

However, because you are using 2 lines here, I'd use the Material "two line list" specs (Primary text font: 16sp Secondary text font: 14sp) or use the template in the Settings section in the Stickersheet. https://material.googleplex.com/components/lists.html#lists-specs

If you feel that this is too large for your space, you can also use the Material "Dense two-line list specs" at 13sp which is what we're using in all our bookmarks, history etc. but I'd recommend staying consistent with our overflow menus if possible.

The long press menu is something that Chris is working on now, but it should also be following Material specs (which is why the Context menu is also being currently redesigned)....

For future reference, all of our text should be using Material specs moving forward so I'd always check there first as a source of truth. (Though I will be sending out my next Stickersheet update for Q4 soon articulating this so please send me your sketch files when you're ready!)

Amy - I'm out for a week. Would you mind taking a look at this?
Thanks Hannah!

Hwi - would you be comfortable in this case with us using the Material "two line list" as Hannah suggests?

Comment 4 by cl...@chromium.org, Oct 18 2017

Cc: -hwi@chromium.org cl...@chromium.org
Hey Rachel, I'm following up for Hwi here.

Per Hannah's guidance and MD guidance, we should follow standard list specs here:
- Single line row: 16sp text in 48dp row
- Two line row: 16sp primary text, 14sp secondary text in 72dp row

We should use single rows except where there are the row is in fact a two line row. Using two line rows for everything would cause excessive white space, especially in the case of the first screenshot in this bug. Hannah, let us know if you disagree.
Sgtm!
Status: Assigned (was: Untriaged)
Status: Fixed (was: Assigned)
Fixed with the M69 Modern update

Sign in to add a comment