New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 771916 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

DCHECK failure in units_.empty() in module-compiler.cc

Project Member Reported by ClusterFuzz, Oct 5 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5488266068623360

Fuzzer: ochang_js_fuzzer
Job Type: linux_asan_d8_dbg
Platform Id: linux

Crash Type: DCHECK failure
Crash Address: 
Crash State:
  units_.empty() in module-compiler.cc
  ~CompilationUnitBuilder
  v8::internal::wasm::AsyncStreamingProcessor::ProcessCodeSectionHeader
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_d8_dbg&range=48021:48022

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5488266068623360

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Cc: clemensh@chromium.org mtrofin@chromium.org
Components: -Blink>JavaScript Blink>JavaScript>WebAssembly
Owner: ahaas@chromium.org
Status: Assigned (was: Untriaged)
Regression range points to 549692cbc0ab4e9929e6e5f13db879072b119fb0.
Project Member

Comment 2 by sheriffbot@chromium.org, Oct 5 2017

Labels: M-63
Project Member

Comment 3 by sheriffbot@chromium.org, Oct 5 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by sheriffbot@chromium.org, Oct 5 2017

Labels: Pri-1

Comment 5 by ahaas@chromium.org, Oct 5 2017

Status: Started (was: Assigned)

Comment 6 by ahaas@chromium.org, Oct 5 2017

Labels: -Stability-Memory-AddressSanitizer -Restrict-View-SecurityTeam -Security_Impact-Head -Security_Severity-High -ReleaseBlock-Stable
This is not a security regression because it requires a testing flag.
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/44c400eeafd525c4706ad3851ca0b43fae1bdfe2

commit 44c400eeafd525c4706ad3851ca0b43fae1bdfe2
Author: Andreas Haas <ahaas@chromium.org>
Date: Thu Oct 05 15:11:02 2017

[wasm] Fail upon second code section in streaming compilation

At the moment we check only in the module-decoder if the sections in a
module appear at most once. The code section, however, we process
already before this check. With this CL we check that there is at most
one code section before we start processing it.

R=clemensh@chromium.org
TEST=WasmStreamingDecoderTest.TwoCodeSections

Bug:  chromium:771916 
Change-Id: Icc79d5a87ab39f450a35c688f74ea5e67cae4b3c
Reviewed-on: https://chromium-review.googlesource.com/702379
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#48314}
[modify] https://crrev.com/44c400eeafd525c4706ad3851ca0b43fae1bdfe2/src/wasm/streaming-decoder.cc
[modify] https://crrev.com/44c400eeafd525c4706ad3851ca0b43fae1bdfe2/src/wasm/streaming-decoder.h
[modify] https://crrev.com/44c400eeafd525c4706ad3851ca0b43fae1bdfe2/test/unittests/wasm/streaming-decoder-unittest.cc

Labels: Security_Impact-None
Project Member

Comment 9 by ClusterFuzz, Oct 7 2017

ClusterFuzz has detected this issue as fixed in range 48313:48314.

Detailed report: https://clusterfuzz.com/testcase?key=5488266068623360

Fuzzer: ochang_js_fuzzer
Job Type: linux_asan_d8_dbg
Platform Id: linux

Crash Type: DCHECK failure
Crash Address: 
Crash State:
  units_.empty() in module-compiler.cc
  ~CompilationUnitBuilder
  v8::internal::wasm::AsyncStreamingProcessor::ProcessCodeSectionHeader
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_d8_dbg&range=48021:48022
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_d8_dbg&range=48313:48314

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5488266068623360

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 10 by ClusterFuzz, Oct 7 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase 5488266068623360 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 11 by sheriffbot@chromium.org, Oct 7 2017

Labels: Restrict-View-SecurityNotify
Project Member

Comment 12 by sheriffbot@chromium.org, Jan 13 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment