New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 771911 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug


Sign in to add a comment

[signin] AccountReconcilor should logout less

Project Member Reported by droger@chromium.org, Oct 5 2017

Issue description

In some cases the AccountReconcilor does a full logout followed by a sequence of MergeSessions.

This can be a problem if some error (invalid token, connectivity issue) happens during the reconcile after the logout has been done, as it leaves the users in a signed-out state.

In particular at startup, when Chrome assumes that all invalid the tokens are valid again, the reconcile can fail after logout, and then eventually signin the user in the exact same state they were before the reconcile, which is unnecessary churn on the account.

See design doc:
https://docs.google.com/a/google.com/document/d/1GeqALUSPcUaisTnSTgNZEHxKXy7QOcPA_wk0gEu07fk/edit?usp=sharing

And subsection in Dice doc:
https://docs.google.com/document/d/1gx7_pjcWkCj52WABcAF_E1dsYnBJtwkxgsLvBooncqk/edit?ts=5967b289&pli=1#heading=h.o67k3qgm8vs4
 
As per discussion with Mihai, Dice is not blocked on this for now.

We'll monitor the AccountReconcilor metrics and can decide to block Dice on this later if we see that there is too much churn on the accounts at startup.
For posterity, I started a CL to add support for oauth multilogin in google_apis:
https://chromium-review.googlesource.com/c/chromium/src/+/702483

I'm not actively working on it, but it could be a good starting point when we pick up this bug again in the future.

Comment 3 by ew...@chromium.org, Oct 5 2017

Could we include a metric for how many times we "unnecessarily" reconcile (and end up back in the same state)? Maybe a histogram which is a distribution over time for how long these unnecessary reconciles take?
Project Member

Comment 4 by sheriffbot@chromium.org, Nov 6 2017

Status: Available (was: Assigned)
--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by droger@chromium.org, Apr 17 2018

Cc: sabineb@chromium.org droger@chromium.org jlebel@chromium.org tangltom@chromium.org ach...@gmail.com bsazonov@chromium.org
 Issue 501352  has been merged into this issue.
Status: Assigned (was: Available)
 Issue 764305  has been merged into this issue.
Cc: -droger@chromium.org valeriyas@google.com nickk@google.com
Status: Started (was: Assigned)
Valeriya is going to work on this.
Blockedon: 872724
Blockedon: 872725
Blockedon: 872726
Blockedon: 875917
Blockedon: 875922
Cc: -valeriyas@google.com -ew...@chromium.org droger@chromium.org
Owner: valeriyas@google.com
Blockedon: 876321
Blockedon: 876622
Blockedon: 882846
Blockedon: 889471
Blockedon: 890321
Blockedon: 890933
Owner: droger@chromium.org

Sign in to add a comment