Guard all feature_engagement calls in chrome with ENABLE_DESKTOP_IN_PRODUCT_HELP
Reported by
apili...@gmail.com,
Oct 5 2017
|
|||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.71 YaBrowser/17.10.0.1289 Yowser/2.5 Safari/537.36 Steps to reproduce the problem: 1. Open chrome/browser/ui/omnibox/chrome_omnibox_client.cc 2. See reference to NewTabTrackerFactory What is the expected behavior? Guarded with ENABLE_DESKTOP_IN_PRODUCT_HELP as in chrome/browser/ui/tabs/tab_strip_model.cc What went wrong? It's guarded with #if !defined(OS_ANDROID) && !defined(OS_CHROMEOS) && !defined(OS_MACOSX) Did this work before? N/A Chrome version: 61.0.3163.71 Channel: n/a OS Version: OS X 10.12.6 Flash Version: Shockwave Flash 27.0 r0 That's a CodeHealth issue.
,
Oct 6 2017
As per Summary Issue looks to be related to CodeHealth. Seems it is out of scope from TE end, adding TE-NeedsTraige-help label to move this out of our triaging bucket. Could someone from dev team please take a look into this issue. Thanks..!!
,
Oct 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d58cc5fd0a65a6c742b27447d99f4dcd4bacf56a commit d58cc5fd0a65a6c742b27447d99f4dcd4bacf56a Author: Bettina Dea <bdea@chromium.org> Date: Tue Oct 10 01:03:12 2017 Use the ENABLE_DEKSTOP_IPH flag in chrome_omnibox_client. Bug: 771907 Change-Id: I75ed70e684e7cf4953199a1b1b969d713a28ab60 Reviewed-on: https://chromium-review.googlesource.com/707931 Reviewed-by: Michael Wasserman <msw@chromium.org> Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Reviewed-by: Robert Liao <robliao@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#507559} [modify] https://crrev.com/d58cc5fd0a65a6c742b27447d99f4dcd4bacf56a/chrome/browser/ui/omnibox/chrome_omnibox_client.cc
,
Oct 10 2017
There are still code sites where IPH usage is not properly guarded: chrome/browser/ui/browser_command_controller.cc:419 chrome/browser/ui/browser_command_controller.cc:427 Could you please fix them too?
,
Oct 17 2017
,
Nov 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ee7209288e9fa1349bb8148d93101c7d71cc3cc6 commit ee7209288e9fa1349bb8148d93101c7d71cc3cc6 Author: Anatoly Pilikov <zverre@yandex-team.ru> Date: Wed Nov 01 09:43:17 2017 Guard with ENABLE_DESKTOP_IN_PRODUCT_HELP build flag Bug: 771907 Change-Id: Ib15de7a0792d370f75d17275670abb8685b68585 Reviewed-on: https://chromium-review.googlesource.com/738138 Reviewed-by: David Trainor <dtrainor@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Andrey Kraynov <iceman@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#513101} [modify] https://crrev.com/ee7209288e9fa1349bb8148d93101c7d71cc3cc6/chrome/browser/ui/browser_command_controller.cc [modify] https://crrev.com/ee7209288e9fa1349bb8148d93101c7d71cc3cc6/chrome/test/BUILD.gn [modify] https://crrev.com/ee7209288e9fa1349bb8148d93101c7d71cc3cc6/components/feature_engagement/public/feature_list.h |
|||
►
Sign in to add a comment |
|||
Comment 1 by apili...@gmail.com
, Oct 5 2017