New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 771906 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Media controls - overflow menu radius doesn't match Clank standard

Project Member Reported by rachelis@chromium.org, Oct 5 2017

Issue description

Hwi pointed out that we don't match the standard Clank radius with our overflow menu. We should correct that. 

Looking at the stickersheet, I see radii that are 0,1, and 2. Hannah - can you let us know what the guidance is here? We'll update to match.
 
Screen Shot 2017-10-05 at 11.06.59 AM.png
147 KB View Download
Cc: amyroberts@chromium.org
Oops - +Amy!
Hi and thanks for filing this bug Rachel! Stable Chrome's current corner radius is set by a 9-patch (1dp at mdpi) but you should be able to reuse the app menu background asset called "menu_bg") - so hopefully you guys don't need to rebuild it / can use this to make your file size smaller. (I recently shaved a lot off the png so it's nearly half the size).
We unfortunately can't re-use the 9-patch image as the media controls UI is coming from a different place. The media controls overflow menu is used on desktop too for example. I think it might be interesting to converge the style though.
Agreed, it'd make sense for them to all be the same. How do we draw the radii on harmony dialogs? Can we use the same shadow/corner styling if they're the same as clank? 
Cc: edwardjung@chromium.org
Apologies, I didn't realize that 9-patches are an Android specific image format... 

+Edward - by any chance do you know of any webUI that uses the same overflow menu background drop shadow as our standard Clank menus?

If not we may need to build this from scratch as it seems like desktop uses a different shadow and corner radius (with an added outline that I believe changes based on display resolution).


We don't use Web UI for the media controls too but CSS. I think given the screenshot above, beccahughes@ should be able to update our overflow to be closer to the Android UI.
I'm not aware of any WebUI overflow menus that match that style. The settings pages are the closest in terms of Material styling, but even they don't use custom drop down menus which I think would be closest.  
Cc: -edwardjung@chromium.org
Gotcha, thanks for the fast response! Please let me know how you'd prefer specs for the corner/shadow (or feel free to ping me directly! Thanks!)
Status: Assigned (was: Untriaged)

Sign in to add a comment