New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 771886 link

Starred by 1 user
Status: Fixed
Owner:
dullweber@chromium.org
Closed: Oct 2017
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression
Team-Security-UX



Sign in to add a comment

Regression:Close "X" button is not working in site settings

Reported by shruti.j...@etouch.net, Oct 5 2017 
Chrome Version: 63.0.3233.0 (Official Build)e8cc7650d44155e942550b9c730eafc9c5ba8ab6-refs/heads/master@{#506599}(32/64-bit) 

OS: Windows (7,8,10),Linux (14.04 LTS), Mac(10.12.6)

Test URL: https://www.google.com/gmail/about/#

Steps to reproduce:
1.Launch chrome, go to the above URL and go to site settings from omnibox by clicking on Secure.
2.Click on back arrow button, go to cookies and navigate to 'See all cookies and site data' sub-page.
3.Click on any of one entries and click on cross button.
4.Observe.

Actual Result: Cross button is not working.
Expected Result:Cross button should work.

This is Regression Issue broken in M-63 and and Using the per-revision bisect providing the bisect results,
Good Build: 63.0.3232.0
Bad Build: 63.0.3233.0

Comment 1 by shruti.j...@etouch.net, Oct 5 2017

Cc: msrchandra@chromium.org ranjitkan@chromium.org rbasuvula@chromium.org nyerramilli@chromium.org
Components: UI>Browser>Omnibox UI>Browser>SiteSettings
Labels: hasbisect-per-revision OS-Linux OS-Mac OS-Windows
Owner: dullweber@chromium.org
Status: Assigned (was: Unconfirmed)
Pre-condition:Navigate to site setting from omnibox

Good Build: 63.0.3232.0(Revision:506257)
Bad Build:  63.0.3233.0(Revision:506599)

You are probably looking for a change made after 506373 (known good), but no later than 506374 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/bf8877ba9a564c69358807a9b4e2d83e1a97b42a..dd4cb59466c7a1e779c0c2e267762974d0023218

Suspect:https://chromium.googlesource.com/chromium/src/+/dd4cb59466c7a1e779c0c2e267762974d0023218

@dullweber:Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.
Thank You
Expectedcross.mp4
636 KB View Download
Actualcross.mp4
684 KB View Download

Comment 2 by ranjitkan@chromium.org, Oct 5 2017

Labels: ReleaseBlock-Stable
Summary: Regression:Close "X" button is not working in site settings (was: Regression:Cross button is not working in site settings)
Tagging with blocker label, please undo if not the case.

Thanks.!

Comment 3 by dullweber@chromium.org, Oct 5 2017 

Thanks for reporting this issue. I created a fix https://crrev.com/c/702278

I noticed that there is a navigation issue when clicking on a site. You have to click twice because the first click immediately brings you back. This seems unrelated to my change, could you file a bug for this as well?

Comment 4 by shruti.j...@etouch.net, Oct 5 2017 

With respect to comment#3
The issue has been raised for this twice navigation.
Thank You
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3df0d0574d1f53e831bd5d9f7ae9c825c0c8cb38

commit 3df0d0574d1f53e831bd5d9f7ae9c825c0c8cb38
Author: Christian Dullweber <dullweber@chromium.org>
Date: Fri Oct 06 10:49:00 2017

Reload site_details_subpage if visited with same site

The change to reload siteData when being visited again requires that
site_details are reloaded as well because deletion doesn't work
with old ids.

Bug:  771886 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I77b72ceb831f07c64abd519da47fc8db8d0f2f54
Reviewed-on: https://chromium-review.googlesource.com/702278
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507027}
[modify] https://crrev.com/3df0d0574d1f53e831bd5d9f7ae9c825c0c8cb38/chrome/browser/resources/settings/site_settings/site_data_details_subpage.js

Comment 6 by dullweber@chromium.org, Oct 6 2017

Status: Fixed (was: Assigned)
The issue should be fixed now

Comment 7 by shruti.j...@etouch.net, Oct 9 2017

Labels: TE-Verified-63.0.3236.0 TE-Verified-63
Note:
Retested the above issue on Canary #63.0.3236.0(PGO) on Windows(7,8,10), Linux(14.04 LTS), MAC(10.12.6) and fix is working as intended.
Kindly refer the attached verified screencast.

Thank You
CLOSEBUTTON.mp4
632 KB View Download
►

Sign in to add a comment