Regression: Username and Password text looks weird on save password bubble (Win/Linux/CrOS)
Reported by
dchau...@etouch.net,
Oct 5 2017
|
|||||||||||||||||
Issue descriptionChrome Version: 63.0.3233.0 (Official Build)e8cc7650d44155e942550b9c730eafc9c5ba8ab6-refs/heads/master@{#506599} 32/64-bit. OS: Windows(7,8,10) What steps will reproduce the problem? 1. Launch chrome and sign in to www.gmail.com with valid credentials. 2. Now multiple times click on show password icon on save password bubble and observe. Username and Password text looks weird. Username and Password text should seen properly. This is a regression issue, broken in M-63 series, will soon update other info.
,
Oct 5 2017
Tagging with blocker label, please undo if not the case.
,
Oct 5 2017
This is expected look of save prompt. No worries :) Thanks for pointing out.
,
Oct 5 2017
With respond to comment #3: After multiple times clicking on eye icon (show password icon) on save password bubble, texts 'Username' and 'Password' are getting bold and looks weird in font. Kindly refer the attached Actual behavior screen-cast and Password_bubble_Actual screenshot for the reference.
,
Oct 6 2017
oh, got it. Thanks. vasilii: something is wrong even with old layout. I tried to copy code from bookmarks https://cs.chromium.org/chromium/src/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc?rcl=a77261a2b7367519e13a15880c5ab6174c1bbf1b&l=281 The bookmarks set row_height based on fonts (https://cs.chromium.org/chromium/src/chrome/browser/ui/views/harmony/textfield_layout.cc?gsn=AddFirstTextfieldRow&l=22). I will take a look if I have time.
,
Oct 6 2017
I think it's a mistake. I don't see how font is connected with the height of the row. The font should be hardcoded and the height determined dynamically by the layout.
,
Oct 6 2017
Adding Internals>Views>Desktop in case relevant people know the problem.
,
Oct 6 2017
For Views folks: Toggling passwords visibility (https://cs.chromium.org/chromium/src/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc?rcl=08e161eecbdb3293fdbfbb4ce5dc736391024aad&l=539) in the bubble should not affect on font, but for some reason it does.
,
Oct 10 2017
adding views folks to the thread. The label element (https://cs.chromium.org/chromium/src/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc?rcl=26c452fd56661c7c0597385c6882488d4b117ffa&l=270) should stay unchanged when a user clicks at another element (the eye icon https://cs.chromium.org/chromium/src/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc?rcl=08e161eecbdb3293fdbfbb4ce5dc736391024aad&l=539).
,
Oct 10 2017
,
Oct 10 2017
TogglePasswordVisibility() calls CreateAndSetLayout() which re-adds all the views? It seems possible that the views are being stacked and painted on top of one another? The view shouldn't need to layout, let alone recreate the layout on this interaction. Please take another look.
,
Oct 16 2017
Maxim, are you working on this? It looks pretty weird if you click the eye icon many times. This definitely should be merged.
,
Oct 17 2017
Started. My suggestion is to implement mutable ComboboxModel. Let's discuss in person.
,
Oct 17 2017
,
Oct 17 2017
Maxim, we have labels which are as good as the title :)
,
Oct 17 2017
Labels are not shown when you see the list of bugs that block the given bug.
,
Oct 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/356eb23202702b62eeb36c3727a5db816704c181 commit 356eb23202702b62eeb36c3727a5db816704c181 Author: Maxim Kolosovskiy <kolos@chromium.org> Date: Wed Oct 18 14:00:04 2017 [Password Manager] Don't recreate layout of a save prompt when passwords visiblity has changed Bug: 771878 Change-Id: Idf39c939154da6d143934858ba88c96d5312fa4a Reviewed-on: https://chromium-review.googlesource.com/723319 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#509761} [modify] https://crrev.com/356eb23202702b62eeb36c3727a5db816704c181/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
,
Oct 19 2017
Without this fix, UI of save password prompt looks weird. Should be fixed.
,
Oct 20 2017
Your change meets the bar and is auto-approved for M63. Please go ahead and merge the CL to branch 3239 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2dcedcf0bb2126cff1b6a6eb2111db5c5aa5b306 commit 2dcedcf0bb2126cff1b6a6eb2111db5c5aa5b306 Author: Maxim Kolosovskiy <kolos@chromium.org> Date: Fri Oct 20 09:27:32 2017 [Password Manager] Don't recreate layout of a save prompt when passwords visiblity has changed Bug: 771878 Change-Id: Idf39c939154da6d143934858ba88c96d5312fa4a Reviewed-on: https://chromium-review.googlesource.com/723319 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#509761}(cherry picked from commit 356eb23202702b62eeb36c3727a5db816704c181) Reviewed-on: https://chromium-review.googlesource.com/729864 Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#106} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/2dcedcf0bb2126cff1b6a6eb2111db5c5aa5b306/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
,
Oct 20 2017
,
Oct 23 2017
Update: Retested this issue on Windows-(7,8,10) machine using latest Canary build # 64.0.3247.0 (Official Build) and fix is working as expected i.e. Username and Password text seen properly after multiple times clicking on eye (show password) icon. Attaching screen-cast for the same.
,
Oct 24 2017
Update: Retested this issue on Windows-(7,8,10) machine using Dev build # 63.0.3239.16 (Official Build) and fix is working as expected i.e. Username and Password text seen properly after multiple times clicking on eye (show password) icon. Attaching screen-cast for the same. |
|||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||
Comment 1 by dchau...@etouch.net
, Oct 5 2017Owner: kolos@chromium.org
Status: Assigned (was: Unconfirmed)
Summary: Regression: Username and Password text looks weird on save password bubble. (was: Regression: Username and Password looks weird on save password bubble.)
1.8 MB
1.8 MB View Download
669 KB
669 KB View Download