New issue
Advanced search Search tips

Issue 771864 link

Starred by 1 user
Status: Fixed
Owner:
vapier@chromium.org
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

nassh: terminal shortcuts sent to connection dialog result in confusing behavior

Project Member Reported by vapier@chromium.org, Oct 5 2017 
people used to hitting ctrl+shift+n to open a new terminal window get confused when the connection dialog is displayed ... in this case, the terminal keyboard/keymap isn't active, so we get the standard browser behavior.  namely, an incognito window pops up.

we could add specific checks for ctrl+shift+n and ctrl+n here ... it wouldn't help if people have custom keyboard shortcuts, but i guess we have to start somewhere.  are there any other shortcuts we should emulate ?
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/apps/libapps/+/b86c7eded149413b11ba2395dcb5992d1b23bbd0

commit b86c7eded149413b11ba2395dcb5992d1b23bbd0
Author: Mike Frysinger <vapier@chromium.org>
Date: Mon Oct 16 19:43:37 2017

nassh: ignore common browser shortcuts in connection dialog

Some common browser shortcuts don't make sense in the terminal, and when
users expect them to behave like the terminal (e.g. Ctrl+Shift+N opens a
new terminal, not a new incognito window), they can get confused.  Have
the connection dialog swallow common shortcuts that don't make sense.
We retain a few that do like refreshing/closing/debug consoles.

In an ideal world, we'd look up all the shortcuts the user has bound in
the terminal and replicate them here, but that will require quite a bit
of rework as the dialog currently pulls in no hterm code.

BUG= chromium:771864 

Change-Id: I8586ce08808c0f1974bdcbd0b1b3780d7f838b6b
Reviewed-on: https://chromium-review.googlesource.com/715216
Reviewed-by: Brandon Gilmore <varz@google.com>
Tested-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/b86c7eded149413b11ba2395dcb5992d1b23bbd0/nassh/js/nassh_connect_dialog.js

Comment 2 by vapier@chromium.org, Oct 16 2017

Owner: vapier@chromium.org
Status: Fixed (was: Available)
should be resolved with nassh-0.8.38+
►

Sign in to add a comment