Status icons unused? |
||||
Issue descriptionIt seems that status_icons are not used or are minimally used. DisplayBalloon and SetTooltip are never called on Linux, despite being implemented; it seems the former is only used on Windows for the background app installed notification. Can we just use a normal notification for this (i.e. NotificationDisplayService)? There's an extension api for system indicators, but it hasn't been touched since at least 2015 and as best as I can tell never made it out of experimental? It's not in the online Chrome extensions docs that I can find.
,
Oct 5 2017
+Drew since we afaik only use them for background mode
,
Oct 5 2017
When last I looked at this code, we use a status tray icon to note when Chrome is running in background mode (no open windows). So I don't think we can remove the implementation entirely. I'm fine if people wanna rip out the un-implemented/uncalled pieces of the API tho (SetTooltip, I guess).
,
Oct 5 2017
+devlin do you know the state of the system indicator extension api?
,
Oct 10 2017
It's been in limbo for years. IIRC, we were never sure we wanted extensions to have that UI and there were numerous bugs, so we didn't want to launch it (and would rather get rid of it). But hangouts uses it. I think they once tried to remove it and were met with various pitchforks. I'd be supportive of either launching it fully or removing it (I'd lean towards the latter, but mostly just want it out of limbo), but don't currently have the bandwidth to drive the effort.
,
Nov 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9a1b9a938ce00d260e314ebf6bdb89982dfe2a82 commit 9a1b9a938ce00d260e314ebf6bdb89982dfe2a82 Author: Evan Stade <estade@chromium.org> Date: Wed Nov 29 23:21:32 2017 Make DesktopNotificationBalloon use the NotificationDisplayService. It's safe to remove the 6 second timeout because there's already an 8 second default timeout. Bug: 771839, 783018 Change-Id: Idf122dfa2367844be7020d13a8c4d0d750561e0c Reviewed-on: https://chromium-review.googlesource.com/772783 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by: Drew Wilson <atwilson@chromium.org> Cr-Commit-Position: refs/heads/master@{#520300} [modify] https://crrev.com/9a1b9a938ce00d260e314ebf6bdb89982dfe2a82/chrome/browser/status_icons/desktop_notification_balloon.cc [modify] https://crrev.com/9a1b9a938ce00d260e314ebf6bdb89982dfe2a82/chrome/browser/status_icons/desktop_notification_balloon.h
,
Jul 18
|
||||
►
Sign in to add a comment |
||||
Comment 1 by thomasanderson@chromium.org
, Oct 5 2017