New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 771835 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature



Sign in to add a comment

Clank Translate UI enhancement

Project Member Reported by goog...@chromium.org, Oct 5 2017

Issue description

We have launched TranslateCompactUI from M60.  http://crbug.com/703887 

Based on the data we collected from prod. We have some plan to improve the UI and make it better.


 
Cc: clingon@google.com
Components: UI>Browser>Language>Translate
Labels: -Type-Bug Type-Feature
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4af17aade7ce1f3aa48f7171b1852e7b742142da

commit 4af17aade7ce1f3aa48f7171b1852e7b742142da
Author: Leo Zhang <googleo@chromium.org>
Date: Fri Oct 06 02:45:21 2017

Make TabLayout text color finchable.

Our PM wants to make the font color of the non-selected language
finch-able to figure out a path forward with making the font darker.
Group 1 will be the default color and group 2 will be the 87% black.

I created the params with our feature TranslateCompactUI and tested by
'--force-fieldtrials=TranslateCompactUI/Enabled --force-fieldtrial-params
=TranslateCompactUI.Enabled:translate_tab_default_text_color/1'

Bug:  771835 
Change-Id: I0d2d4eea3707685b45b83e5d7d4079fa855deecd
Reviewed-on: https://chromium-review.googlesource.com/701994
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Leo Zhang <googleo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506956}
[modify] https://crrev.com/4af17aade7ce1f3aa48f7171b1852e7b742142da/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java
[modify] https://crrev.com/4af17aade7ce1f3aa48f7171b1852e7b742142da/chrome/browser/ui/android/infobars/translate_compact_infobar.cc
[modify] https://crrev.com/4af17aade7ce1f3aa48f7171b1852e7b742142da/chrome/browser/ui/android/infobars/translate_compact_infobar.h

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f67ae75892faf9c26b6dd59cebb26f6383068a62

commit f67ae75892faf9c26b6dd59cebb26f6383068a62
Author: Leo Zhang <googleo@chromium.org>
Date: Tue Oct 17 06:23:05 2017

Add metrics and an experiment when checking if a language is accepted.

Original check will load the whole accepted language code list, then
check whether the given code is in the list or not. But in Android
client, loading a list of codes will trigger 100+ JNI calls which
costs 30~60 ms (based on the local testings on my Nexus 6).

This change will call only one JNI to check whether a given language
is accepted in Chrome. It matters in Clank, because the JNI is very
expensive. It will save 30~60 ms for each check in my local testing.

Bug:771835

Change-Id: If2f3838492521373a139a4220c843fc7bc3b1f8b
Reviewed-on: https://chromium-review.googlesource.com/708097
Commit-Queue: Leo Zhang <googleo@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Jungshik Shin <jshin@chromium.org>
Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509303}
[modify] https://crrev.com/f67ae75892faf9c26b6dd59cebb26f6383068a62/components/translate/core/browser/translate_accept_languages.cc
[modify] https://crrev.com/f67ae75892faf9c26b6dd59cebb26f6383068a62/components/translate/core/browser/translate_accept_languages.h
[modify] https://crrev.com/f67ae75892faf9c26b6dd59cebb26f6383068a62/components/translate/core/browser/translate_accept_languages_unittest.cc
[modify] https://crrev.com/f67ae75892faf9c26b6dd59cebb26f6383068a62/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/f67ae75892faf9c26b6dd59cebb26f6383068a62/ui/base/l10n/l10n_util.cc
[modify] https://crrev.com/f67ae75892faf9c26b6dd59cebb26f6383068a62/ui/base/l10n/l10n_util.h

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00874e2dd62ddaff3357159673343b46c958a5b2

commit 00874e2dd62ddaff3357159673343b46c958a5b2
Author: Leo Zhang <googleo@chromium.org>
Date: Tue Nov 07 05:09:16 2017

Remove expriment after data collected from canary/dev versions.

In order to figure out the real cost of JNI calls on end users, I built
a fitch experiment. Now we got the result and remove this experiment.

BUG= 771835 

Change-Id: I392124700fd4505424954ce396f50a0e4e3fef7b
Reviewed-on: https://chromium-review.googlesource.com/750422
Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
Commit-Queue: Leo Zhang <googleo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514399}
[modify] https://crrev.com/00874e2dd62ddaff3357159673343b46c958a5b2/components/translate/core/browser/translate_accept_languages.cc
[modify] https://crrev.com/00874e2dd62ddaff3357159673343b46c958a5b2/components/translate/core/browser/translate_accept_languages.h
[modify] https://crrev.com/00874e2dd62ddaff3357159673343b46c958a5b2/components/translate/core/browser/translate_accept_languages_unittest.cc

Status: Verified (was: Assigned)

Sign in to add a comment