Issue metadata
Sign in to add a comment
|
Remove WebServiceWorkerEventResult |
||||||||||||||||||||||
Issue descriptionIn S13nSW, several layout tests are crashing because BrowserSideControllerServiceWorker tries to pass an error like SERVICE_WORKER_ERROR_FAILED to the callback for DispatchFetchEvent, which complains since that callbacks really needs a "ServiceWorkerEventStatus" which only allows conversion from OK, WAITUNTIL_REJECTED, or ABORTED. This is pretty bizarre and I believe we just have this for legacy reasons. I think we can get rid of WAIT_UNTIL_REJECTED and ServiceWorkerEventStatus should either just be a SUCCESS/FAIL or else we could possibly use blink::mojom::ServiceWorkerErrorType. Investigating.
,
Oct 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/125694f918e87ffcb1d7de29af9f148ccac43f4f commit 125694f918e87ffcb1d7de29af9f148ccac43f4f Author: Matt Falkenhagen <falken@chromium.org> Date: Fri Oct 06 06:01:06 2017 service worker: Remove WebServiceWorkerEventResult. It can be replaced with mojom::ServiceWorkerEventStatus. Bug: 771829 Change-Id: Ie6db6b3b61eadb371fedcbc2322b9ada4a84052a TBR: dcheng Reviewed-on: https://chromium-review.googlesource.com/702083 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#506991} [modify] https://crrev.com/125694f918e87ffcb1d7de29af9f148ccac43f4f/content/browser/DEPS [modify] https://crrev.com/125694f918e87ffcb1d7de29af9f148ccac43f4f/content/browser/push_messaging/push_messaging_router.h [modify] https://crrev.com/125694f918e87ffcb1d7de29af9f148ccac43f4f/content/common/DEPS [modify] https://crrev.com/125694f918e87ffcb1d7de29af9f148ccac43f4f/content/common/service_worker/service_worker_messages.h [modify] https://crrev.com/125694f918e87ffcb1d7de29af9f148ccac43f4f/content/renderer/service_worker/service_worker_context_client.cc [modify] https://crrev.com/125694f918e87ffcb1d7de29af9f148ccac43f4f/content/renderer/service_worker/service_worker_context_client.h [modify] https://crrev.com/125694f918e87ffcb1d7de29af9f148ccac43f4f/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.cpp [modify] https://crrev.com/125694f918e87ffcb1d7de29af9f148ccac43f4f/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h [modify] https://crrev.com/125694f918e87ffcb1d7de29af9f148ccac43f4f/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeProxy.cpp [modify] https://crrev.com/125694f918e87ffcb1d7de29af9f148ccac43f4f/third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.cpp [modify] https://crrev.com/125694f918e87ffcb1d7de29af9f148ccac43f4f/third_party/WebKit/public/BUILD.gn [delete] https://crrev.com/e811ce55fa4652fe3f10489363f1d6192455d692/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerEventResult.h [modify] https://crrev.com/125694f918e87ffcb1d7de29af9f148ccac43f4f/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h
,
Nov 7 2017
,
Nov 7 2017
Apologies, applied the wrong component in bulk.
,
May 14 2018
I fixed the main issue about crashing and the typemapping. There is probably more refactoring possible here. We still have REJECTED vs ABORTED in ServiceWorkerEventStatus and it's possible we only need one, and we have SERVICE_WORKER_ERROR_EVENT_WAITUNTIL_REJECTED still. But there is not much harm at the moment and there's no need for a bug for a vague refactoring idea. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Oct 6 2017