New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 771826 link

Starred by 1 user
Status: Fixed
Owner:
█ allada@chromium.org
Last visit > 30 days ago
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

SaveAs from sidebar without opening it in devtools saves empty file

Project Member Reported by allada@chromium.org, Oct 5 2017 
1. Open devtools with page that has a script
2. Make sure the script is not opened at all
3. Right click on file in sources panel and saveAs (without opening it)
4. Observe the file is empty.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df94806ee7380074b8320ccb62facb911e27f19c

commit df94806ee7380074b8320ccb62facb911e27f19c
Author: Nathan Bruer <allada@chromium.org>
Date: Wed Oct 18 20:52:11 2017

[Devtools] Fixed UISourceCode.saveAs() not always containing content

Fixed a bug if a call to UISourceCode.saveAs() would sometimes save the
content of the file as empty if the content has not yet been loaded into
the UISourceCode. It should now wait for the content to load if it has
not loaded then save the working copy.

R=lushnikov,pfeldman
BUG= 771826 

Change-Id: I2d3d3176ea3ab73ec8062a9230860f567244930a
Reviewed-on: https://chromium-review.googlesource.com/701625
Commit-Queue: Blaise Bruer <allada@chromium.org>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509867}
[add] https://crrev.com/df94806ee7380074b8320ccb62facb911e27f19c/third_party/WebKit/LayoutTests/http/tests/devtools/uisourcecode-has-content-on-save-expected.txt
[add] https://crrev.com/df94806ee7380074b8320ccb62facb911e27f19c/third_party/WebKit/LayoutTests/http/tests/devtools/uisourcecode-has-content-on-save.js
[modify] https://crrev.com/df94806ee7380074b8320ccb62facb911e27f19c/third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js

Comment 2 by pfeldman@chromium.org, Dec 13 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment