New issue
Advanced search Search tips

Issue 771817 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

MD-Bookmark "Edit" webui dialog buttons are in the wrong order on Windows, ChromeOS (Mac,Desktop-Linux is OK)

Project Member Reported by tapted@chromium.org, Oct 4 2017

Issue description

Chrome Version       : 63.0.3232.0
OS Version: 10.0

What steps will reproduce the problem?
1. [MD] chrome://bookmarks -> Right-Click -> Edit

What is the expected result?

Buttons on Windows should be ordered [OK/Yes/Save], [Cancel] to match native Chrome dialogs, the Native "Save" dialog, and others.

This is according to the Windows Human Interface Giude at https://msdn.microsoft.com/en-us/library/windows/desktop/dn742499.aspx (see "Present the commit buttons in the following order").

(Note the Mac HIG at https://developer.apple.com/macos/human-interface-guidelines/windows-and-views/dialogs/ "Position buttons as expected" specifies the opposite order).


What happens instead of that?

Buttons are ordered [Cancel], [Save].

Note this probably affects lots of md-bookmarks UI, not just this edit dialog.


The logic used for native ui (see cs.chromium.org/dialog_client_view.cc) is

#if defined(OS_WIN) || defined(OS_CHROMEOS)
const bool kIsOkButtonOnLeftSide = true;
#else
const bool kIsOkButtonOnLeftSide = false;
#endif


UserAgentString: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3232.0 Safari/537.36
 
Screen Shot 2017-10-05 at 10.40.47 am.png
67.4 KB View Download
Screen Shot 2017-10-05 at 10.44.22 am.png
56.9 KB View Download
Screen Shot 2017-10-05 at 10.41.03 am.png
52.0 KB View Download

Comment 1 by dpa...@chromium.org, Mar 22 2018

Cc: namratakannan@chromium.org
We have several dialogs in various WebUIs, not just bookmarks. Adding UX for consultation.

Sign in to add a comment