New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 771794 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 25
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Task
Proj-VR
Proj-XR
Proj-XR-VR

Blocking:
issue 773882



Sign in to add a comment

Some VR graphics tests are disabled on Windows. Fix before enabling VR support.

Project Member Reported by billorr@chromium.org, Oct 4 2017

Issue description

Some VR graphics tests are disabled on Windows.  Fix before enabling VR support.

Disabled tests:
GlTestEnvironmentTest.InitializeAndCleanup
UiPixelTest.DrawVrBrowsingMode
 
Components: Tests>Disabled
Labels: VR-Desktop
Blocking: 773882
Cc: mthiesse@chromium.org
Labels: -Type-Bug -Pri-3 M-64 Pri-2 Type-Task
Status: Available (was: Untriaged)
Owner: billorr@chromium.org
Status: Assigned (was: Available)
Labels: -M-64 M-65
Moving to 65.  This could be pushed out longer, as these tests are used to test VR browsing mode, which isn't enabled for Windows.
Components: Tests>Disabled
Labels: Test-Disabled
GpuMemoryBufferDXGI and similar tests should be enabled on GPU hardware.

These tests should be run when specific changes come through that could affect VR.  See chrome/browser/vr/PRESUBMIT.py for an example of triggering tests when specific files change.
Labels: -M-65 M-66
Moving to 66.

Comment 10 by ericde@google.com, Mar 21 2018

Labels: -M-66 M-67
Labels: -M-67 M-69
moving to 69 as 68 branch is approaching and this isn't critical yet.  I'll reevaluate if this is required for webvr/xr on desktop.
Labels: -M-69
Project Member

Comment 13 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9152d53ff4f0ed59c1d9e149c463e384dead73a1

commit 9152d53ff4f0ed59c1d9e149c463e384dead73a1
Author: Aldo Culquicondor <acondor@chromium.org>
Date: Tue Sep 25 14:55:14 2018

VR: Add Skia surface provider for command buffer

This is the last piece necessary in the VR UI to support the
command buffer.

Re-enable pixeltest for Windows.

Bug:  884256 ,  771794 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I8c0a67021c859a88b0af519ace97266a142ec7d7
Reviewed-on: https://chromium-review.googlesource.com/1238816
Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593933}
[modify] https://crrev.com/9152d53ff4f0ed59c1d9e149c463e384dead73a1/chrome/browser/vr/BUILD.gn
[add] https://crrev.com/9152d53ff4f0ed59c1d9e149c463e384dead73a1/chrome/browser/vr/cmd_buffer_surface_provider.cc
[add] https://crrev.com/9152d53ff4f0ed59c1d9e149c463e384dead73a1/chrome/browser/vr/cmd_buffer_surface_provider.h
[modify] https://crrev.com/9152d53ff4f0ed59c1d9e149c463e384dead73a1/chrome/browser/vr/skia_surface_provider_factory_cmd_buffer.cc
[modify] https://crrev.com/9152d53ff4f0ed59c1d9e149c463e384dead73a1/chrome/browser/vr/test/gl_test_environment_unittest.cc
[modify] https://crrev.com/9152d53ff4f0ed59c1d9e149c463e384dead73a1/chrome/browser/vr/test/run_all_perftests.cc
[modify] https://crrev.com/9152d53ff4f0ed59c1d9e149c463e384dead73a1/chrome/browser/vr/test/ui_pixel_test.cc
[modify] https://crrev.com/9152d53ff4f0ed59c1d9e149c463e384dead73a1/chrome/browser/vr/test/vr_gl_test_suite.cc
[modify] https://crrev.com/9152d53ff4f0ed59c1d9e149c463e384dead73a1/chrome/browser/vr/text_perftest.cc
[modify] https://crrev.com/9152d53ff4f0ed59c1d9e149c463e384dead73a1/chrome/browser/vr/ui_pixeltest.cc
[modify] https://crrev.com/9152d53ff4f0ed59c1d9e149c463e384dead73a1/testing/buildbot/chromium.win.json
[modify] https://crrev.com/9152d53ff4f0ed59c1d9e149c463e384dead73a1/testing/buildbot/test_suite_exceptions.pyl

Owner: acondor@chromium.org
Status: Fixed (was: Assigned)

Sign in to add a comment