New issue
Advanced search Search tips

Issue 771787 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[PerformanceObserver] Add a layout test for 'script-parse' attribution of long task

Project Member Reported by maxlg@chromium.org, Oct 4 2017

Issue description

The test can trigger the happening of a compilation task and captured by a performance observer observing long-tasks.
 

Comment 1 by maxlg@chromium.org, Oct 4 2017

Cc: tdres...@chromium.org panicker@chromium.org
Owner: maxlg@chromium.org

Comment 2 by maxlg@chromium.org, Oct 10 2017

Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fae0dd9258a19611e66ab8b006ee707e5e106658

commit fae0dd9258a19611e66ab8b006ee707e5e106658
Author: Liquan (Max) Gu <maxlg@chromium.org>
Date: Wed Oct 11 20:37:50 2017

[LongTaskV2] Add layout test and internal API to verify the script-compile
attribution

Add a layout test and internal API to verify the script-compile
attribution in LongTaskAPIV2.

This CL has done the following tasks:
1. Add an internal API to bypass the threshold of script-compile attribution.
2. Add a layout test for the script-compile attribution of LongTaskAPIV2

Bug:  771787 
Change-Id: I6c03423f61e884a71a0c4cd697f194b16a0bc083
Reviewed-on: https://chromium-review.googlesource.com/706514
Commit-Queue: Liquan Gu <maxlg@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508095}
[add] https://crrev.com/fae0dd9258a19611e66ab8b006ee707e5e106658/third_party/WebKit/LayoutTests/http/tests/performance-timing/longtask-v2/longtask-v8compile-expected.txt
[add] https://crrev.com/fae0dd9258a19611e66ab8b006ee707e5e106658/third_party/WebKit/LayoutTests/http/tests/performance-timing/longtask-v2/longtask-v8compile.html
[add] https://crrev.com/fae0dd9258a19611e66ab8b006ee707e5e106658/third_party/WebKit/LayoutTests/http/tests/performance-timing/longtask-v2/resources/makelongtask.js
[add] https://crrev.com/fae0dd9258a19611e66ab8b006ee707e5e106658/third_party/WebKit/LayoutTests/virtual/longtask-v2/http/tests/performance-timing/longtask-v2/longtask-v8compile-expected.txt
[modify] https://crrev.com/fae0dd9258a19611e66ab8b006ee707e5e106658/third_party/WebKit/Source/core/frame/PerformanceMonitor.cpp
[modify] https://crrev.com/fae0dd9258a19611e66ab8b006ee707e5e106658/third_party/WebKit/Source/core/frame/PerformanceMonitor.h
[modify] https://crrev.com/fae0dd9258a19611e66ab8b006ee707e5e106658/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/fae0dd9258a19611e66ab8b006ee707e5e106658/third_party/WebKit/Source/core/testing/Internals.h
[modify] https://crrev.com/fae0dd9258a19611e66ab8b006ee707e5e106658/third_party/WebKit/Source/core/testing/Internals.idl

Comment 4 by maxlg@chromium.org, Oct 11 2017

Status: Fixed (was: Assigned)

Sign in to add a comment