New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 771778 link

Starred by 2 users
Status: Fixed
Owner:
charleszhao@chromium.org
Closed: Nov 2017
Cc:
thakis@chromium.org
█ riesa@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Remove CLD2 from Chrome

Project Member Reported by napper@chromium.org, Oct 4 2017 
From riesa@google.com:

- delete this file: https://cs.chromium.org/chromium/src/third_party/cld/BUILD.gn
- but before that, switch any targets that depend on something in that file to depend directly on the cld3 dependency referenced in that file
- remove the CLD2 sections from language_detection_util.cc 
- search for CLD2 in cs.chromium.org and delete the corresponding references and files

Comment 1 by napper@chromium.org, Oct 4 2017

Owner: charleszhao@chromium.org
Status: Assigned (was: Available)

Comment 2 by napper@chromium.org, Oct 4 2017

Cc: thakis@chromium.org

Comment 3 by charleszhao@chromium.org, Oct 10 2017

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55c4c759ed5edc61b67099704bc9e2b5c6ab0c17

commit 55c4c759ed5edc61b67099704bc9e2b5c6ab0c17
Author: Charles Zhao <charleszhao@chromium.org>
Date: Thu Nov 09 00:07:49 2017

Clean up cld2.

(1) //third_party/cld2 is deleted since it contains all cld2 code.

(2) //third_party/cld is deleted since it contains the flag to switch
between cld2 and cld3.

(3) //chrome/test/data/cld2_component/ is deleted since cld2 is gone.

(4) chrome/browser/ui/webui/ records cld versions; and is now hard 
coded to be cld3; The related dependencies in DEPS and BUILD.gn 
are also deleted.  

(5) components/translate/core/language_dection/ uses cld, which is now
changed to cld3 for the head file and dependencies.
 
(6) components/translate/cotent/render has the decencies to cld2,
which I believe is unnecessary; So simply delete it.

(7) extensions/render/ uses cld, which is now changed to cld3 for the
head file and dependencies.

(8) cld2 related enum and uma histogram are also obsoleted.
 
(9) also changed other related dependencies.

Bug:  771778 
Change-Id: Ice64df4d60087e41a97b152e88690402b501b99e
Reviewed-on: https://chromium-review.googlesource.com/734680
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Charles . <charleszhao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515022}
[modify] https://crrev.com/55c4c759ed5edc61b67099704bc9e2b5c6ab0c17/.gn
[modify] https://crrev.com/55c4c759ed5edc61b67099704bc9e2b5c6ab0c17/DEPS
[modify] https://crrev.com/55c4c759ed5edc61b67099704bc9e2b5c6ab0c17/chrome/BUILD.gn
[modify] https://crrev.com/55c4c759ed5edc61b67099704bc9e2b5c6ab0c17/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/55c4c759ed5edc61b67099704bc9e2b5c6ab0c17/chrome/browser/ui/webui/DEPS
[modify] https://crrev.com/55c4c759ed5edc61b67099704bc9e2b5c6ab0c17/chrome/browser/ui/webui/translate_internals/translate_internals_ui.cc
[delete] https://crrev.com/807910bd4bad7be664519f2c83a7d89b819e2ce2/chrome/test/data/cld2_component/160/_platform_specific/all/cld2_data.bin
[delete] https://crrev.com/807910bd4bad7be664519f2c83a7d89b819e2ce2/chrome/test/data/cld2_component/160/manifest.json
[delete] https://crrev.com/807910bd4bad7be664519f2c83a7d89b819e2ce2/chrome/test/data/cld2_component/README.chromium
[modify] https://crrev.com/55c4c759ed5edc61b67099704bc9e2b5c6ab0c17/components/translate/content/renderer/BUILD.gn
[modify] https://crrev.com/55c4c759ed5edc61b67099704bc9e2b5c6ab0c17/components/translate/content/renderer/DEPS
[modify] https://crrev.com/55c4c759ed5edc61b67099704bc9e2b5c6ab0c17/components/translate/core/language_detection/BUILD.gn
[modify] https://crrev.com/55c4c759ed5edc61b67099704bc9e2b5c6ab0c17/components/translate/core/language_detection/DEPS
[modify] https://crrev.com/55c4c759ed5edc61b67099704bc9e2b5c6ab0c17/components/translate/core/language_detection/language_detection_util.cc
[modify] https://crrev.com/55c4c759ed5edc61b67099704bc9e2b5c6ab0c17/extensions/BUILD.gn
[modify] https://crrev.com/55c4c759ed5edc61b67099704bc9e2b5c6ab0c17/extensions/renderer/BUILD.gn
[modify] https://crrev.com/55c4c759ed5edc61b67099704bc9e2b5c6ab0c17/extensions/renderer/DEPS
[modify] https://crrev.com/55c4c759ed5edc61b67099704bc9e2b5c6ab0c17/extensions/renderer/i18n_custom_bindings.cc
[modify] https://crrev.com/55c4c759ed5edc61b67099704bc9e2b5c6ab0c17/extensions/shell/BUILD.gn
[delete] https://crrev.com/807910bd4bad7be664519f2c83a7d89b819e2ce2/third_party/cld/BUILD.gn
[delete] https://crrev.com/807910bd4bad7be664519f2c83a7d89b819e2ce2/third_party/cld/LICENSE
[delete] https://crrev.com/807910bd4bad7be664519f2c83a7d89b819e2ce2/third_party/cld/OWNERS
[delete] https://crrev.com/807910bd4bad7be664519f2c83a7d89b819e2ce2/third_party/cld/README.chromium
[delete] https://crrev.com/807910bd4bad7be664519f2c83a7d89b819e2ce2/third_party/cld_2/BUILD.gn
[delete] https://crrev.com/807910bd4bad7be664519f2c83a7d89b819e2ce2/third_party/cld_2/LICENSE
[delete] https://crrev.com/807910bd4bad7be664519f2c83a7d89b819e2ce2/third_party/cld_2/OWNERS
[delete] https://crrev.com/807910bd4bad7be664519f2c83a7d89b819e2ce2/third_party/cld_2/README.chromium
[delete] https://crrev.com/807910bd4bad7be664519f2c83a7d89b819e2ce2/third_party/cld_2/crx_gen/manifest.json
[modify] https://crrev.com/55c4c759ed5edc61b67099704bc9e2b5c6ab0c17/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/55c4c759ed5edc61b67099704bc9e2b5c6ab0c17/tools/metrics/histograms/histograms.xml

Comment 5 by charleszhao@chromium.org, Nov 9 2017

Status: Fixed (was: Started)
The cld2 related code and files are deleted.
I think it's safe to close this bug.
►

Sign in to add a comment