New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 771776 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

cros tryjob doesn't support branch-util locally for production.

Project Member Reported by dgarr...@chromium.org, Oct 4 2017

Issue description

The TPMs need to be able to create new branches with commands similar to:

cros tryjob --production --local --yes \
   --branch-name=stabilize-9998.B \
   --version=9998.0.0 \
   branch-util 

That works fine for debug builds, but not production, which is what's needed to actually create the branch.
 
Owner: dgarr...@chromium.org
Status: Started (was: Untriaged)
Cc: bhthompson@chromium.org josa...@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/e7e08fc5357802da8c7e064145a71d7152037912

commit e7e08fc5357802da8c7e064145a71d7152037912
Author: Don Garrett <dgarrett@google.com>
Date: Sat Oct 07 04:31:18 2017

cros_tryjob: Fix local branch-util tryjobs.

The branch_util tryjobs must run locally, since they depend on the
users git permissions, but also must be run without --debug. cros
tryjob didn't allow this. It does now, if --production is set.

Does a little cros tryjob refactoring to move all cbuildbot args into
CbuildbotArgs(), which allows better testing. Update the tests.

Also, tweak cbuildbot to allow --branch-name to be used with a
--branch if the branch is 'master' since we now set that on most
builds by default.

BUG= chromium:771776 
TEST=cros tryjob branch-util  --local --production --yes \
     --branch-name test-foo --version X.Y.Z

Change-Id: I6f952b6691083a27fc9b39b3309cf7197db0e073
Reviewed-on: https://chromium-review.googlesource.com/701618
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/e7e08fc5357802da8c7e064145a71d7152037912/scripts/cbuildbot.py
[modify] https://crrev.com/e7e08fc5357802da8c7e064145a71d7152037912/cli/cros/cros_tryjob_unittest.py
[modify] https://crrev.com/e7e08fc5357802da8c7e064145a71d7152037912/cli/cros/cros_tryjob.py

I believe this is fixed.

The updated command to create a branch should look like:

cros tryjob --production --local --yes \
   --branch-name=stabilize-9998.B \
   --version=9998.0.0 \
   branch-util 



Status: Fixed (was: Started)

Sign in to add a comment