New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 771759 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

safe_json_parser should not use utility_process_mojo_client

Project Member Reported by jcivelli@chromium.org, Oct 4 2017

Issue description

As part of the effort to move process launch to the service manager, SafeJsonParser should use the service manager instead of utility_process_mojo_client.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab99a9ca833754c4c3dcb0d456594fd8a8387588

commit ab99a9ca833754c4c3dcb0d456594fd8a8387588
Author: Jay Civelli <jcivelli@google.com>
Date: Fri Oct 13 17:48:23 2017

Moving safe_json to services/data_decoder.

Servicifying safe_json and moving it to services/data_decoder. The
behavior stays the same, safe_json_parser.h becomes a client library
under services/data_decoder/public/cpp which connects to the new
JsonParserService on all platforms but Android, where it directly calls
to Java to do the sanitizing.

Optimistically reenabling the SafeJsonParserTest.Parse browser test now
that the code path to start the service is different.

Bug:  771759 
Change-Id: I7de7de0aebf68ecad641302fe505c7d3dad1cd38
Reviewed-on: https://chromium-review.googlesource.com/699563
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508750}
[modify] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/chrome/android/BUILD.gn
[modify] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/chrome/android/java/DEPS
[modify] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/chrome/browser/BUILD.gn
[modify] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/chrome/browser/android/digital_asset_links/digital_asset_links_handler.cc
[modify] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/chrome/browser/android/digital_asset_links/digital_asset_links_handler_unittest.cc
[modify] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/chrome/browser/browser_process_impl.cc
[modify] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/chrome/browser/browser_process_impl_unittest.cc
[modify] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/chrome/browser/chromeos/arc/policy/arc_policy_bridge.cc
[modify] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/chrome/browser/chromeos/arc/policy/arc_policy_bridge_unittest.cc
[modify] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/chrome/browser/component_updater/sth_set_component_installer_unittest.cc
[modify] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/chrome/browser/component_updater/supervised_user_whitelist_installer.cc
[modify] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/chrome/browser/component_updater/supervised_user_whitelist_installer_unittest.cc
[modify] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/chrome/browser/extensions/DEPS
[modify] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/chrome/browser/extensions/api/management/chrome_management_api_delegate.cc
[modify] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/chrome/browser/extensions/webstore_data_fetcher.cc
[modify] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/chrome/browser/extensions/webstore_install_helper.cc
[modify] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc
[modify] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/chrome/browser/ntp_snippets/contextual_content_suggestions_service_factory.cc
[modify] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/chrome/browser/ntp_tiles/chrome_popular_sites_factory.cc
[modify] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/chrome/browser/plugins/plugins_resource_service.cc
[modify] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/chrome/browser/safe_json_parser_browsertest.cc
[modify] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/chrome/browser/search/one_google_bar/one_google_bar_fetcher_impl.cc
[modify] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/chrome/browser/search/one_google_bar/one_google_bar_fetcher_impl_unittest.cc
[modify] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/chrome/browser/supervised_user/supervised_user_whitelist_service_unittest.cc
[modify] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/chrome/browser/ui/app_list/search/common/json_response_fetcher.cc
[modify] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/chrome/test/BUILD.gn
[modify] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/chrome/utility/BUILD.gn
[modify] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/chrome/utility/DEPS
[modify] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/chrome/utility/chrome_content_utility_client.cc
[modify] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/components/BUILD.gn
[modify] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/components/certificate_transparency/BUILD.gn
[modify] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/components/certificate_transparency/DEPS
[delete] https://crrev.com/8f48c21352588b61d857897d0d1c7d695edcbcdf/components/safe_json/BUILD.gn
[delete] https://crrev.com/8f48c21352588b61d857897d0d1c7d695edcbcdf/components/safe_json/DEPS
[delete] https://crrev.com/8f48c21352588b61d857897d0d1c7d695edcbcdf/components/safe_json/OWNERS
[delete] https://crrev.com/8f48c21352588b61d857897d0d1c7d695edcbcdf/components/safe_json/android/BUILD.gn
[delete] https://crrev.com/8f48c21352588b61d857897d0d1c7d695edcbcdf/components/safe_json/public/interfaces/BUILD.gn
[delete] https://crrev.com/8f48c21352588b61d857897d0d1c7d695edcbcdf/components/safe_json/public/interfaces/OWNERS
[delete] https://crrev.com/8f48c21352588b61d857897d0d1c7d695edcbcdf/components/safe_json/safe_json_parser.cc
[delete] https://crrev.com/8f48c21352588b61d857897d0d1c7d695edcbcdf/components/safe_json/utility/BUILD.gn
[delete] https://crrev.com/8f48c21352588b61d857897d0d1c7d695edcbcdf/components/safe_json/utility/safe_json_parser_mojo_impl.cc
[delete] https://crrev.com/8f48c21352588b61d857897d0d1c7d695edcbcdf/components/safe_json/utility/safe_json_parser_mojo_impl.h
[modify] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/components/test/BUILD.gn
[modify] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/services/BUILD.gn
[modify] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/services/data_decoder/BUILD.gn
[modify] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/services/data_decoder/DEPS
[modify] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/services/data_decoder/OWNERS
[modify] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/services/data_decoder/data_decoder_service.cc
[add] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/services/data_decoder/json_parser_impl.cc
[add] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/services/data_decoder/json_parser_impl.h
[modify] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/services/data_decoder/manifest.json
[modify] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/services/data_decoder/public/cpp/BUILD.gn
[add] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/services/data_decoder/public/cpp/android/BUILD.gn
[rename] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/services/data_decoder/public/cpp/android/java/src/org/chromium/services/data_decoder/JsonSanitizer.java
[rename] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/services/data_decoder/public/cpp/json_sanitizer.cc
[rename] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/services/data_decoder/public/cpp/json_sanitizer.h
[rename] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/services/data_decoder/public/cpp/json_sanitizer_android.cc
[rename] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/services/data_decoder/public/cpp/json_sanitizer_unittest.cc
[add] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/services/data_decoder/public/cpp/safe_json_parser.cc
[rename] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/services/data_decoder/public/cpp/safe_json_parser.h
[rename] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/services/data_decoder/public/cpp/safe_json_parser_android.cc
[rename] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/services/data_decoder/public/cpp/safe_json_parser_android.h
[rename] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/services/data_decoder/public/cpp/safe_json_parser_impl.cc
[rename] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/services/data_decoder/public/cpp/safe_json_parser_impl.h
[rename] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/services/data_decoder/public/cpp/testing_json_parser.cc
[rename] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/services/data_decoder/public/cpp/testing_json_parser.h
[rename] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/services/data_decoder/public/cpp/testing_json_parser_unittest.cc
[modify] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/services/data_decoder/public/interfaces/BUILD.gn
[rename] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/services/data_decoder/public/interfaces/json_parser.mojom
[modify] https://crrev.com/ab99a9ca833754c4c3dcb0d456594fd8a8387588/tools/android/eclipse/.classpath

Status: Fixed (was: Untriaged)

Sign in to add a comment