https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyvAELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKFAWNocm9taXVtLndpbi9XaW43IFRlc3RzIChkYmcpKDEpLzYzNjA5L2Jyb3dzZXJfdGVzdHMvVUdWeWJXbHpjMmx2YmxKbGNYVmxjM1JOWVc1aFoyVnlRbkp2ZDNObGNsUmxjM1F1UW1GamEyZHliM1Z1WkZSaFlrNWhkbWxuWVhScGIyND0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA It seems analyses are still susceptible to timeouts. In this case, Flake analyzer tried 116 iterations in 1 hour, which lead to a timeout (possibly repeated) causing the overall analysis to halt despite retry. Need to introduce a cap (even consider a dynamic one) for maximum number of iterations to try regardless of how fast Findit thinks it can complete the task in to avoid further timeouts.
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/5471845947411e31df9be6c53c921e817318e4e6 commit 5471845947411e31df9be6c53c921e817318e4e6 Author: Brandon Wylie <wylieb@chromium.org> Date: Fri Oct 06 19:37:49 2017 [Findit] Flake Analyzer - Add cap to number of iterations per task This limits the number of iterations per task. This will stop us running thousands of iterations if the iterations take a very short amount of time. Bug:771749 Change-Id: I7da6916cabcc6ecce1faa114259ec0f282850154 Reviewed-on: https://chromium-review.googlesource.com/705394 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by: Jeffrey Li <lijeffrey@chromium.org> [modify] https://crrev.com/5471845947411e31df9be6c53c921e817318e4e6/appengine/findit/waterfall/test/waterfall_config_test.py [modify] https://crrev.com/5471845947411e31df9be6c53c921e817318e4e6/appengine/findit/handlers/test/config_test.py [modify] https://crrev.com/5471845947411e31df9be6c53c921e817318e4e6/appengine/findit/handlers/config.py [modify] https://crrev.com/5471845947411e31df9be6c53c921e817318e4e6/appengine/findit/waterfall/flake/test/determine_true_pass_rate_pipeline_test.py [modify] https://crrev.com/5471845947411e31df9be6c53c921e817318e4e6/appengine/findit/waterfall/test/wf_testcase.py [modify] https://crrev.com/5471845947411e31df9be6c53c921e817318e4e6/appengine/findit/waterfall/flake/flake_constants.py [modify] https://crrev.com/5471845947411e31df9be6c53c921e817318e4e6/appengine/findit/model/wf_config.py [modify] https://crrev.com/5471845947411e31df9be6c53c921e817318e4e6/appengine/findit/waterfall/flake/determine_true_pass_rate_pipeline.py
Comment 1 by st...@chromium.org
, Oct 5 2017Owner: wylieb@chromium.org
Status: Assigned (was: Available)