WPT test execution-timing/039.html appears to fail sometimes |
||||||
Issue descriptionContext: The tests in old-tests/submission/Opera/script_scheduling/ were recently moved, so now we're running them. One of these tests appears to be failing sometimes on WebKit Win7 (dbg). Example failed build: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/11385 Results: https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Win7__dbg_/11385/layout-test-results/results.html I'm not sure whether it's related, but this test uses Math.random and I'm not sure why: https://github.com/w3c/web-platform-tests/blob/a6d20c74b6047977d330b563f5326ecd7b4e7db9/html/semantics/scripting-1/the-script-element/execution-timing/039.html
,
Oct 5 2017
This bug doesn't need to be triaged by TE. Note, there's a CL to add a flaky expectation: https://chromium-review.googlesource.com/c/chromium/src/+/700806 Although now it's unclear whether this is actually an issue... maybe adding that expectation is unnecessary? Still, it failed at least once...
,
Oct 5 2017
There's nothing that complex in the test; the Math.random call is just there to avoid any caching of the frames (though they shouldn't be cached *anyway*). Seemed to have had only three of the log calls run, probably having not run the scripts in either iframe? Odd.
,
Oct 6 2017
It is odd... A couple more failing runs more recently: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/11409 https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/11411
,
Oct 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/077661a48a5e9d3bf7126947603efd45ffc54e34 commit 077661a48a5e9d3bf7126947603efd45ffc54e34 Author: Quinten Yearsley <qyearsley@chromium.org> Date: Fri Oct 06 18:33:37 2017 Add flaky expectation for wpt test execution-timing/039.html Bug: 771729 Change-Id: I06ffd0691927d2e38a9847259e4690f90517cb4a Reviewed-on: https://chromium-review.googlesource.com/700806 Reviewed-by: Robert Ma <robertma@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#507123} [modify] https://crrev.com/077661a48a5e9d3bf7126947603efd45ffc54e34/third_party/WebKit/LayoutTests/TestExpectations
,
Oct 10 2017
Probably my CL was the culprit https://chromium-review.googlesource.com/c/chromium/src/+/697485, which was already reverted. What I don't understand is that flakiness dashboard still says that this is failing on Windows bots. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=execution-timing%2F039.html
,
Oct 10 2017
+altimin, +rockot
,
Oct 10 2017
,
Oct 11 2017
Confirmed this can be reproduced on my Windows machine.
,
Oct 11 2017
It looks like that the test expected the script in an iframe is executed within 200[ms] after the test starts. As my CL introduced V8 scheduler, the timings of script executions were affected. However, this is not regression. I think I can fix this by making the test more deterministic.
,
Oct 12 2017
,
Oct 12 2017
,
Oct 17 2017
039.html was fixed to be deterministic by https://chromium-review.googlesource.com/c/chromium/src/+/718241
,
Oct 17 2017
,
Nov 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/be87f9d72a446ff1816cba3f7be16d771e68d5bc commit be87f9d72a446ff1816cba3f7be16d771e68d5bc Author: Quinten Yearsley <qyearsley@chromium.org> Date: Wed Nov 01 15:25:46 2017 Clean up flaky expectations with update-flaky-expectations Bug: 457273 , 605525 ,626703, 667560 ,708499, 731509 , 731535 , 732103 , 736548 , 746904 , 747163 , 752845 , 771729 Change-Id: Ibf4be93e26a364e91d44375379aa8b5a7b59b94f Reviewed-on: https://chromium-review.googlesource.com/736047 Reviewed-by: David Bokan <bokan@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#513134} [modify] https://crrev.com/be87f9d72a446ff1816cba3f7be16d771e68d5bc/third_party/WebKit/LayoutTests/TestExpectations |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by jmukthavaram@chromium.org
, Oct 5 2017