New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 771703 link

Starred by 9 users
Status: Fixed
Owner:
reillyg@chromium.org
Closed: Apr 2018
Cc:
reillyg@chromium.org
█ raymes@chromium.org
pbomm...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Feature

Blocking:
issue 813280



Sign in to add a comment

WebUSB disabling is not supported through policy templates

Reported by honz...@gmail.com, Oct 4 2017 
UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.100 Safari/537.36

Steps to reproduce the problem:
1. Download & deploy Chrome in corporate enviroment;
2. Download & install Windows policy templates (admx);
3. Try to set up Chrome as per corporate policies which require disabling browser access to external devices;
4. realize that the new "WebUSB" feature can only be disabled by accessing "chrome://flags/" and disabling it manually on every single device;

What is the expected behavior?
Make this setting available through policy templates.

What went wrong?
This feature has been enabled by Google without making it configurable through policy templates.

Did this work before? No 

Chrome version: 61.0.3163.100  Channel: stable
OS Version: 10.0
Flash Version:

Comment 1 by pbomm...@chromium.org, Oct 4 2017

Cc: scheib@chromium.org pbomm...@chromium.org
Components: Blink>USB
Labels: -Type-Bug Type-Feature

Comment 2 by scheib@chromium.org, Oct 4 2017

Labels: -Pri-2 Pri-3
Status: Available (was: Unconfirmed)

Comment 3 by reillyg@chromium.org, Oct 4 2017

Cc: raymes@chromium.org
Labels: OS-Android OS-Chrome OS-Linux OS-Mac
This was prototyped in https://codereview.chromium.org/1427433017/ but we decided to hold off on implementing it.

Comment 4 by raymes@chromium.org, Oct 4 2017 

I'm ok to resurrect this if needed.

Comment 5 by pmarko@chromium.org, Oct 9 2017

Owner: blumberg@chromium.org
Over to Matt for triage.

Comment 6 by scheib@chromium.org, Jan 9 2018

Cc: -scheib@chromium.org

Comment 7 by term...@gmail.com, Mar 1 2018 

https://www.wired.com/story/chrome-yubikey-phishing-webusb/

I filed a dupe at #818029, I did not see this issue from my initial search query.

Comment 8 by term...@gmail.com, Mar 1 2018 

Does "Enable new USB backend" allow disabling WebUSB? I can't find a setting in flags that says WebUSB

Comment 9 by reillyg@chromium.org, Mar 2 2018 

 Issue 818029  has been merged into this issue.

Comment 10 by reillyg@chromium.org, Mar 2 2018 

"Enable new USB backend" enables an experimental new USB backend on Windows. It will break communication with some USB devices but isn't a reliable way to disable the API.

Comment 11 by palmer@chromium.org, Mar 3 2018

Cc: reillyg@chromium.org
Components: Security
Labels: -Arch-x86_64
Status: Assigned (was: Available)
The bug reporters also mention an enterprise policy setting on their blog:

https://www.x41-dsec.de/news/security/2018/03/01/webusb-u2f/

I'd bump up the priority for this, but I leave that to you feature owners.

(Does this really affect Android?)

Comment 12 by reillyg@chromium.org, Mar 27 2018

Owner: reillyg@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 13 by bugdroid1@chromium.org, Mar 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44f107c02059e50bbe240e55f4390418cb778627

commit 44f107c02059e50bbe240e55f4390418cb778627
Author: Reilly Grant <reillyg@chromium.org>
Date: Wed Mar 28 00:33:49 2018

Add a "guard" content settings type for chooser permissions

A guard content setting should default to ask, but can be set to block
by the user or group policy in order to disable a feature that normally
grants permissions by prompting the user with a chooser. The USB chooser
context is updated to use such a guard.

Follow-up patches will include UI for setting the USB guard permission
on desktop and Android as well as by group policy. The chooser UI will
also be updated to automatically cancel a request if the permission is
blocked.

This change is based on: https://codereview.chromium.org/1427433017/

Bug:  771703 
Change-Id: I8888e64342268330243d7aa41176e9761ae8e7a6
Reviewed-on: https://chromium-review.googlesource.com/959641
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546335}
[modify] https://crrev.com/44f107c02059e50bbe240e55f4390418cb778627/chrome/browser/permissions/chooser_context_base.cc
[modify] https://crrev.com/44f107c02059e50bbe240e55f4390418cb778627/chrome/browser/permissions/chooser_context_base.h
[modify] https://crrev.com/44f107c02059e50bbe240e55f4390418cb778627/chrome/browser/permissions/chooser_context_base_unittest.cc
[modify] https://crrev.com/44f107c02059e50bbe240e55f4390418cb778627/chrome/browser/ui/webui/site_settings_helper.cc
[modify] https://crrev.com/44f107c02059e50bbe240e55f4390418cb778627/chrome/browser/usb/usb_chooser_context.cc
[modify] https://crrev.com/44f107c02059e50bbe240e55f4390418cb778627/chrome/browser/usb/usb_chooser_context_unittest.cc
[modify] https://crrev.com/44f107c02059e50bbe240e55f4390418cb778627/components/content_settings/core/browser/content_settings_registry.cc
[modify] https://crrev.com/44f107c02059e50bbe240e55f4390418cb778627/components/content_settings/core/common/content_settings.cc
[modify] https://crrev.com/44f107c02059e50bbe240e55f4390418cb778627/components/content_settings/core/common/content_settings_types.h
Project Member

Comment 14 by bugdroid1@chromium.org, Mar 31 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c8057d4229e010e97efc03e6e20efff3ee95690

commit 9c8057d4229e010e97efc03e6e20efff3ee95690
Author: Reilly Grant <reillyg@chromium.org>
Date: Sat Mar 31 00:40:57 2018

Block the WebUSB chooser when the guard permission is 'block'

This change adds logic to the WebUSB device chooser (on desktop) so that
when the WebUSB guard permission is set to 'block' the chooser will be
automatically dismissed as if the user had not selected any devices.

This matches the behavior of the Web Bluetooth chooser and its guard
permission.

To test this change the WebUsbChooserService class has been refactored
so that its shared logic can be reused by tests. A follow-up patch will
make WebUsbChooserServiceAndroid also inherit from this class.

Bug:  771703 
Change-Id: I3f2cc6e96a9ebf039bc15d396d16eb4a0766007e
Reviewed-on: https://chromium-review.googlesource.com/987327
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Jun Cai <juncai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547338}
[modify] https://crrev.com/9c8057d4229e010e97efc03e6e20efff3ee95690/chrome/browser/BUILD.gn
[modify] https://crrev.com/9c8057d4229e010e97efc03e6e20efff3ee95690/chrome/browser/usb/usb_browsertest.cc
[modify] https://crrev.com/9c8057d4229e010e97efc03e6e20efff3ee95690/chrome/browser/usb/usb_tab_helper.cc
[modify] https://crrev.com/9c8057d4229e010e97efc03e6e20efff3ee95690/chrome/browser/usb/web_usb_chooser_service.cc
[modify] https://crrev.com/9c8057d4229e010e97efc03e6e20efff3ee95690/chrome/browser/usb/web_usb_chooser_service.h
[add] https://crrev.com/9c8057d4229e010e97efc03e6e20efff3ee95690/chrome/browser/usb/web_usb_chooser_service_desktop.cc
[add] https://crrev.com/9c8057d4229e010e97efc03e6e20efff3ee95690/chrome/browser/usb/web_usb_chooser_service_desktop.h
Project Member

Comment 15 by bugdroid1@chromium.org, Apr 3 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f18e1f529f09ee9f36a64c2bebb38854d24436f

commit 6f18e1f529f09ee9f36a64c2bebb38854d24436f
Author: Reilly Grant <reillyg@chromium.org>
Date: Tue Apr 03 02:03:22 2018

Add Group Policy flag to control WebUSB guard permission

This Group Policy flag, "DefaultWebUsbGuardSetting" can be used to
control the default value of the WebUSB guard permission.

Bug:  771703 
Change-Id: Ic93b4b1760e8891a75c5f612c97b9275d40422c0
Reviewed-on: https://chromium-review.googlesource.com/982898
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547601}
[modify] https://crrev.com/6f18e1f529f09ee9f36a64c2bebb38854d24436f/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/6f18e1f529f09ee9f36a64c2bebb38854d24436f/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/6f18e1f529f09ee9f36a64c2bebb38854d24436f/chrome/test/data/policy/policy_test_cases.json
[modify] https://crrev.com/6f18e1f529f09ee9f36a64c2bebb38854d24436f/components/content_settings/core/browser/content_settings_default_provider.cc
[modify] https://crrev.com/6f18e1f529f09ee9f36a64c2bebb38854d24436f/components/content_settings/core/browser/content_settings_policy_provider.cc
[modify] https://crrev.com/6f18e1f529f09ee9f36a64c2bebb38854d24436f/components/content_settings/core/common/pref_names.cc
[modify] https://crrev.com/6f18e1f529f09ee9f36a64c2bebb38854d24436f/components/content_settings/core/common/pref_names.h
[modify] https://crrev.com/6f18e1f529f09ee9f36a64c2bebb38854d24436f/components/policy/resources/policy_templates.json
[modify] https://crrev.com/6f18e1f529f09ee9f36a64c2bebb38854d24436f/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/6f18e1f529f09ee9f36a64c2bebb38854d24436f/tools/metrics/histograms/histograms.xml
Project Member

Comment 16 by bugdroid1@chromium.org, Apr 5 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/409406c51d5469302403a0dc73c45660d00acf56

commit 409406c51d5469302403a0dc73c45660d00acf56
Author: Reilly Grant <reillyg@chromium.org>
Date: Thu Apr 05 18:03:05 2018

Use UsbChooserController for Android USB chooser dialog

This change removes the Android-specific implementation of USB device
enumeration for the WebUSB device chooser dialog and instead reuses the
desktop implementation.

This removes duplicate code and means the Android chooser now also
respects the status of the WebUSB guard permission.

Bug:  771703 
Change-Id: I38f0765ced5966b8866fff086a12e4625282fe1c
Reviewed-on: https://chromium-review.googlesource.com/990591
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Jun Cai <juncai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548482}
[modify] https://crrev.com/409406c51d5469302403a0dc73c45660d00acf56/chrome/app/generated_resources.grd
[modify] https://crrev.com/409406c51d5469302403a0dc73c45660d00acf56/chrome/browser/BUILD.gn
[modify] https://crrev.com/409406c51d5469302403a0dc73c45660d00acf56/chrome/browser/android/usb/web_usb_chooser_service_android.cc
[modify] https://crrev.com/409406c51d5469302403a0dc73c45660d00acf56/chrome/browser/android/usb/web_usb_chooser_service_android.h
[modify] https://crrev.com/409406c51d5469302403a0dc73c45660d00acf56/chrome/browser/chooser_controller/chooser_controller.cc
[modify] https://crrev.com/409406c51d5469302403a0dc73c45660d00acf56/chrome/browser/ui/android/usb_chooser_dialog_android.cc
[modify] https://crrev.com/409406c51d5469302403a0dc73c45660d00acf56/chrome/browser/ui/android/usb_chooser_dialog_android.h
Project Member

Comment 17 by bugdroid1@chromium.org, Apr 6 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a69ab67be387bb65abbc1aaba9d5a224070f132e

commit a69ab67be387bb65abbc1aaba9d5a224070f132e
Author: Reilly Grant <reillyg@chromium.org>
Date: Fri Apr 06 18:26:07 2018

Implement desktop UI for the WebUSB guard permission

This patch provides UI controls for the new WebUSB guard permission in
the page info popup and on the site settings pages.

Screenshots of the new UI are included in the design doc:
https://goo.gl/uMPMZZ

Bug:  771703 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4c9dc2cc59a589e558ceb346982d493ac66dc674
Reviewed-on: https://chromium-review.googlesource.com/982595
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548866}
[modify] https://crrev.com/a69ab67be387bb65abbc1aaba9d5a224070f132e/chrome/app/settings_strings.grdp
[add] https://crrev.com/a69ab67be387bb65abbc1aaba9d5a224070f132e/chrome/app/settings_strings_grdp/IDS_SETTINGS_SITE_SETTINGS_USB_DEVICES.png.sha1
[add] https://crrev.com/a69ab67be387bb65abbc1aaba9d5a224070f132e/chrome/app/settings_strings_grdp/IDS_SETTINGS_SITE_SETTINGS_USB_DEVICES_ASK.png.sha1
[add] https://crrev.com/a69ab67be387bb65abbc1aaba9d5a224070f132e/chrome/app/settings_strings_grdp/IDS_SETTINGS_SITE_SETTINGS_USB_DEVICES_ASK_RECOMMENDED.png.sha1
[add] https://crrev.com/a69ab67be387bb65abbc1aaba9d5a224070f132e/chrome/app/settings_strings_grdp/IDS_SETTINGS_SITE_SETTINGS_USB_DEVICES_BLOCK.png.sha1
[modify] https://crrev.com/a69ab67be387bb65abbc1aaba9d5a224070f132e/chrome/browser/content_settings/web_site_settings_uma_util.cc
[modify] https://crrev.com/a69ab67be387bb65abbc1aaba9d5a224070f132e/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/a69ab67be387bb65abbc1aaba9d5a224070f132e/chrome/browser/resources/settings/site_settings/all_sites.js
[modify] https://crrev.com/a69ab67be387bb65abbc1aaba9d5a224070f132e/chrome/browser/resources/settings/site_settings/category_default_setting.js
[modify] https://crrev.com/a69ab67be387bb65abbc1aaba9d5a224070f132e/chrome/browser/resources/settings/site_settings/constants.js
[modify] https://crrev.com/a69ab67be387bb65abbc1aaba9d5a224070f132e/chrome/browser/resources/settings/site_settings/site_details.html
[modify] https://crrev.com/a69ab67be387bb65abbc1aaba9d5a224070f132e/chrome/browser/resources/settings/site_settings/site_details_permission.html
[modify] https://crrev.com/a69ab67be387bb65abbc1aaba9d5a224070f132e/chrome/browser/resources/settings/site_settings/site_details_permission.js
[modify] https://crrev.com/a69ab67be387bb65abbc1aaba9d5a224070f132e/chrome/browser/resources/settings/site_settings_page/site_settings_page.html
[modify] https://crrev.com/a69ab67be387bb65abbc1aaba9d5a224070f132e/chrome/browser/resources/settings/site_settings_page/site_settings_page.js
[modify] https://crrev.com/a69ab67be387bb65abbc1aaba9d5a224070f132e/chrome/browser/ui/page_info/page_info.cc
[modify] https://crrev.com/a69ab67be387bb65abbc1aaba9d5a224070f132e/chrome/browser/ui/page_info/page_info_ui.cc
[modify] https://crrev.com/a69ab67be387bb65abbc1aaba9d5a224070f132e/chrome/browser/ui/page_info/permission_menu_model.cc
[modify] https://crrev.com/a69ab67be387bb65abbc1aaba9d5a224070f132e/chrome/browser/ui/page_info/permission_menu_model.h
[modify] https://crrev.com/a69ab67be387bb65abbc1aaba9d5a224070f132e/chrome/browser/ui/page_info/permission_menu_model_unittest.cc
[modify] https://crrev.com/a69ab67be387bb65abbc1aaba9d5a224070f132e/chrome/browser/ui/views/page_info/page_info_bubble_view_unittest.cc
[modify] https://crrev.com/a69ab67be387bb65abbc1aaba9d5a224070f132e/chrome/browser/ui/views/page_info/permission_selector_row.cc
[modify] https://crrev.com/a69ab67be387bb65abbc1aaba9d5a224070f132e/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/a69ab67be387bb65abbc1aaba9d5a224070f132e/chrome/browser/ui/webui/site_settings_helper.cc
[modify] https://crrev.com/a69ab67be387bb65abbc1aaba9d5a224070f132e/chrome/test/data/webui/settings/site_details_tests.js
[modify] https://crrev.com/a69ab67be387bb65abbc1aaba9d5a224070f132e/chrome/test/data/webui/settings/test_util.js
[modify] https://crrev.com/a69ab67be387bb65abbc1aaba9d5a224070f132e/components/OWNERS
[modify] https://crrev.com/a69ab67be387bb65abbc1aaba9d5a224070f132e/components/page_info_strings.grdp
[add] https://crrev.com/a69ab67be387bb65abbc1aaba9d5a224070f132e/components/page_info_strings_grdp/IDS_PAGE_INFO_MENU_ITEM_ASK.png.sha1
[add] https://crrev.com/a69ab67be387bb65abbc1aaba9d5a224070f132e/components/page_info_strings_grdp/IDS_PAGE_INFO_TYPE_USB.png.sha1
[modify] https://crrev.com/a69ab67be387bb65abbc1aaba9d5a224070f132e/tools/metrics/histograms/histograms.xml
Project Member

Comment 18 by bugdroid1@chromium.org, Apr 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b17421e33624954f62e89ae337d239ddddde379d

commit b17421e33624954f62e89ae337d239ddddde379d
Author: Reilly Grant <reillyg@chromium.org>
Date: Fri Apr 27 19:55:48 2018

Add global WebUSB permission toggle to Android

This change adds a global toggle for the WebUSB "guard" permission to
the site settings preferences on Android. Toggling this setting to
"block" will disregard existing USB device permissions and prevent any
site from requesting access to a USB device by displaying the device
chooser dialog.

To simplify the addition of this global toggle UsbChooserPreferences
has been merged into SingleCategoryPreferences and the entire USB
device permission framework has been refactored to manage the same kind
of opaque "objects" as is done in the desktop UI and underlying
storage infrastructure.

Screenshots of this new UI are included in the design doc:
https://goo.gl/uMPMZZ

Bug:  771703 
Change-Id: I6ab766ddd1e00e8663d3b6658d872ef8ad8e95ea
Reviewed-on: https://chromium-review.googlesource.com/1006157
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554468}
[modify] https://crrev.com/b17421e33624954f62e89ae337d239ddddde379d/build/android/lint/suppressions.xml
[rename] https://crrev.com/b17421e33624954f62e89ae337d239ddddde379d/chrome/android/java/res/layout/object_permission.xml
[rename] https://crrev.com/b17421e33624954f62e89ae337d239ddddde379d/chrome/android/java/res/xml/chosen_object_preferences.xml
[modify] https://crrev.com/b17421e33624954f62e89ae337d239ddddde379d/chrome/android/java/res/xml/single_website_preferences.xml
[modify] https://crrev.com/b17421e33624954f62e89ae337d239ddddde379d/chrome/android/java/res/xml/site_settings_preferences.xml
[delete] https://crrev.com/bfad9ffe79b1b4f01d39a89ae2d8cb096c70d8a4/chrome/android/java/res/xml/usb_chooser_preferences.xml
[modify] https://crrev.com/b17421e33624954f62e89ae337d239ddddde379d/chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java
[add] https://crrev.com/b17421e33624954f62e89ae337d239ddddde379d/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ChosenObjectInfo.java
[rename] https://crrev.com/b17421e33624954f62e89ae337d239ddddde379d/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ChosenObjectPreferences.java
[modify] https://crrev.com/b17421e33624954f62e89ae337d239ddddde379d/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ContentSettingsResources.java
[modify] https://crrev.com/b17421e33624954f62e89ae337d239ddddde379d/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleCategoryPreferences.java
[modify] https://crrev.com/b17421e33624954f62e89ae337d239ddddde379d/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java
[modify] https://crrev.com/b17421e33624954f62e89ae337d239ddddde379d/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SiteSettingsCategory.java
[modify] https://crrev.com/b17421e33624954f62e89ae337d239ddddde379d/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreferences.java
[delete] https://crrev.com/bfad9ffe79b1b4f01d39a89ae2d8cb096c70d8a4/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/UsbChooserPreferences.java
[delete] https://crrev.com/bfad9ffe79b1b4f01d39a89ae2d8cb096c70d8a4/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/UsbInfo.java
[modify] https://crrev.com/b17421e33624954f62e89ae337d239ddddde379d/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/Website.java
[modify] https://crrev.com/b17421e33624954f62e89ae337d239ddddde379d/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePermissionsFetcher.java
[modify] https://crrev.com/b17421e33624954f62e89ae337d239ddddde379d/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePreferenceBridge.java
[modify] https://crrev.com/b17421e33624954f62e89ae337d239ddddde379d/chrome/android/java/strings/android_chrome_strings.grd
[add] https://crrev.com/b17421e33624954f62e89ae337d239ddddde379d/chrome/android/java/strings/android_chrome_strings_grd/IDS_WEBSITE_SETTINGS_CATEGORY_USB_ASK.png.sha1
[add] https://crrev.com/b17421e33624954f62e89ae337d239ddddde379d/chrome/android/java/strings/android_chrome_strings_grd/IDS_WEBSITE_SETTINGS_CATEGORY_USB_BLOCKED.png.sha1
[modify] https://crrev.com/b17421e33624954f62e89ae337d239ddddde379d/chrome/android/java_sources.gni
[modify] https://crrev.com/b17421e33624954f62e89ae337d239ddddde379d/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreferencesTest.java
[modify] https://crrev.com/b17421e33624954f62e89ae337d239ddddde379d/chrome/browser/android/preferences/pref_service_bridge.cc
[modify] https://crrev.com/b17421e33624954f62e89ae337d239ddddde379d/chrome/browser/android/preferences/website_preference_bridge.cc
[modify] https://crrev.com/b17421e33624954f62e89ae337d239ddddde379d/chrome/browser/permissions/chooser_context_base.h
[modify] https://crrev.com/b17421e33624954f62e89ae337d239ddddde379d/chrome/browser/permissions/chooser_context_base_unittest.cc
[modify] https://crrev.com/b17421e33624954f62e89ae337d239ddddde379d/chrome/browser/ui/webui/site_settings_helper.cc
[modify] https://crrev.com/b17421e33624954f62e89ae337d239ddddde379d/chrome/browser/ui/webui/site_settings_helper.h
[modify] https://crrev.com/b17421e33624954f62e89ae337d239ddddde379d/chrome/browser/usb/usb_chooser_context.cc
[modify] https://crrev.com/b17421e33624954f62e89ae337d239ddddde379d/chrome/browser/usb/usb_chooser_context.h
Project Member

Comment 19 by bugdroid1@chromium.org, Apr 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0edac10a53b5ea12729da99238476c1798e0abff

commit 0edac10a53b5ea12729da99238476c1798e0abff
Author: Reilly Grant <reillyg@chromium.org>
Date: Fri Apr 27 20:50:33 2018

Add policy options to allow or block WebUSB on specific origins

This patch follows up on r547601 by adding the WebUsbAskForUrls and
WebUsbBlockedForUrls policy settings which allow an administrator to
either override a DefaultWebUsbGuardSetting of 'block' by allowing a
particular set of URLs or override a setting of 'ask' by blocking a
particular set of URLs.

Bug:  771703 
Change-Id: If562fc031eedaff7b0691810d8d1383ffbd5f824
Reviewed-on: https://chromium-review.googlesource.com/1026159
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554502}
[modify] https://crrev.com/0edac10a53b5ea12729da99238476c1798e0abff/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/0edac10a53b5ea12729da99238476c1798e0abff/chrome/test/data/policy/policy_test_cases.json
[modify] https://crrev.com/0edac10a53b5ea12729da99238476c1798e0abff/components/content_settings/core/browser/content_settings_policy_provider.cc
[modify] https://crrev.com/0edac10a53b5ea12729da99238476c1798e0abff/components/content_settings/core/common/pref_names.cc
[modify] https://crrev.com/0edac10a53b5ea12729da99238476c1798e0abff/components/content_settings/core/common/pref_names.h
[modify] https://crrev.com/0edac10a53b5ea12729da99238476c1798e0abff/components/policy/resources/policy_templates.json
[modify] https://crrev.com/0edac10a53b5ea12729da99238476c1798e0abff/tools/metrics/histograms/enums.xml

Comment 20 by reillyg@chromium.org, Apr 27 2018

Status: Fixed (was: Started)

Comment 21 by reillyg@chromium.org, Apr 27 2018

Blocking: 813280

Comment 22 by ibezmenov@chromium.org, May 16 2018

Labels: cros-verified
Verified on Chrome OS using YAPS (see attached screenshot).

Chrome OS: 10684.0.0
Chrome: 68.0.3432.0
Device: Robo360
Screenshot 2018-05-16 at 3.53.01 PM.png
98.3 KB View Download

Comment 23 by term...@gmail.com, May 18 2018 

Has this been fixed for Windows 7 yet. In the policy list I see DefaultWebUsbGuardSetting.

https://www.chromium.org/administrators/policy-list-3#DefaultWebUsbGuardSetting

Is that the key that addresses this issue?

Comment 24 by reillyg@chromium.org, May 18 2018 

Yes.
►

Sign in to add a comment