New issue
Advanced search Search tips

Issue 771683 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Dec 18
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Task



Sign in to add a comment

Always use android.support.annotation.Nullable

Project Member Reported by nyquist@chromium.org, Oct 4 2017

Issue description

OS: Android

What steps will reproduce the problem?
(1) Add @Nullable

What is the expected result?
@Nullable is added automatically.

What happens instead?
The developer is confused as to which annotation to import, maybe android.support.annotation.Nullable or javax.annotation.Nullable, or even might be confused with android.annotation.Nullable. The developer then adds a random choice.

What should we do?
Ensure we always use android.support.annotation.Nullable since it is not retained at runtime, and up until now, we have not had use for it at runtime.

Tasks:
- Add to Java styleguide //styleguide/java/java.md
- Add a presubmit to ensure we always use it for new code.
- Bonus: Update IDE configurations to make them include the correct annotation.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 5

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/f68bcd6723daae993c23bb3387ca93362057c387

commit f68bcd6723daae993c23bb3387ca93362057c387
Author: Aiden Benner <abenner@google.com>
Date: Wed Dec 05 18:49:46 2018

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1de8f1e6e761842774c994aefb65df8e54cf746

commit d1de8f1e6e761842774c994aefb65df8e54cf746
Author: Aiden Benner <abenner@google.com>
Date: Wed Dec 05 20:31:59 2018

Use android Nullable instead of javax Nullable

This change is made in preparation for an ErrorProne
check to catch this at compile time. See bug for details.

Mechanical refactor.
TBR=agrieve@chromium.org

Bug:  771683 
Change-Id: I3d1bb120204e8f5ce59cf86d8340e59a34313161
Reviewed-on: https://chromium-review.googlesource.com/c/1357353
Commit-Queue: Aiden Benner <abenner@google.com>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614081}
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/base/android/java/src/org/chromium/base/library_loader/Linker.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/base/android/java/src/org/chromium/base/process_launcher/ChildProcessConnection.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/base/android/java/src/org/chromium/base/task/SequencedTaskRunnerImpl.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/base/android/java/src/org/chromium/base/task/SingleThreadTaskRunnerImpl.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/base/android/java/src/org/chromium/base/task/TaskRunnerImpl.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/base/android/java/src/org/chromium/base/task/TaskTraits.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/autofill/PhoneNumberUtil.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkWidgetService.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/browseractions/BrowserActionsTabPersistencePolicy.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuHelper.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchContext.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchObserver.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchRequest.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomButtonParams.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabTabPersistencePolicy.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadForegroundServiceManager.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadForegroundServiceObservers.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadLocationCustomView.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/feedback/ConnectivityTask.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/feedback/ScreenshotTask.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/firstrun/ForcedSigninProcessor.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/gsa/ContextReporter.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/help/HelpAndFeedback.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/identity/SettingsSecureBasedIdentificationGenerator.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/identity/UniqueIdentificationGenerator.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/identity/UuidBasedUniqueIdentificationGenerator.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/media/remote/AbstractMediaRouteController.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/media/remote/DefaultMediaRouteController.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/media/router/BaseMediaRouteDialogManager.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/media/router/ChromeMediaRouter.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/media/router/MediaRouteProvider.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/media/router/MediaSink.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/BaseMediaRouteProvider.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaSource.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastSession.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastSessionImpl.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CreateRouteRequest.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/remoting/RemotingMediaRouteProvider.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/remoting/RemotingMediaSource.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/multiwindow/MultiWindowUtils.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderBase.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderFactory.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsCategoryInfo.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeader.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/PlatformNetworksManager.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/VisibleNetworks.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/VisibleNetworksTracker.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillAddress.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillContact.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentApp.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/payments/ContactEditor.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/payments/PackageManagerDelegate.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentApp.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentInstrument.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentManifestVerifier.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentApp.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentAppBridge.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/payments/UriUtils.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/ContactDetailsSection.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/SectionInformation.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/SectionUiUtils.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/ShoppingCart.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchUtils.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsiteAddress.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/push_messaging/PushMessagingServiceObserver.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/services/gcm/InvalidationGcmUpstreamSender.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninHelper.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SiteSectionViewHolder.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/sync/ProfileSyncService.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/sync/SyncController.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistencePolicy.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/widget/RoundedIconGenerator.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/widget/ScrimView.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/widget/animation/FocusAnimator.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/widget/prefeditor/EditableOption.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/widget/prefeditor/EditorBase.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/widget/prefeditor/EditorDropdownField.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/widget/prefeditor/EditorFieldModel.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/widget/prefeditor/EditorModel.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/widget/prefeditor/EditorTextField.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/widget/selection/SelectableListLayout.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/java/src/org/chromium/chrome/browser/widget/selection/SelectableListToolbar.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabTabPersistencePolicyTest.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/javatests/src/org/chromium/chrome/browser/identity/UniqueIdentificationGeneratorFactoryTest.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/javatests/src/org/chromium/chrome/browser/media/router/MockMediaRouteProvider.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/javatests/src/org/chromium/chrome/browser/payments/MockPackageManagerDelegate.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/DocumentModeAssassinTest.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/notifications/MockNotificationManagerProxy.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMMessage.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GoogleCloudMessagingSubscriber.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GoogleCloudMessagingV2.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/components/invalidation/impl/android/java/src/org/chromium/components/invalidation/InvalidationClientService.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/components/invalidation/impl/android/java/src/org/chromium/components/invalidation/PendingInvalidation.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/components/sync/android/java/src/org/chromium/components/sync/AndroidSyncSettings.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/components/sync/android/java/src/org/chromium/components/sync/notifier/InvalidationPreferences.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/content/public/android/java/src/org/chromium/content/browser/ScreenOrientationProviderImpl.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/content/public/android/java/src/org/chromium/content/browser/input/CursorAnchorInfoController.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/content/public/android/java/src/org/chromium/content_public/browser/ScreenOrientationProvider.java
[modify] https://crrev.com/d1de8f1e6e761842774c994aefb65df8e54cf746/services/device/battery/android/java/src/org/chromium/device/battery/BatteryStatusManager.java

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f6f6371df0c9151ab37afb7ec65f15300a764edd

commit f6f6371df0c9151ab37afb7ec65f15300a764edd
Author: Aiden Benner <abenner@google.com>
Date: Thu Dec 06 19:29:41 2018

Add ErrorProne check to assert use of android.support.annotation.Nullable

Adds an android ErrorProne check to give a compiler error
when using javax Nullable instead of android Nullable.
See bug for motivation.

Bug:  771683 
Change-Id: I6384fa515405159e3fa894303022cad8bfc389b9
Reviewed-on: https://chromium-review.googlesource.com/c/1363677
Commit-Queue: Aiden Benner <abenner@google.com>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614445}
[modify] https://crrev.com/f6f6371df0c9151ab37afb7ec65f15300a764edd/tools/android/errorprone_plugin/BUILD.gn
[add] https://crrev.com/f6f6371df0c9151ab37afb7ec65f15300a764edd/tools/android/errorprone_plugin/src/org/chromium/tools/errorprone/plugin/AndroidNullableCheck.java

Project Member

Comment 4 by bugdroid1@chromium.org, Dec 10

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/69540f44196eba13cb7c9046aa838c461eba9029

commit 69540f44196eba13cb7c9046aa838c461eba9029
Author: Artem Titarenko <artit@webrtc.org>
Date: Mon Dec 10 15:03:58 2018

Use android Nullable instead of javax Nullable

This is a propagation of upstream chromium change needed to
resume DEPS autorolls into WebRTC.

Original comment from upstream change:

> This change is made in preparation for an ErrorProne
> check to catch this at compile time. See bug for details.

Bug:  chromium:771683 
Change-Id: I56aed15f73a633dcadae7ece6c645cd3596f9257
Reviewed-on: https://webrtc-review.googlesource.com/c/113505
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org>
Commit-Queue: Artem Titarenko <artit@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25951}
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/examples/BUILD.gn
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/examples/aarproject/app/build.gradle
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/examples/androidapp/src/org/appspot/apprtc/AppRTCAudioManager.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/examples/androidapp/src/org/appspot/apprtc/AppRTCBluetoothManager.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/examples/androidapp/src/org/appspot/apprtc/AppRTCProximitySensor.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/examples/androidapp/src/org/appspot/apprtc/CallActivity.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/examples/androidapp/src/org/appspot/apprtc/CpuMonitor.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/examples/androidapp/src/org/appspot/apprtc/DirectRTCClient.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/examples/androidapp/src/org/appspot/apprtc/RecordedAudioToFileController.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/examples/androidapp/src/org/appspot/apprtc/TCPChannelClient.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/examples/androidapp/src/org/appspot/apprtc/WebSocketChannelClient.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/examples/androidapp/src/org/appspot/apprtc/WebSocketRTCClient.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/examples/androidnativeapi/BUILD.gn
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/examples/androidnativeapi/java/org/webrtc/examples/androidnativeapi/MainActivity.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/examples/unityplugin/java/src/org/webrtc/UnityUtility.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/modules/audio_device/BUILD.gn
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioEffects.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioManager.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioTrack.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/rtc_base/BUILD.gn
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/rtc_base/java/src/org/webrtc/Logging.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/rtc_base/java/src/org/webrtc/ThreadUtils.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/BUILD.gn
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/api/org/webrtc/Camera1Capturer.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/api/org/webrtc/Camera1Enumerator.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/api/org/webrtc/Camera2Capturer.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/api/org/webrtc/Camera2Enumerator.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/api/org/webrtc/CameraVideoCapturer.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/api/org/webrtc/DefaultVideoDecoderFactory.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/api/org/webrtc/DefaultVideoEncoderFactory.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/api/org/webrtc/EglBase.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/api/org/webrtc/EglRenderer.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/api/org/webrtc/HardwareVideoDecoderFactory.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/api/org/webrtc/HardwareVideoEncoderFactory.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/api/org/webrtc/JavaI420Buffer.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/api/org/webrtc/MediaCodecVideoDecoder.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/api/org/webrtc/MediaCodecVideoEncoder.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/api/org/webrtc/MediaConstraints.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/api/org/webrtc/MediaStreamTrack.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/api/org/webrtc/NetworkMonitor.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/api/org/webrtc/NetworkMonitorAutoDetect.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/api/org/webrtc/PeerConnection.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/api/org/webrtc/PeerConnectionDependencies.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/api/org/webrtc/PeerConnectionFactory.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/api/org/webrtc/PlatformSoftwareVideoDecoderFactory.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/api/org/webrtc/RtpParameters.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/api/org/webrtc/RtpReceiver.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/api/org/webrtc/RtpSender.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/api/org/webrtc/ScreenCapturerAndroid.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/api/org/webrtc/SoftwareVideoDecoderFactory.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/api/org/webrtc/SoftwareVideoEncoderFactory.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/api/org/webrtc/SurfaceTextureHelper.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/api/org/webrtc/TextureBufferImpl.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/api/org/webrtc/VideoCodecInfo.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/api/org/webrtc/VideoDecoderFactory.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/api/org/webrtc/VideoEncoder.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/api/org/webrtc/VideoEncoderFactory.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/api/org/webrtc/VideoFrame.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/api/org/webrtc/VideoFrameDrawer.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/api/org/webrtc/VideoSource.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/instrumentationtests/src/org/webrtc/AndroidVideoDecoderInstrumentationTest.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/instrumentationtests/src/org/webrtc/Camera2CapturerTest.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/instrumentationtests/src/org/webrtc/CameraVideoCapturerTestFixtures.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/instrumentationtests/src/org/webrtc/DefaultVideoEncoderFactoryTest.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/instrumentationtests/src/org/webrtc/HardwareVideoEncoderTest.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/instrumentationtests/src/org/webrtc/NetworkMonitorTest.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/instrumentationtests/src/org/webrtc/PeerConnectionTest.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/instrumentationtests/src/org/webrtc/SurfaceTextureHelperTest.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/src/java/org/webrtc/AndroidVideoDecoder.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/src/java/org/webrtc/Camera1Session.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/src/java/org/webrtc/Camera2Session.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/src/java/org/webrtc/CameraCapturer.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/src/java/org/webrtc/EglBase10.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/src/java/org/webrtc/EglBase14.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/src/java/org/webrtc/GlGenericDrawer.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/src/java/org/webrtc/HardwareVideoEncoder.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/src/java/org/webrtc/MediaCodecUtils.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/src/java/org/webrtc/MediaCodecVideoDecoderFactory.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/src/java/org/webrtc/NV12Buffer.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/src/java/org/webrtc/NV21Buffer.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/src/java/org/webrtc/NativeCapturerObserver.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/src/java/org/webrtc/RefCountDelegate.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/src/java/org/webrtc/VideoEncoderWrapper.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/src/java/org/webrtc/audio/VolumeLogger.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/src/java/org/webrtc/audio/WebRtcAudioEffects.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/src/java/org/webrtc/audio/WebRtcAudioRecord.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/src/java/org/webrtc/audio/WebRtcAudioTrack.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/sdk/android/tests/src/org/webrtc/FakeMediaCodecWrapper.java
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/tools_webrtc/android/templates/pom.jinja
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/tools_webrtc/libs/generate_licenses.py
[modify] https://crrev.com/69540f44196eba13cb7c9046aa838c461eba9029/webrtc.gni

Project Member

Comment 5 by bugdroid1@chromium.org, Dec 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a28a6097182e739c4a8c600b538fcc07681fc7a3

commit a28a6097182e739c4a8c600b538fcc07681fc7a3
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Mon Dec 10 18:55:42 2018

Roll src/third_party/webrtc 24d8ec3dbb2a..69540f44196e (2 commits)

https://webrtc.googlesource.com/src.git/+log/24d8ec3dbb2a..69540f44196e


git log 24d8ec3dbb2a..69540f44196e --date=short --no-merges --format='%ad %ae %s'
2018-12-10 artit@webrtc.org Use android Nullable instead of javax Nullable
2018-12-10 aleloi@webrtc.org Re-tuning of VAD in AGC2.


Created with:
  gclient setdep -r src/third_party/webrtc@69540f44196e

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG= chromium:771683 , chromium:913430 
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I81441701fbdccb566d5422f9c6efafe66b9a1931
Reviewed-on: https://chromium-review.googlesource.com/c/1370284
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#615190}
[modify] https://crrev.com/a28a6097182e739c4a8c600b538fcc07681fc7a3/DEPS

Status: Fixed (was: Untriaged)

Sign in to add a comment