Text Selection handles are irrelevant during S-Pen Secondary button Selection |
|||
Issue descriptionChrome Version: 61.0.3163.98 OS: Android 7.1.1; SM-950U Build/NMF26X Device: Samsung Galaxy Note 8 What steps will reproduce the problem? (1) Load google.com page (2) Click on Privacy link down the page (3) By using S-Pen, press the secondary button and touch any text in the page (4) Observe text selection handles are getting appeared, even though the selection is anchored by S-Pen secondary button. What is the expected result? Since the text selection is anchored by S-Pen secondary button, text selection handle showing is not required What happens instead? Text Selection handles are getting shown before concluding the text selection using S-Pen secondary button.
,
Mar 13 2018
,
Mar 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/95207d52380ad0d71121c15a7bee7c77d58e4020 commit 95207d52380ad0d71121c15a7bee7c77d58e4020 Author: AJITH KUMAR V <ajith.v@samsung.com> Date: Mon Mar 26 18:32:58 2018 Hiding touch handles during stylus button selection While doing stylus button text selection, focus is mainly on the stylus button press and text selection is anchored by the stylus button. In that case touch handle has less significance (same with touch long press drag selection). So we can hide touch handles during stylus button selection and can show after stylus button selection is concluded. Bug: 771667 Change-Id: I9dccaabfd5fafccb68c1f0bce23bba36cea9061f Reviewed-on: https://chromium-review.googlesource.com/685054 Reviewed-by: Bo <boliu@chromium.org> Commit-Queue: AJITH KUMAR V <ajith.v@samsung.com> Cr-Commit-Position: refs/heads/master@{#545846} [modify] https://crrev.com/95207d52380ad0d71121c15a7bee7c77d58e4020/content/browser/renderer_host/render_widget_host_view_android.cc [modify] https://crrev.com/95207d52380ad0d71121c15a7bee7c77d58e4020/content/browser/renderer_host/render_widget_host_view_android.h
,
Mar 27 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by ajit...@samsung.com
, Oct 4 2017Owner: ajit...@samsung.com