Starting animation leaves halo circle |
||||||||||
Issue descriptionSign in and start "settings" before ARC++ fully started. It's probably hard to repro on production because Android starts (hence P3), but this happens often on dev machine. khmel@, can you triage?
,
Oct 17 2017
,
Oct 17 2017
,
Oct 17 2017
This is now with another fix is persistent. Up priority.
,
Oct 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eee1e7c136b81bf2ea54b0e60621fbf4d1c92947 commit eee1e7c136b81bf2ea54b0e60621fbf4d1c92947 Author: khmel <khmel@google.com> Date: Wed Oct 18 21:54:55 2017 shelf: Fix InkDrop animation does not end. This CL fixes issue when InkDrop animation stays on shelf button after the click. This was due item controller was replaced during the ItemSelected call and calling callback with action back to ash was dropped. Bug: 771655 Test: Manually Change-Id: I8af7dc844a441ada91c4e35b04847a09ebd582db Reviewed-on: https://chromium-review.googlesource.com/724201 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#509889} [modify] https://crrev.com/eee1e7c136b81bf2ea54b0e60621fbf4d1c92947/ash/shelf/shelf_button.cc [modify] https://crrev.com/eee1e7c136b81bf2ea54b0e60621fbf4d1c92947/ash/shelf/shelf_button.h [modify] https://crrev.com/eee1e7c136b81bf2ea54b0e60621fbf4d1c92947/chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc [modify] https://crrev.com/eee1e7c136b81bf2ea54b0e60621fbf4d1c92947/chrome/browser/ui/ash/launcher/arc_app_launcher_browsertest.cc [modify] https://crrev.com/eee1e7c136b81bf2ea54b0e60621fbf4d1c92947/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc [add] https://crrev.com/eee1e7c136b81bf2ea54b0e60621fbf4d1c92947/chrome/browser/ui/ash/launcher/chrome_launcher_controller_test_util.cc [add] https://crrev.com/eee1e7c136b81bf2ea54b0e60621fbf4d1c92947/chrome/browser/ui/ash/launcher/chrome_launcher_controller_test_util.h [modify] https://crrev.com/eee1e7c136b81bf2ea54b0e60621fbf4d1c92947/chrome/test/BUILD.gn
,
Oct 23 2017
Requesting M62 merge
,
Oct 23 2017
This bug requires manual review: Request affecting a post-stable build Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 23 2017
This looks like a significant CL, should we fix this in 63 first and reconsider 62 later if this is determined to be safe and high priority?
,
Oct 23 2017
#8 - sounds good.
,
Oct 24 2017
Approved for 63. Please re-add the 62 merge request if you think we will need it.
,
Oct 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d119c7b9add54e2898d8e664a68c8d6ca6f836cf commit d119c7b9add54e2898d8e664a68c8d6ca6f836cf Author: khmel <khmel@google.com> Date: Wed Oct 25 04:46:01 2017 [Merge M63] shelf: Fix InkDrop animation does not end. This CL fixes issue when InkDrop animation stays on shelf button after the click. This was due item controller was replaced during the ItemSelected call and calling callback with action back to ash was dropped. TBR=khmel@google.com (cherry picked from commit eee1e7c136b81bf2ea54b0e60621fbf4d1c92947) Bug: 771655 Test: Manually Change-Id: I8af7dc844a441ada91c4e35b04847a09ebd582db Reviewed-on: https://chromium-review.googlesource.com/724201 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#509889} Reviewed-on: https://chromium-review.googlesource.com/737276 Reviewed-by: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#209} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/d119c7b9add54e2898d8e664a68c8d6ca6f836cf/ash/shelf/shelf_button.cc [modify] https://crrev.com/d119c7b9add54e2898d8e664a68c8d6ca6f836cf/ash/shelf/shelf_button.h [modify] https://crrev.com/d119c7b9add54e2898d8e664a68c8d6ca6f836cf/chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc [modify] https://crrev.com/d119c7b9add54e2898d8e664a68c8d6ca6f836cf/chrome/browser/ui/ash/launcher/arc_app_launcher_browsertest.cc [modify] https://crrev.com/d119c7b9add54e2898d8e664a68c8d6ca6f836cf/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc [add] https://crrev.com/d119c7b9add54e2898d8e664a68c8d6ca6f836cf/chrome/browser/ui/ash/launcher/chrome_launcher_controller_test_util.cc [add] https://crrev.com/d119c7b9add54e2898d8e664a68c8d6ca6f836cf/chrome/browser/ui/ash/launcher/chrome_launcher_controller_test_util.h [modify] https://crrev.com/d119c7b9add54e2898d8e664a68c8d6ca6f836cf/chrome/test/BUILD.gn
,
Oct 25 2017
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by khmel@chromium.org
, Oct 4 2017