Support "-Wno-error=unknown-pragmas" in non-chromium code |
||
Issue descriptionAn example where this broke: https://chromium-review.googlesource.com/c/chromium/src/+/695328/7/third_party/WebKit/Source/modules/media_controls/MediaControlsResourceLoader.cpp Most developers likely aren't aware of the resource whitelisting we perform for official builds and disabling warnings-as-errors manually in code probably isn't ideal. Is this rare enough that we don't really care, or should we support it?
,
Oct 4 2017
I don't know of a work-around, so I don't think we have much choice anyways. Non-chromium code shouldn't be using PAK file resources directly anyways though, since that's a chrome concept.
,
Oct 4 2017
Didn't come up with anything either, we can revisit if this happens more frequently. |
||
►
Sign in to add a comment |
||
Comment 1 by estevenson@chromium.org
, Oct 4 2017