New issue
Advanced search Search tips

Issue 771633 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

16 KB regression in resource_sizes (MonochromePublic.apk) at 506302:506302

Project Member Reported by estevenson@chromium.org, Oct 4 2017

Issue description

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=771633

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=e725bd9b93b57b0f4a4a70e3c5658f5fe049757efa6f59e8543307b02c04ce24


Bot(s) for this bug's original alert(s):

Android Builder
Owner: tzik@chromium.org
Status: Assigned (was: Untriaged)
1090 symbols added (+), 2830 changed (~), 382 removed (-), 528746 unchanged (not shown)
Of changed symbols, 2388 grew, 1913 shrank
Number of unique symbols 411120 -> 411475 (+355)
0 paths added, 0 removed, 962 changed

Showing 4,302 symbols (aliases not grouped for diffs) with total pss: 13909 bytes
Histogram of symbols based on PSS:
    (-256,-128]: 2     (-16,-8]: 471   (-1,0): 1828       [2,4): 118       [32,64): 70
     (-128,-64]: 10     (-8,-4]: 672      {{0}}: 517396     [4,8): 417      [64,128): 17
      (-64,-32]: 63     (-4,-2]: 331    (0,1): 9822      [8,16): 668     [128,256): 1
      (-32,-16]: 337    (-2,-1]: 50     [1,2): 63       [16,32): 711   [2048,4096): 1
.text=13.6kb     .rodata=0 bytes    .data.rel.ro=0 bytes    .data=0 bytes    .bss=0 bytes    total=13.6kb
Number of unique paths: 963

Section Legend: t=.text, r=.rodata, R=.data.rel.ro, d=.data, b=.bss
Index | Running Total | Section@Address | Δ PSS (Δ size_without_padding) | Path
------------------------------------------------------------
~ 0)       3845 (27.7%) t@Group      3845 (0->0)        {{no path}}
               ** symbol gaps (count=9)
~ 1)       4005 (28.9%) t@0x1ab5830  160 (772->932)     third_party/WebKit/Source/core/css/BasicShapeFunctions.cpp
               blink::BasicShapeForValue
~ 2)       3861 (27.8%) t@0x13bbebc  -144 (592->448)    third_party/WebKit/Source/platform/text/BidiContext.cpp
               blink::BidiContext::Create
+ 3)       3733 (26.9%) t@0x0        -128 (0->0)        {{no path}}
               ** aggregate padding of diff'ed symbols
~ 4)       3613 (26.1%) t@Group      -120 (3204->3084)  third_party/WebKit/Source/core/dom/Document.cpp
               blink::Document::Document (count=2)
~ 5)       3723 (26.9%) t@0x1c316e6  110 (312->422)     third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp
               blink::HTMLCanvasElement::GetSourceImageForCanvas
~ 6)       3829 (27.6%) t@0x134272a  106 (23->130)      third_party/WebKit/Source/{{shared}}/5
               std::__ndk1::__sort5 (num_aliases=6->1)
~ 7)       3935 (28.4%) t@0x1a9ac32  106 (23->130)      third_party/WebKit/Source/core/animation/EffectInput.cpp
               std::__ndk1::__sort5 (num_aliases=6->1)
~ 8)       3831 (27.6%) t@0x1c31cbc  -104 (472->368)    third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp
               blink::HTMLCanvasElement::ToImageData const
~ 9)       3931 (28.4%) t@0x1356410  100 (720->820)     third_party/WebKit/Source/platform/fonts/FontFallbackIterator.cpp
               blink::FontFallbackIterator::Next
~ 10)      4031 (29.1%) t@0x1b350ec  100 (2312->2412)   third_party/WebKit/Source/core/css/resolver/TransformBuilder.cpp
               blink::TransformBuilder::CreateTransformOperations
~ 11)      3935 (28.4%) t@0x1d4d468  -96 (4304->4208)   third_party/WebKit/Source/core/layout/LayoutText.cpp
               blink::LayoutText::ComputePreferredLogicalWidths
~ 12)      4028 (29.1%) t@0x1342652  92 (21->114)       third_party/WebKit/Source/{{shared}}/5
               std::__ndk1::__sort3 (num_aliases=6->1)
~ 13)      4121 (29.7%) t@0x1a9ab5a  92 (21->114)       third_party/WebKit/Source/core/animation/EffectInput.cpp
               std::__ndk1::__sort3 (num_aliases=6->1)
~ 14)      4029 (29.1%) t@0x1f737d8  -92 (648->556)     third_party/WebKit/Source/modules/fetch/FetchManager.cpp
               blink::FetchManager::Loader::Start
~ 15)      4121 (29.7%) t@0x1aa1132  92 (952->1044)     third_party/WebKit/Source/core/animation/ListInterpolationFunctions.cpp
               blink::ListInterpolationFunctions::MaybeMergeSingles
~ 16)      4205 (30.3%) t@0x13426c4  84 (17->102)       third_party/WebKit/Source/{{shared}}/5
               std::__ndk1::__sort4 (num_aliases=6->1)
~ 17)      4289 (30.9%) t@0x1a9abcc  84 (17->102)       third_party/WebKit/Source/core/animation/EffectInput.cpp
               std::__ndk1::__sort4 (num_aliases=6->1)
~ 18)      4373 (31.5%) t@0x1ad6920  84 (684->768)      third_party/WebKit/Source/core/css/CSSSegmentedFontFace.cpp
               blink::CSSSegmentedFontFace::GetFontData
+ 19)      4449 (32.1%) t@0x135683c  76 (0->76)         third_party/WebKit/Source/{{shared}}/2
               blink::FontDataForRangeSetFromCache::FontDataForRangeSetFromCache
~ 20)      4525 (32.6%) t@0x1dddb10  76 (1672->1748)    third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
               blink::PaintPropertyTreeBuilder::UpdateProperties
~ 21)      4599 (33.2%) t@0x1aa1562  74 (1208->1282)    third_party/WebKit/Source/core/animation/ListInterpolationFunctions.cpp
               blink::ListInterpolationFunctions::Composite
~ 22)      4527 (32.7%) t@0x1d7783c  -72 (674->602)     third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc
               blink::NGOutOfFlowLayoutPart::LayoutDescendant
~ 23)      4455 (32.1%) t@0x2008438  -72 (340->268)     third_party/WebKit/Source/modules/webaudio/PannerNode.cpp
               blink::PannerHandler::PannerHandler
~ 24)      4383 (31.6%) t@0x13fccf0  -72 (400->328)     third_party/WebKit/Source/platform/loader/fetch/ResourceResponse.cpp
               blink::ResourceResponse::operator=
~ 25)      4451 (32.1%) t@0x1c48a78  68 (932->1000)     third_party/WebKit/Source/core/html/HTMLMarqueeElement.cpp
               blink::HTMLMarqueeElement::GetAnimationParameters
~ 26)      4387 (31.6%) t@0xbcda18   -64 (416->352)     third_party/WebKit/Source/platform/wtf/text/StringStatics.cpp
               WTF::StringStatics::Init
~ 27)      4323 (31.2%) t@0x1cb6ac0  -64 (632->568)     third_party/WebKit/Source/core/imagebitmap/ImageBitmap.cpp
               blink::ImageBitmap::CreateAsync
~ 28)      4259 (30.7%) t@0x1381760  -64 (2024->1960)   third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp
               blink::OffscreenCanvasFrameDispatcherImpl::DispatchFrame
~ 29)      4323 (31.2%) t@0x13faa58  64 (1280->1344)    third_party/WebKit/Source/platform/loader/fetch/ResourceLoader.cpp

See attached diff for more detail info.

It's not clear to me whether or not this increase was expected.
Please have a look and either:

Close as “Won't Fix” with a short justification, or
Land a revert / fix-up.
diff_results.txt
720 KB View Download

Comment 3 by tzik@chromium.org, Oct 5 2017

Hmm. That's from the difference of inlining score calculation around scoped_refptr and RefPtr.
ALWAYS_INLINE for small functions will help.

Comment 4 by tzik@chromium.org, Oct 5 2017

60% of the size gain will be canceled by a subsequent change: http://crrev.com/c/700334
Let me revisit this after landing the change.
Status: Fixed (was: Assigned)
The change mentioned in c#4 decreased the size by about 50% (8 kb), going to mark as fixed but please reopen if there's more to do here. 

Sign in to add a comment