New issue
Advanced search Search tips

Issue 771616 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Crash in AutocompleteActionPredictorTable::GetAllRows

Project Member Reported by alexilin@chromium.org, Oct 4 2017

Issue description

Link to the crash dashboard: https://crash.corp.google.com/browse?q=reportid=%271a0ad084f7d7ce4b%27

Presumably, a reason of the crash is dereferencing a null pointer passed to a TaskScheduler with a callback.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c0e42427a343a63bff51b8b578cb3a4c2f77485

commit 5c0e42427a343a63bff51b8b578cb3a4c2f77485
Author: Alexandr Ilin <alexilin@chromium.org>
Date: Wed Oct 04 15:35:34 2017

predictors: Remove several new statements and raw pointer usages

There is a crash registered in AutocompleteActionPredictorTable::GetAllRows
probably due to null pointer access. Culprit object is created with raw
new that may be dangerous. This CL removes this and several other usages
of a new statement in c/b/predictors.

Bug:  771616 
Change-Id: I30e87b470e623166d03c27694f232a5033b143bf
Reviewed-on: https://chromium-review.googlesource.com/700636
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506398}
[modify] https://crrev.com/5c0e42427a343a63bff51b8b578cb3a4c2f77485/chrome/browser/predictors/autocomplete_action_predictor.cc
[modify] https://crrev.com/5c0e42427a343a63bff51b8b578cb3a4c2f77485/chrome/browser/predictors/autocomplete_action_predictor.h
[modify] https://crrev.com/5c0e42427a343a63bff51b8b578cb3a4c2f77485/chrome/browser/predictors/preconnect_manager_unittest.cc
[modify] https://crrev.com/5c0e42427a343a63bff51b8b578cb3a4c2f77485/chrome/browser/predictors/resource_prefetch_predictor.cc
[modify] https://crrev.com/5c0e42427a343a63bff51b8b578cb3a4c2f77485/chrome/browser/predictors/resource_prefetch_predictor_unittest.cc
[modify] https://crrev.com/5c0e42427a343a63bff51b8b578cb3a4c2f77485/chrome/browser/predictors/resource_prefetcher.cc
[modify] https://crrev.com/5c0e42427a343a63bff51b8b578cb3a4c2f77485/chrome/browser/predictors/resource_prefetcher_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment