Add Telemetry flag that assert GPU rendering is activated |
|||||
Issue descriptionTo avoid bug like issue 770376 , we should add a flag that will crash Telemetry upon browser startup if it detects GPU rendering is not activated. This should be simple as we already have existing code that collect machine info (https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry/internal/browser/browser.py?rcl=672cabd12c680e8c75d0614c59d97479cbdfc47a&l=125). Once this flag is available, we can add it to all the GPU bots to ensure the right code path is executed.
,
Apr 2 2018
,
Apr 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/e9d7835c44ed3fe903838bae5930951d725ea9fa commit e9d7835c44ed3fe903838bae5930951d725ea9fa Author: Nghia Nguyen <nednguyen@google.com> Date: Tue Apr 03 22:59:27 2018 Add --assert-gpu-compositing flag to Telemetry This flags allows raising error upon detecting browser not using GPU compositing. This is useful for detecting hardware misconfiguration that makes the browser use software path for compositing instead of GPU Bug: chromium:771597 Change-Id: I8fcc421d969896526a254ec157c4e6d9032cf983 Reviewed-on: https://chromium-review.googlesource.com/963481 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> [add] https://crrev.com/e9d7835c44ed3fe903838bae5930951d725ea9fa/telemetry/telemetry/internal/backends/chrome/gpu_compositing_checker.py [modify] https://crrev.com/e9d7835c44ed3fe903838bae5930951d725ea9fa/telemetry/telemetry/internal/backends/chrome/android_browser_finder.py [modify] https://crrev.com/e9d7835c44ed3fe903838bae5930951d725ea9fa/telemetry/telemetry/internal/backends/chrome/cros_browser_finder.py [add] https://crrev.com/e9d7835c44ed3fe903838bae5930951d725ea9fa/telemetry/telemetry/internal/backends/chrome/gpu_compositing_checker_unittest.py [modify] https://crrev.com/e9d7835c44ed3fe903838bae5930951d725ea9fa/telemetry/telemetry/internal/backends/chrome/desktop_browser_finder.py [modify] https://crrev.com/e9d7835c44ed3fe903838bae5930951d725ea9fa/telemetry/telemetry/internal/browser/browser_options.py
,
Apr 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5dde0aaa939076144ba4baef956e9b00df700f0c commit 5dde0aaa939076144ba4baef956e9b00df700f0c Author: catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Wed Apr 04 03:20:16 2018 Roll src/third_party/catapult/ 1fcfd9b6d..e13394ffe (5 commits) https://chromium.googlesource.com/catapult.git/+log/1fcfd9b6d53d..e13394ffef36 $ git log 1fcfd9b6d..e13394ffe --date=short --no-merges --format='%ad %ae %s' 2018-03-30 dtu [pinpoint] Separate RunTest Quest into Telemetry and GTest Quests. 2018-04-03 simonhatch Dashboard - Default row error to 0.0 for histograms. 2018-04-03 simonhatch Dashboard - Ignore tir_label for summary statistics test paths. 2018-04-03 simonhatch Dashboard - Use a_stdio_uri not a_stdio_url 2018-04-03 nednguyen Add --assert-gpu-compositing flag to Telemetry Created with: roll-dep src/third_party/catapult BUG= chromium:771597 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I4309868ba184cf176edf8cec2f716d5b97420183 Reviewed-on: https://chromium-review.googlesource.com/994584 Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547963} [modify] https://crrev.com/5dde0aaa939076144ba4baef956e9b00df700f0c/DEPS
,
Jul 12
Do we need to make changes to make sure rendering.desktop/mobile benchmarks are run with --assert-gpu-compositing flag turned on in the perf bots?
,
Jul 12
sadrul@: yes we do. If someone can remind which builders are supposed to have GPU rendering, I am happy to add the extra flag.
,
Jul 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b0aae2d4f29b5a6d59e16260f81d19a8629a7e12 commit b0aae2d4f29b5a6d59e16260f81d19a8629a7e12 Author: Ned Nguyen <nednguyen@google.com> Date: Fri Jul 13 01:32:02 2018 Assert gpu-compositing for all Mac, Linux perf bots, all Win 10 and win 7 nvidia gpu perf Bug: 771597 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I6c56cc352acf0b00bc526dd032d5f9af5bbc2cd2 Reviewed-on: https://chromium-review.googlesource.com/1135873 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#574802} [modify] https://crrev.com/b0aae2d4f29b5a6d59e16260f81d19a8629a7e12/testing/buildbot/chromium.perf.json [modify] https://crrev.com/b0aae2d4f29b5a6d59e16260f81d19a8629a7e12/tools/perf/core/perf_data_generator.py
,
Jul 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba3e91b791530112940c9c55efc561156e9262f9 commit ba3e91b791530112940c9c55efc561156e9262f9 Author: Ned Nguyen <nednguyen@google.com> Date: Fri Jul 13 12:28:24 2018 Enable --assert-gpu-compositing flag for all Android bots Bug: 771597 Change-Id: I432d1f2d39745f311c4aba259bce8d1a080e48ba Reviewed-on: https://chromium-review.googlesource.com/1136431 Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#574886} [modify] https://crrev.com/ba3e91b791530112940c9c55efc561156e9262f9/testing/buildbot/chromium.perf.json [modify] https://crrev.com/ba3e91b791530112940c9c55efc561156e9262f9/tools/perf/core/perf_data_generator.py
,
Jul 13
,
Jan 16
,
Jan 16
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by nednguyen@chromium.org
, Mar 14 2018