New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 771578 link

Starred by 3 users
Status: Assigned
Owner:
einbinder@chromium.org
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Focus does not come on link on pressing tab in dev tools

Reported by vineetha...@etouch.net, Oct 4 2017 
Chrome version: 62.0.3202.45 ca262a4fff487c2dbe6f28f66c7f6f5806462ee3-refs/branch-heads/3202@{#573}(32/64 Bit).
OS: Windows (7,8,10),Linux (14.04 LTS), Mac(10.12.6).

Steps to reproduce:
1. Launch Chrome. Navigate to NTP > Developer tools > Press F1 > Navigate to Shortcuts option.
2. Press tab to get focus on the link "Full list of Dev Tools keyboard...." and observe.

Actual Result: Keyboard focus does not come on the above mentioned link.
Expected Result: Keyboard focus should come on the above mentioned link.

This is Regression Issue broken in M-57 and and Using the per-revision bisect providing the bisect results,
Good Build: 57.0.2929.0(Revision: 434072)
Bad Build: 57.0.2931.0(Revision: 434310)

You are probably looking for a change made after 434112 (known good), but no later than 434113 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

  https://chromium.googlesource.com/chromium/src/+log/5af8ece2ced7dbd69787415834a2955768a63486..411a262c8298a3f9acd8db3f9650067a0a984d54

Suspect : https://chromium.googlesource.com/chromium/src/+/411a262c8298a3f9acd8db3f9650067a0a984d54

@dgozman : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.
ActualResult.mp4
1.3 MB View Download
ExpectedResult.mp4
1.1 MB View Download

Comment 1 by dgozman@chromium.org, Oct 4 2017

Owner: einbinder@chromium.org
Joel, mind taking a look?
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2cd778f652fe1166f656da1392b1fb0db4bb31b6

commit 2cd778f652fe1166f656da1392b1fb0db4bb31b6
Author: Joel Einbinder <einbinder@chromium.org>
Date: Fri Nov 10 23:58:02 2017

DevTools: Make links focusable

Bug: 771578
Change-Id: I4928067b157e6297b652761d09955910b574fc73
Reviewed-on: https://chromium-review.googlesource.com/738327
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515750}
[modify] https://crrev.com/2cd778f652fe1166f656da1392b1fb0db4bb31b6/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js
[modify] https://crrev.com/2cd778f652fe1166f656da1392b1fb0db4bb31b6/third_party/WebKit/Source/devtools/front_end/ui/inspectorSyntaxHighlight.css

Comment 3 by vineetha...@etouch.net, Nov 13 2017

Labels: TE-Verified-M64 TE-Verified-64.0.3267.0
Update : 
Retested above issue on Windows(7,8,10) and Linux OS using latest Canary #64.0.3267.0 and issue is fixed. Kindly review an attached screen cast.

Thank you!
FixedVideo.mp4
581 KB View Download

Comment 4 by vineetha...@etouch.net, Nov 14 2017

Labels: TE-Verified-64.0.3265.0
Update : 
Also tested the above issue on Mac OS using Canary #64.0.3265.0 and issue is fixed. Kindly review an attached screen cast.

Thank you!
FixedVideo.mov
14.7 MB Download

Comment 5 by tkent@chromium.org, Mar 2 2018

Components: -Blink>HTML>Focus
►

Sign in to add a comment