tagging with blocker label, please undo if not the case.

Minimal repro:
 <div style="user-select: text">
 Here comes <a href="www">a link text</a> in the middle of user-select: text.
 </div>

Workaround: 
 <div style="user-select: auto">
 ...
 </div>

It happens because of the logic in Node::CanStartSelection(). From users' perspective, I think it makes sense that "selectability" trumps "draggability". Does the spec say anything about this? 

Could someone from reviewer's list (cc'ed) answer c#2?

I made an attempt to solve this at https://chromium-review.googlesource.com/c/chromium/src/+/705234 .

Pada 5 Okt 2017 16:00, "hu… via monorail" <
monorail+v2.583525691@chromium.org> menulis:

meade@, ccing you in on a regression. I can't find a spec reference to answer c#2. could you TAL? The change in in c#6 sounds simple enough. 

ccing Tab for the spec question in c#2

According to the spec[1], user-select CSS property should not affect draggability
of node.

It seems current implementation is somewhat ad-hoc.


[1] https://html.spec.whatwg.org/multipage/dnd.html#drag-and-drop-processing-model

Lower to Pri-3 and remove release-blocker label since dragging link to search
field is frequent user scenario.

I think it's fairly common to drag links to the "tab bar" (an alternative to right click and "Open link in new tab"). Imagine your keyboard disconnected and your mouse's right button broken... I'd say this is at least Pri-2.

I would agree with Hugo here. I am sure there are accessibility implications of this change as well. 

Added Merge-Request-62 for https://chromium-review.googlesource.com/c/chromium/src/+/705234. I prefer to not let this glitch slip into M-62.

This bug requires manual review: We are only 6 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

My recommendation is to wait until M63. Since this hasn't been tested in canary yet and our last M62 Beta release is scheduled for tomorrow, this doesn't meet the requirements for merge to Beta branch. This is also not considered a release blocker. Rejecting merge to M62. If you think otherwise, please provide a detailed explanation of why this is critical. 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e2c1dd03e4aa24a1e606c287b0680911408ae88

commit 2e2c1dd03e4aa24a1e606c287b0680911408ae88
Author: Hugo Holgersson <hugoh@vewd.com>
Date: Fri Oct 13 09:42:17 2017

Make links draggable despite 'user-select: text' styling

Problem:
 When a Text node, "hey" is within a link that is within
 |user-select: text|,

 <div style="user-select: text"><a href="">hey</a></div>

 The link text, "hey" should be draggable despite any
 user-select styling.

Background:
 The bug surfaced because Node::CanStartSelection
 returns true for any node that is within a
 |user-select: text| sub tree. That made
 DragController::DraggableNode make the wrong decision
 (it returned nullptr for start_node = "hey").

Solution:
 With a new helper, SelectTextInsteadOfDrag we check if
 a dragged node is a selectable and undraggable Text node.

Note:
 There can only be one Text node in the ancestor chain
 (because Text nodes cannot have children) so
 SelectTextInsteadOfDrag will only be called once.

Bug:  771573 
Change-Id: Id482cf0888cd428d0bc9a12bff535743c7138df8
Reviewed-on: https://chromium-review.googlesource.com/705234
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Hugo Holgersson <hugoh@vewd.com>
Cr-Commit-Position: refs/heads/master@{#508658}
[add] https://crrev.com/2e2c1dd03e4aa24a1e606c287b0680911408ae88/third_party/WebKit/LayoutTests/editing/selection/mouse/drags_within_user-select_combos.html
[modify] https://crrev.com/2e2c1dd03e4aa24a1e606c287b0680911408ae88/third_party/WebKit/Source/core/page/DragController.cpp

Your change meets the bar and is auto-approved for M63. Please go ahead and merge the CL to branch 3239 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e468a76f7ac58cb8b8050862164f6020aaf0d792

commit e468a76f7ac58cb8b8050862164f6020aaf0d792
Author: Hugo Holgersson <hugoh@vewd.com>
Date: Tue Oct 17 21:34:53 2017

Make links draggable despite 'user-select: text' styling

Problem:
 When a Text node, "hey" is within a link that is within
 |user-select: text|,

 <div style="user-select: text"><a href="">hey</a></div>

 The link text, "hey" should be draggable despite any
 user-select styling.

Background:
 The bug surfaced because Node::CanStartSelection
 returns true for any node that is within a
 |user-select: text| sub tree. That made
 DragController::DraggableNode make the wrong decision
 (it returned nullptr for start_node = "hey").

Solution:
 With a new helper, SelectTextInsteadOfDrag we check if
 a dragged node is a selectable and undraggable Text node.

Note:
 There can only be one Text node in the ancestor chain
 (because Text nodes cannot have children) so
 SelectTextInsteadOfDrag will only be called once.

TBR=pdr@chromium.org

(cherry picked from commit 2e2c1dd03e4aa24a1e606c287b0680911408ae88)

Bug:  771573 
Change-Id: Id482cf0888cd428d0bc9a12bff535743c7138df8
Reviewed-on: https://chromium-review.googlesource.com/705234
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Hugo Holgersson <hugoh@vewd.com>
Cr-Original-Commit-Position: refs/heads/master@{#508658}
Reviewed-on: https://chromium-review.googlesource.com/723284
Reviewed-by: Hugo Holgersson <hugoh@vewd.com>
Cr-Commit-Position: refs/branch-heads/3239@{#37}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[add] https://crrev.com/e468a76f7ac58cb8b8050862164f6020aaf0d792/third_party/WebKit/LayoutTests/editing/selection/mouse/drags_within_user-select_combos.html
[modify] https://crrev.com/e468a76f7ac58cb8b8050862164f6020aaf0d792/third_party/WebKit/Source/core/page/DragController.cpp

 Issue 777638  has been merged into this issue.

Observing feedbacks for M62-stable, released on October 24, if there are lots of
feedbacks, we want to merge into M62.

The NextAction date has arrived: 2017-11-01