New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 771556 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Page movements are not smooth for Sign-In page when Wi-Fi is disabled

Project Member Reported by rkalavakuntla@chromium.org, Oct 4 2017

Issue description

Chrome Version:62.0.3202.43/9901.35.0 dev-channel Kip,Peppy,Celes
OS:Chrome OS

What steps will reproduce the problem?
(1)Recover Build ->Open 'Sign in to your Chromebook' page ->Turn Off the wi-fi
(2)In 'Network not available' page ->click on 'sign in as an existing user' -> enter your email, click on next to go to password page
(3)Now click on Back button and Observe (Kindly refer video)

Actual: While clicking on Back button delay is seen in page movement such that profile icon appears in right corner 
Expected: Page movements should be done smoothly without any delay

Raising it as Regression since old Sign-In UI works fine in M-60

Note:Issue is not seen in Linux,Windows OS

@alemate: Please confirm the issue

 
Actual.mp4
17.4 MB Download
Expected.mp4
7.9 MB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/898c7b4e90619244d3b9ace8c3249e0e7b8a4f7d

commit 898c7b4e90619244d3b9ace8c3249e0e7b8a4f7d
Author: Alexander Alekseev <alemate@chromium.org>
Date: Wed Oct 25 21:00:53 2017

Chrome OS: make Offline Gaia screen animations smooth.

Offline Gaia screen has two blocks which must be animated synchronously.
<neon-animated-pages> (deprecated) are not suitable for this, so
this CL replaces it with pure CSS animations.

Bug:  771556 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ie108f1bcf4a6c911654c05933919cc33297e192c
Reviewed-on: https://chromium-review.googlesource.com/734581
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511583}
[modify] https://crrev.com/898c7b4e90619244d3b9ace8c3249e0e7b8a4f7d/chrome/browser/resources/chromeos/login/offline_gaia.css
[modify] https://crrev.com/898c7b4e90619244d3b9ace8c3249e0e7b8a4f7d/chrome/browser/resources/chromeos/login/offline_gaia.html
[modify] https://crrev.com/898c7b4e90619244d3b9ace8c3249e0e7b8a4f7d/chrome/browser/resources/chromeos/login/offline_gaia.js

Status: Fixed (was: Assigned)
Labels: Merge-Request-63

Comment 4 by gkihumba@google.com, Oct 26 2017

Labels: -Merge-Request-63 Merge-Approved-63
Project Member

Comment 5 by sheriffbot@chromium.org, Oct 30 2017

Cc: gkihumba@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 30 2017

Labels: -merge-approved-63 merge-merged-3239
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7455abb12c86d03ce09429cdec0a161f51632fa1

commit 7455abb12c86d03ce09429cdec0a161f51632fa1
Author: Alexander Alekseev <alemate@chromium.org>
Date: Mon Oct 30 19:46:55 2017

Chrome OS: make Offline Gaia screen animations smooth.

Offline Gaia screen has two blocks which must be animated synchronously.
<neon-animated-pages> (deprecated) are not suitable for this, so
this CL replaces it with pure CSS animations.

TBR=alemate@chromium.org

(cherry picked from commit 898c7b4e90619244d3b9ace8c3249e0e7b8a4f7d)

Bug:  771556 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ie108f1bcf4a6c911654c05933919cc33297e192c
Reviewed-on: https://chromium-review.googlesource.com/734581
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#511583}
Reviewed-on: https://chromium-review.googlesource.com/744316
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#297}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/7455abb12c86d03ce09429cdec0a161f51632fa1/chrome/browser/resources/chromeos/login/offline_gaia.css
[modify] https://crrev.com/7455abb12c86d03ce09429cdec0a161f51632fa1/chrome/browser/resources/chromeos/login/offline_gaia.html
[modify] https://crrev.com/7455abb12c86d03ce09429cdec0a161f51632fa1/chrome/browser/resources/chromeos/login/offline_gaia.js

Status: Verified (was: Fixed)
Verified on M64 dev build (10109.0.0, 64.0.3261.0).

Sign in to add a comment