New issue
Advanced search Search tips

Issue 771540 link

Starred by 1 user
Status: Fixed
Owner:
hta@chromium.org
Closed: Oct 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 706359


Sign in to add a comment

WPT tests for webrtc fail when not mocking RTCPeerConnectionHandler

Project Member Reported by hta@chromium.org, Oct 4 2017 
When experimenting with deleting the content/ mock of RTCPeerConnectionHandler, I found that several WPT webrtc tests that are not listed in TestExpectations failed when the mock was deleted.

This indicates that the mock was hiding the errors.

This bug tracks those issues, and serves as a reference in TestExpectations.

Mock deletion CL (WIP): https://chromium-review.googlesource.com/c/chromium/src/+/697806

Comment 1 by hta@chromium.org, Oct 5 2017 

The following tests:

fast/peerconnection/RTCPeerConnection-datachannel.html
fast/peerconnection/RTCPeerConnection-dtmf.html
fast/peerconnection/RTCPeerConnection-ice-promise.html
fast/peerconnection/RTCPeerConnection-ice.html
fast/peerconnection/RTCPeerConnection-lifetime.html
fast/peerconnection/RTCPeerConnection-ontrack.html

seem to be testing stuff that isn't tested elsewhere, but rely on mock-specific behavior. They need to be rewritten rather than deleted.

Also, RTCPeerConnection-stats tests the old stats model, which the WPT tests will not do for us; they need to be updated too.

Comment 2 by hta@chromium.org, Oct 11 2017

Blockedon: 706359

Comment 3 by hta@chromium.org, Oct 11 2017

Owner: hta@chromium.org

Comment 4 by fhorschig@chromium.org, Oct 11 2017 

The test in external/wpt/webrtc/getstats.html seems to be flaky:

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/34019

Please investigate there, too.

Comment 5 by fhorschig@chromium.org, Oct 11 2017

Status: Assigned (was: Untriaged)
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68e8a89834946651c5ab54de10710be2cc21b68c

commit 68e8a89834946651c5ab54de10710be2cc21b68c
Author: Harald Alvestrand <hta@chromium.org>
Date: Wed Oct 11 14:23:02 2017

Reland "Remove MockWebRTCPeerConnectionHandler""

This reverts commit 22f808a28c411c51d5f93bc505347be671a37f1d.

Reason for revert: Marking failing test as flaky.

TBR=peter@chromium.org,dpranke@chromium.org,hbos@chromium.org,foolip@chromium.org,jochen@chromium.org

Bug:  706359 ,  773609 ,  771540 
Change-Id: I68e9b3e511f0039690f2e8d09667ca6a754400f7
Reviewed-on: https://chromium-review.googlesource.com/712094
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507978}
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/content/public/renderer/content_renderer_client.cc
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/content/public/renderer/content_renderer_client.h
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/content/shell/renderer/layout_test/layout_test_content_renderer_client.cc
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/content/shell/renderer/layout_test/layout_test_content_renderer_client.h
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/content/shell/test_runner/BUILD.gn
[delete] https://crrev.com/e02173ba74d4b1703656902dcb39ca8c1da782c8/content/shell/test_runner/mock_webrtc_data_channel_handler.cc
[delete] https://crrev.com/e02173ba74d4b1703656902dcb39ca8c1da782c8/content/shell/test_runner/mock_webrtc_data_channel_handler.h
[delete] https://crrev.com/e02173ba74d4b1703656902dcb39ca8c1da782c8/content/shell/test_runner/mock_webrtc_dtmf_sender_handler.cc
[delete] https://crrev.com/e02173ba74d4b1703656902dcb39ca8c1da782c8/content/shell/test_runner/mock_webrtc_dtmf_sender_handler.h
[delete] https://crrev.com/e02173ba74d4b1703656902dcb39ca8c1da782c8/content/shell/test_runner/mock_webrtc_peer_connection_handler.cc
[delete] https://crrev.com/e02173ba74d4b1703656902dcb39ca8c1da782c8/content/shell/test_runner/mock_webrtc_peer_connection_handler.h
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/content/shell/test_runner/web_frame_test_proxy.h
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/content/shell/test_runner/web_test_interfaces.cc
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCCertificate-expected.txt
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCConfiguration-bundlePolicy-expected.txt
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCConfiguration-iceServers-expected.txt
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCConfiguration-rtcpMuxPolicy-expected.txt
[add] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCDataChannel-bufferedAmount-expected.txt
[delete] https://crrev.com/e02173ba74d4b1703656902dcb39ca8c1da782c8/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCDataChannel-id-expected.txt
[add] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCDataChannel-send-expected.txt
[add] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCDtlsTransport-getRemoteCertificates-expected.txt
[add] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCIceTransport-expected.txt
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-addIceCandidate-expected.txt
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-canTrickleIceCandidates-expected.txt
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-constructor-expected.txt
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-createAnswer-expected.txt
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-createDataChannel-expected.txt
[add] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-createOffer-expected.txt
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-iceGatheringState-expected.txt
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-idl-expected.txt
[add] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-ondatachannel-expected.txt
[add] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-onnegotiationneeded-expected.txt
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-ontrack-expected.txt
[add] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-setLocalDescription-answer-expected.txt
[add] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-setLocalDescription-expected.txt
[add] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-setLocalDescription-offer-expected.txt
[add] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-setLocalDescription-pranswer-expected.txt
[add] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-setLocalDescription-rollback-expected.txt
[add] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-setRemoteDescription-answer-expected.txt
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-setRemoteDescription-expected.txt
[add] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-setRemoteDescription-offer-expected.txt
[add] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-setRemoteDescription-pranswer-expected.txt
[add] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-setRemoteDescription-rollback-expected.txt
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/datachannel-emptystring-expected.txt
[delete] https://crrev.com/e02173ba74d4b1703656902dcb39ca8c1da782c8/third_party/WebKit/LayoutTests/external/wpt/webrtc/getstats-expected.txt
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/external/wpt/webrtc/interfaces-expected.txt
[delete] https://crrev.com/e02173ba74d4b1703656902dcb39ca8c1da782c8/third_party/WebKit/LayoutTests/external/wpt/webrtc/no-media-call-expected.txt
[delete] https://crrev.com/e02173ba74d4b1703656902dcb39ca8c1da782c8/third_party/WebKit/LayoutTests/external/wpt/webrtc/promises-call-expected.txt
[delete] https://crrev.com/e02173ba74d4b1703656902dcb39ca8c1da782c8/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-createAnswer-promise.html
[delete] https://crrev.com/e02173ba74d4b1703656902dcb39ca8c1da782c8/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-createAnswer.html
[delete] https://crrev.com/e02173ba74d4b1703656902dcb39ca8c1da782c8/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-createOffer-promise-expected.txt
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-createOffer-promise.html
[delete] https://crrev.com/e02173ba74d4b1703656902dcb39ca8c1da782c8/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-createOffer.html
[delete] https://crrev.com/e02173ba74d4b1703656902dcb39ca8c1da782c8/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-datachannel-expected.txt
[delete] https://crrev.com/e02173ba74d4b1703656902dcb39ca8c1da782c8/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-dtmf-expected.txt
[delete] https://crrev.com/e02173ba74d4b1703656902dcb39ca8c1da782c8/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-getReceivers.html
[delete] https://crrev.com/e02173ba74d4b1703656902dcb39ca8c1da782c8/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-getStats-promise.html
[delete] https://crrev.com/e02173ba74d4b1703656902dcb39ca8c1da782c8/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-ice-promise-expected.txt
[delete] https://crrev.com/e02173ba74d4b1703656902dcb39ca8c1da782c8/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-lifetime-expected.txt
[delete] https://crrev.com/e02173ba74d4b1703656902dcb39ca8c1da782c8/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-localDescription-promise.html
[delete] https://crrev.com/e02173ba74d4b1703656902dcb39ca8c1da782c8/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-localDescription.html
[delete] https://crrev.com/e02173ba74d4b1703656902dcb39ca8c1da782c8/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-remoteDescription-promise.html
[delete] https://crrev.com/e02173ba74d4b1703656902dcb39ca8c1da782c8/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-remoteDescription.html
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-stats-expected.txt
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-stats.html
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-statsSelector-expected.txt
[modify] https://crrev.com/68e8a89834946651c5ab54de10710be2cc21b68c/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-statsSelector.html
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b71b2849fdaf3e4af1817f2cded0056220ad92e

commit 6b71b2849fdaf3e4af1817f2cded0056220ad92e
Author: Harald Alvestrand <hta@chromium.org>
Date: Thu Oct 12 07:00:18 2017

Fix RTCPeerConnection-datachannel test

This change fixes one of the timeout issues found when removing the
mocked PeerConnectionHandler. It also fixes an erroneous test assumption.

Bug:  771540 
Change-Id: I5597633f26dabc4bc2fc5addf1646a381b9da058
Reviewed-on: https://chromium-review.googlesource.com/711848
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508270}
[modify] https://crrev.com/6b71b2849fdaf3e4af1817f2cded0056220ad92e/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/52d632bd80b420048553b623fc8e5fbb2bc09849/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-createAnswer-expected.txt
[delete] https://crrev.com/52d632bd80b420048553b623fc8e5fbb2bc09849/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-createOffer-expected.txt
[add] https://crrev.com/6b71b2849fdaf3e4af1817f2cded0056220ad92e/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-datachannel-expected.txt
[modify] https://crrev.com/6b71b2849fdaf3e4af1817f2cded0056220ad92e/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-datachannel.html
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ab09f685c1d31dfbf4000f2cfcb842e24abe760

commit 0ab09f685c1d31dfbf4000f2cfcb842e24abe760
Author: Harald Alvestrand <hta@chromium.org>
Date: Thu Oct 12 12:37:02 2017

Change media-using tests to be .https.html

This allows access to media in Chrome without
special tricks.

Bug:  771540 
Change-Id: Ib56ac556d04065a18a4c2cd46838eff8b0bbb3e2
Reviewed-on: https://chromium-review.googlesource.com/715896
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508320}
[rename] https://crrev.com/0ab09f685c1d31dfbf4000f2cfcb842e24abe760/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCDTMFSender-insertDTMF.https-expected.txt
[rename] https://crrev.com/0ab09f685c1d31dfbf4000f2cfcb842e24abe760/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCDTMFSender-insertDTMF.https.html
[delete] https://crrev.com/4b7d4b1d8b792ecec516222e2ac1babe4499b7b0/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCDTMFSender-ontonechange-expected.txt
[delete] https://crrev.com/4b7d4b1d8b792ecec516222e2ac1babe4499b7b0/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCDTMFSender-ontonechange-long-expected.txt
[add] https://crrev.com/0ab09f685c1d31dfbf4000f2cfcb842e24abe760/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCDTMFSender-ontonechange-long.https-expected.txt
[rename] https://crrev.com/0ab09f685c1d31dfbf4000f2cfcb842e24abe760/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCDTMFSender-ontonechange-long.https.html
[add] https://crrev.com/0ab09f685c1d31dfbf4000f2cfcb842e24abe760/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCDTMFSender-ontonechange.https-expected.txt
[rename] https://crrev.com/0ab09f685c1d31dfbf4000f2cfcb842e24abe760/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCDTMFSender-ontonechange.https.html
[delete] https://crrev.com/4b7d4b1d8b792ecec516222e2ac1babe4499b7b0/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-addTrack-expected.txt
[add] https://crrev.com/0ab09f685c1d31dfbf4000f2cfcb842e24abe760/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-addTrack.https-expected.txt
[rename] https://crrev.com/0ab09f685c1d31dfbf4000f2cfcb842e24abe760/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-addTrack.https.html
[rename] https://crrev.com/0ab09f685c1d31dfbf4000f2cfcb842e24abe760/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-getStats.https-expected.txt
[rename] https://crrev.com/0ab09f685c1d31dfbf4000f2cfcb842e24abe760/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-getStats.https.html
[rename] https://crrev.com/0ab09f685c1d31dfbf4000f2cfcb842e24abe760/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-ontrack.https-expected.txt
[rename] https://crrev.com/0ab09f685c1d31dfbf4000f2cfcb842e24abe760/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-ontrack.https.html
[rename] https://crrev.com/0ab09f685c1d31dfbf4000f2cfcb842e24abe760/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-removeTrack.https-expected.txt
[rename] https://crrev.com/0ab09f685c1d31dfbf4000f2cfcb842e24abe760/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-removeTrack.https.html
[modify] https://crrev.com/0ab09f685c1d31dfbf4000f2cfcb842e24abe760/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-setLocalDescription-answer-expected.txt
[add] https://crrev.com/0ab09f685c1d31dfbf4000f2cfcb842e24abe760/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCRtpReceiver-getContributingSources.https-expected.txt
[rename] https://crrev.com/0ab09f685c1d31dfbf4000f2cfcb842e24abe760/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCRtpReceiver-getContributingSources.https.html
[delete] https://crrev.com/4b7d4b1d8b792ecec516222e2ac1babe4499b7b0/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCRtpReceiver-getSynchronizationSources-expected.txt
[rename] https://crrev.com/0ab09f685c1d31dfbf4000f2cfcb842e24abe760/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCRtpReceiver-getSynchronizationSources.https-expected.txt
[rename] https://crrev.com/0ab09f685c1d31dfbf4000f2cfcb842e24abe760/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCRtpReceiver-getSynchronizationSources.https.html
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/636222826927f677f065e5243d6ae433275075f6

commit 636222826927f677f065e5243d6ae433275075f6
Author: Harald Alvestrand <hta@chromium.org>
Date: Tue Oct 17 06:10:40 2017

Fix RTCPeerConnection tests that timed out after real PC

Rewrote RTCPeerConnection-lifetime and RTCPeerCOnnection-ontrack
to work with real peerconnections.

Deleted three tests that should have appropriate coverage
in existing WPT tests.

Bug:  771540 
Change-Id: I1d5d26bb48ce4993714115bdcfb9ceb2edd02947
Reviewed-on: https://chromium-review.googlesource.com/715597
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509284}
[modify] https://crrev.com/636222826927f677f065e5243d6ae433275075f6/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/636222826927f677f065e5243d6ae433275075f6/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-datachannel.html
[delete] https://crrev.com/31c85e74fd567772f18e0a41be468d04af721f21/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-dtmf.html
[delete] https://crrev.com/31c85e74fd567772f18e0a41be468d04af721f21/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-ice-promise.html
[delete] https://crrev.com/31c85e74fd567772f18e0a41be468d04af721f21/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-ice.html
[add] https://crrev.com/636222826927f677f065e5243d6ae433275075f6/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-lifetime-expected.txt
[modify] https://crrev.com/636222826927f677f065e5243d6ae433275075f6/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-lifetime.html
[modify] https://crrev.com/636222826927f677f065e5243d6ae433275075f6/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-ontrack.html
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f8faea942ca0f1617d14f20ec248e50f2aef11d

commit 2f8faea942ca0f1617d14f20ec248e50f2aef11d
Author: Harald Alvestrand <hta@chromium.org>
Date: Tue Oct 17 22:12:26 2017

WPT webrtc/getstats test: Allow 0 and 1 datachannels

There seems to be a race on whether the count of datachannels
is incremented before a session goes to "connected". This CL
allows both 0 and 1.

The test would fail ~1/4000 times on a Linux workstation.

Bug:  771540 
Change-Id: Ic250443c2addef995dbb26e7cd021a516dcd023b
Reviewed-on: https://chromium-review.googlesource.com/721379
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509564}
[modify] https://crrev.com/2f8faea942ca0f1617d14f20ec248e50f2aef11d/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/2f8faea942ca0f1617d14f20ec248e50f2aef11d/third_party/WebKit/LayoutTests/external/wpt/webrtc/getstats.html
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35acc2846fa09422dbbb941562067f94cd6a5e0e

commit 35acc2846fa09422dbbb941562067f94cd6a5e0e
Author: Henrik Boström <hbos@chromium.org>
Date: Wed Oct 18 00:28:14 2017

Rename external/wpt/webrtc/interfaces.html to interfaces.https.html.

This makes the origin secure so that getUserMedia() doesn't fail.
Updated expected file too.

Bug:  771540 
Change-Id: I2717e195d6fb52cd2dedf45dd5c48b05b1058823
Reviewed-on: https://chromium-review.googlesource.com/716719
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509623}
[rename] https://crrev.com/35acc2846fa09422dbbb941562067f94cd6a5e0e/third_party/WebKit/LayoutTests/external/wpt/webrtc/interfaces.https-expected.txt
[rename] https://crrev.com/35acc2846fa09422dbbb941562067f94cd6a5e0e/third_party/WebKit/LayoutTests/external/wpt/webrtc/interfaces.https.html

Comment 12 by hta@chromium.org, Oct 21 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment