[CRD iOS] Can't refresh when the host list fails to load right after the app is launch |
||||
Issue descriptionApp Version: 63.0.3233.0 OS: 11.0.1 What steps will reproduce the problem? (1) Turn on airplane mode (2) Launch the app What is the expected result? The user should not only get the error message about network not available but also have a chance to refresh the host list. What happens instead? A toast pops up complaining about network unavailable. Nothing else is shown. Pull-to-refresh doesn't work.
,
Oct 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/88505a5ed0fb0d6ccb8964778a29a23a84aac75d commit 88505a5ed0fb0d6ccb8964778a29a23a84aac75d Author: Yuwei Huang <yuweih@chromium.org> Date: Wed Oct 04 22:13:02 2017 [CRD iOS] Add a view for host fetch failure for non-user-triggered refresh Previously if a host list fetch is not triggered by the user (refresh control) and fails, then the app will simply pop up a toast complaining about unavailable network and show nothing else. Pull-to-refresh doesn't work. This CL fixes this by providing a dialog-like view to allow user to retry in that case. Screenshot: https://drive.google.com/file/d/0BytzIZKeM8nBMmN3b3A0bUhoMFU/view?usp=sharing Bug: 771532 Change-Id: I64cb4015acc066322c3c6127b79b87d13cb06652 Reviewed-on: https://chromium-review.googlesource.com/700316 Reviewed-by: Scott Nichols <nicholss@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#506537} [modify] https://crrev.com/88505a5ed0fb0d6ccb8964778a29a23a84aac75d/remoting/ios/app/BUILD.gn [add] https://crrev.com/88505a5ed0fb0d6ccb8964778a29a23a84aac75d/remoting/ios/app/host_fetching_error_view_controller.h [add] https://crrev.com/88505a5ed0fb0d6ccb8964778a29a23a84aac75d/remoting/ios/app/host_fetching_error_view_controller.mm [modify] https://crrev.com/88505a5ed0fb0d6ccb8964778a29a23a84aac75d/remoting/ios/app/remoting_view_controller.mm [modify] https://crrev.com/88505a5ed0fb0d6ccb8964778a29a23a84aac75d/remoting/ios/facade/remoting_service.h [modify] https://crrev.com/88505a5ed0fb0d6ccb8964778a29a23a84aac75d/remoting/ios/facade/remoting_service.mm
,
Oct 4 2017
,
Nov 3 2017
,
Nov 9 2017
Verified Fixed in 34.0.3261.0 |
||||
►
Sign in to add a comment |
||||
Comment 1 by yuweih@chromium.org
, Oct 4 20172.6 MB
2.6 MB View Download