Currently, it looks like the attached screenshot.

We should either remove support of this, or have a new icon for it.

Deleted: EegDGDyXSAH.png 35.9 KB

	EegDGDyXSAH.png 35.9 KB View Download

What is the goal of this icon, is it a clickable target leading to extension page ?

> is it a clickable target leading to extension page?
The intended usage is this.
(Though the extension can do anything.)

I don't like the idea that third party can link to anything they like here. Also since this is a not a consistent pattern, I wouldn't recommend keeping it.

@Peter, unless you feel strongly against it, let's remove it from CrOS (and of course from the dev site)

Hi Omri,

the priority is low, but could you file a launcher bug to remove this?
Thank you!

Sorry for missing this!

I don't have particularly strong feelings on whether to keep this. Let me check if there's UMA indicating how often this gets used, which could be a data point in our decision.

Sebastien, I guess we could see this as being analogous to what Android does. For example, navigate to:

    Settings
      > Apps & notifications
      > Chrome
      > App notifications
      > Additional settings in app

This used to be a gear in the page's header prior to Android O. A quick check tells me that most 1P and many large 3P apps include this toggle.

Finally, removal from Chrome OS here means complete removal of the API.

According to UMA, we've fired this event ~3.5k times for ~1.3k users on Chrome OS in the past 28 days. Even when compensating for users who aren't opted in to UMA those remain very small numbers.

https://uma.googleplex.com/p/chrome/usage/?sid=402033bc4c61ad1c773b3b35915d16d8

Also, let's make this public - any potential changes to our API surface shouldn't be R-V-G :).

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c27a5dce70e0f2a2875214fb9a48de3806853e21

commit c27a5dce70e0f2a2875214fb9a48de3806853e21
Author: Tetsui Ohkubo <tetsui@chromium.org>
Date: Thu Jan 11 05:56:52 2018

Remove onShowSettings button from notifier settings.

The feature is only available to Chrome OS now, and
the usage is pretty low.

The launch bug for the removal is here:
https://crbug.com/791089

BUG= 771519 

Change-Id: I986d587228dc63142978af361ca22554e6398395
Reviewed-on: https://chromium-review.googlesource.com/821497
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528569}
[modify] https://crrev.com/c27a5dce70e0f2a2875214fb9a48de3806853e21/ash/message_center/message_center_controller.cc
[modify] https://crrev.com/c27a5dce70e0f2a2875214fb9a48de3806853e21/ash/message_center/message_center_controller.h
[modify] https://crrev.com/c27a5dce70e0f2a2875214fb9a48de3806853e21/ash/message_center/notifier_settings_view.cc
[modify] https://crrev.com/c27a5dce70e0f2a2875214fb9a48de3806853e21/ash/message_center/notifier_settings_view.h
[modify] https://crrev.com/c27a5dce70e0f2a2875214fb9a48de3806853e21/ash/message_center/notifier_settings_view_unittest.cc
[modify] https://crrev.com/c27a5dce70e0f2a2875214fb9a48de3806853e21/ash/public/interfaces/ash_message_center_controller.mojom
[modify] https://crrev.com/c27a5dce70e0f2a2875214fb9a48de3806853e21/chrome/browser/notifications/arc_application_notifier_controller_chromeos.cc
[modify] https://crrev.com/c27a5dce70e0f2a2875214fb9a48de3806853e21/chrome/browser/notifications/chrome_ash_message_center_client.cc
[modify] https://crrev.com/c27a5dce70e0f2a2875214fb9a48de3806853e21/chrome/browser/notifications/chrome_ash_message_center_client.h
[modify] https://crrev.com/c27a5dce70e0f2a2875214fb9a48de3806853e21/chrome/browser/notifications/extension_notifier_controller.cc
[modify] https://crrev.com/c27a5dce70e0f2a2875214fb9a48de3806853e21/chrome/browser/notifications/extension_notifier_controller.h
[modify] https://crrev.com/c27a5dce70e0f2a2875214fb9a48de3806853e21/chrome/browser/notifications/notifier_controller.h
[modify] https://crrev.com/c27a5dce70e0f2a2875214fb9a48de3806853e21/chrome/browser/notifications/web_page_notifier_controller.cc
[modify] https://crrev.com/c27a5dce70e0f2a2875214fb9a48de3806853e21/chrome/common/extensions/api/notifications.idl
[delete] https://crrev.com/13e1bd8ab8a550391912843b389d8ebf0c9d98cd/ui/resources/default_100_percent/common/notification_advanced_settings.png
[delete] https://crrev.com/13e1bd8ab8a550391912843b389d8ebf0c9d98cd/ui/resources/default_100_percent/common/notification_advanced_settings_hover.png
[delete] https://crrev.com/13e1bd8ab8a550391912843b389d8ebf0c9d98cd/ui/resources/default_100_percent/common/notification_advanced_settings_pressed.png
[delete] https://crrev.com/13e1bd8ab8a550391912843b389d8ebf0c9d98cd/ui/resources/default_200_percent/common/notification_advanced_settings.png
[delete] https://crrev.com/13e1bd8ab8a550391912843b389d8ebf0c9d98cd/ui/resources/default_200_percent/common/notification_advanced_settings_hover.png
[delete] https://crrev.com/13e1bd8ab8a550391912843b389d8ebf0c9d98cd/ui/resources/default_200_percent/common/notification_advanced_settings_pressed.png
[modify] https://crrev.com/c27a5dce70e0f2a2875214fb9a48de3806853e21/ui/resources/ui_resources.grd

Verified on M65 10302.0.0, 65.0.3319.0 dev-channel