New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 771518 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit 28 days ago
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

persistence-move-breakpoints-on-reload.html tests are flaky on Windows

Project Member Reported by kjellander@chromium.org, Oct 4 2017

Issue description

There are some recent flaky failures related to the persistence work in bug 649837:

https://luci-milo.appspot.com/buildbot/chromium.webkit/WebKit%20Win7%20%28dbg%29/11378
* virtual/mojo-loading/http/tests/devtools/persistence/persistence-move-breakpoints-on-reload.html

https://luci-milo.appspot.com/buildbot/chromium.webkit/WebKit%20Win7%20%28dbg%29/11377
* http/tests/devtools/persistence/persistence-move-breakpoints-on-reload.html

https://luci-milo.appspot.com/buildbot/chromium.webkit/WebKit%20Win7%20%28dbg%29/11370
* http/tests/devtools/persistence/persistence-move-breakpoints-on-reload.html
* virtual/mojo-loading/http/tests/devtools/persistence/persistence-move-breakpoints-on-reload.html
 
I'm going to update the expectations.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3469580f613273293b37704f6ed4ba2cb2ab3648

commit 3469580f613273293b37704f6ed4ba2cb2ab3648
Author: Henrik Kjellander <kjellander@chromium.org>
Date: Wed Oct 04 07:27:44 2017

Update expectations for persistence-move-breakpoints-on-reload.html and lazy-loaded-style.html

These test have been failing on WebKit Win7 (dbg) recently.

TBR=lushnikov@chromium.org,beccahughes@chromium.org

Bug:  770691 ,  771518 
Change-Id: I8b625ae396da9066eaec235c86378fc4509e33e8
Notry: True
Reviewed-on: https://chromium-review.googlesource.com/699995
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Commit-Queue: Henrik Kjellander <kjellander@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506327}
[modify] https://crrev.com/3469580f613273293b37704f6ed4ba2cb2ab3648/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6aee8972e61a728b123a71251862674af8c0164d

commit 6aee8972e61a728b123a71251862674af8c0164d
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Wed Nov 15 09:06:45 2017

DevTools: migrate persistence/ tests

This patch:
- migrates the leftover persistence tests
- unflakes the persistence-move-breakpoints-on-reload.html test because
  it doesn't flake any more.

BUG= chromium:771518 

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ifdad7c37295d3acc4e19cda09c7d7eba061fe128
Reviewed-on: https://chromium-review.googlesource.com/770310
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516648}
[modify] https://crrev.com/6aee8972e61a728b123a71251862674af8c0164d/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService
[modify] https://crrev.com/6aee8972e61a728b123a71251862674af8c0164d/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/6aee8972e61a728b123a71251862674af8c0164d/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-move-breakpoints-expected.txt
[rename] https://crrev.com/6aee8972e61a728b123a71251862674af8c0164d/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-move-breakpoints-on-reload.js
[delete] https://crrev.com/685daaef3f3db767d6539279c7a3daaa983be87d/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-move-breakpoints.html
[add] https://crrev.com/6aee8972e61a728b123a71251862674af8c0164d/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-move-breakpoints.js
[delete] https://crrev.com/685daaef3f3db767d6539279c7a3daaa983be87d/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-tabbed-editor-tabs-order.html
[add] https://crrev.com/6aee8972e61a728b123a71251862674af8c0164d/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-tabbed-editor-tabs-order.js
[add] https://crrev.com/6aee8972e61a728b123a71251862674af8c0164d/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/resources/persistence-tabbed-editor-tab-order.html

Status: Fixed (was: Assigned)

Sign in to add a comment