Issue metadata
Sign in to add a comment
|
Regression : Extra padding is observed between microphone bubble's title and body.
Reported by
avsha...@etouch.net,
Oct 4 2017
|
||||||||||||||||||||||
Issue descriptionChrome version : 63.0.3232.0 (Official Build) 61a8a7b24ebea8329a2aca7536b7dd881ecb2ea5-refs/heads/master@{#506256} 32/64 bit OS : Windows (7,8,10), Linux(14.04 LTS) What steps will reproduce the problem? 1. Launch chrome, open NTP, click on 'Microphone' icon in 'Search box' and click 'Allow' in permission bubble. 2. Click on 'Microphone' icon seen in omnibox and observe the bubble title & body. Actual Result : Extra padding is observed between bubble's title and body text. Expected Result : Extra space should not be seen between bubble's title and body text. This is a regression issue broken in ‘M-63’ and using the per-revision bisect providing the bisect results, Good build : 63.0.3231.0 (Revision : 506256) Bad build : 63.0.3232.0 (Revision : 505898) You are probably looking for a change made after 506001 (known good), but no later than 506002 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/2ecfd90d48fcfa8c225f592f0e4d65e48b008c3d..ec4f94005f693b2799a166008dc95a8e08044aa9 Suspect : https://chromium.googlesource.com/chromium/src/+/ec4f94005f693b2799a166008dc95a8e08044aa9 @ellyjones : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Note : Issue is not seen on Mac(10.12.6) OS. Thank you!
,
Oct 4 2017
Fix uploaded: https://chromium-review.googlesource.com/c/chromium/src/+/700400
,
Oct 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f18dc4824eee4d272ea02011652d4c887f468300 commit f18dc4824eee4d272ea02011652d4c887f468300 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Wed Oct 04 22:34:10 2017 views: remove unnecessary padding in bubbles with title and message When there is both a title and message, the padding isn't needed, since it is intended to visually take the place of the message. Bug: 771515 Change-Id: Ia29be37ae2f2049da254e4ea4874fb28f073961e Reviewed-on: https://chromium-review.googlesource.com/700400 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#506544} [modify] https://crrev.com/f18dc4824eee4d272ea02011652d4c887f468300/chrome/browser/ui/views/content_setting_bubble_contents.cc
,
Oct 5 2017
Tested the issue on Windows-7 & Ubuntu 14.04 using chrome latest Canary M63-63.0.3233.0 by following steps mentioned in the original comment. Observed that Extra space is not pop up displaying as expected. Hence adding TE-Verified label. Please find the screen shot for reference. Thank you!
,
Oct 5 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ranjitkan@chromium.org
, Oct 4 2017