New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 771514 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Remaining time is not seen on download shelf.

Reported by pranjali...@etouch.net, Oct 4 2017

Issue description

Chrome Version:63.0.3232.0 (Official Build) 61a8a7b24ebea8329a2aca7536b7dd881ecb2ea5-refs/heads/master@{#506256}(32/64 bit).

OS: Windows (7,8,10),Linux (14.04 LTS), Mac(10.12.6).

URL:http://www.engineerhammad.com/2015/04/Download-Test-Files.html

Steps to reproduce:
1)Launch chrome and go to above URL.
2)Download 1Gb file and Observe timer on download shelf.        

Actual Result:Remaining time is not seen on download shelf.
Expected Result:Remaining time should be seen on download shelf.

This is regression issue broken in 'M-63' and below per-revision bisect result

Using the per-revision bisect providing the bisect results,

Good build:63.0.3214.0 
Bad build:63.0.3215.0 

You are probably looking for a change made after 501663 (known good), but no later than 501664 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

  https://chromium.googlesource.com/chromium/src/+log/fdb6d91116fca4fb8645f06669c0ea925019aed3..78d13fd19c25b9daf22936929095adce17ac3fa1

Suspect:https://chromium.googlesource.com/chromium/src/+/78d13fd19c25b9daf22936929095adce17ac3fa1

 
Actual_result.mp4
1.6 MB View Download
Expected_result.mp4
1.7 MB View Download
Labels: ReleaseBlock-Stable
Tagging with blocker label, please undo if not the case.
xingliu@,
Friendly ping to get an update on this issue as it is marked as stable blocker.
Thanks..!
Status: Started (was: Assigned)
Probably ftp content length is broken. 
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc435c7539a61437ed4aa008410806ded1e67fe9

commit dc435c7539a61437ed4aa008410806ded1e67fe9
Author: Xing Liu <xingliu@chromium.org>
Date: Wed Oct 11 20:13:30 2017

Fix an issue that FTP content length in download is not parsed correctly.

Instead of directly parsing content length from http header. We should
use accessor function in URLRequest and ResourceResponseHead, which gets
the content length from different URLRequestJob backends that support
multiple protocols.

Bug:  771514 
Change-Id: I60d8d13ab0f12b4e0f558d6611f0129e20435ea6
Reviewed-on: https://chromium-review.googlesource.com/710334
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508088}
[modify] https://crrev.com/dc435c7539a61437ed4aa008410806ded1e67fe9/content/browser/download/download_request_core.cc
[modify] https://crrev.com/dc435c7539a61437ed4aa008410806ded1e67fe9/content/browser/download/download_response_handler.cc
[modify] https://crrev.com/dc435c7539a61437ed4aa008410806ded1e67fe9/content/browser/download/download_utils.cc

Status: Fixed (was: Started)
Labels: TE-Verified-M63 TE-Verified-63.0.3238.0
Note:Rechecked the above issue on  Windows (7,8,10),Linux (14.04 LTS), Mac(10.12.6) OS with latest canary chrome version :63.0.3238.0 and the issue is not reproducible.Kindly refer the attached screen cast for reference.
Actual_result.mp4
1.8 MB View Download
Actual_result.mp4
1.8 MB View Download

Sign in to add a comment