New issue
Advanced search Search tips

Issue 771511 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Choose Trybots does not show up for some WebRTC committers

Project Member Reported by phoglund@chromium.org, Oct 4 2017

Issue description

Chrome Version: (copy from chrome://version)
OS: (e.g. Win7, OSX 10.9.5, etc...)

What steps will reproduce the problem?
(1) make small change + git cl upload
(2) Example: https://webrtc-review.googlesource.com/c/src/+/6280

What is the expected result?
I would expect to see a "Choose Trybots" button in the UI.

What happens instead?
See screenshot: the button does not show up. If I run, for instance, git cl try -b linux_rel -m tryserver.webrtc the tryjob shows up in the tryjob field, but I still don't get a Choose Tryjobs option.

I am logged into phoglund@webrtc.org when doing this. The button does show up if I'm logged into phoglund@google.com though!

Please use labels and text to provide additional information.


For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

 
Screenshot from 2017-10-04 08:24:05.png
6.7 KB View Download
Owner: aga...@chromium.org
Status: Assigned (was: Untriaged)
Aaron, I'm going to guess you're the right person here. This is easy to work around but annoying, so not time critical.

My WebRTC and google accounts are old, so maybe there's some old cruft preventing my account from working, in particular.

Context in https://bugs.chromium.org/p/webrtc/issues/detail?id=8312.
Status: Fixed (was: Assigned)
The "Choose try jobs" button only doesn't show up in two circumstances:
* The user isn't signed in (this isn't the case)
* The list of buckets retrieved from buildbucket.config is empty

It must be the latter. That means that your @webrtc.org account can't read https://webrtc.googlesource.com/src/+/refs/meta/config/buildbucket.config, while your @google can. This makes sense, since your @google is a member of project-webrtc-admins while your @webrtc is not.

However, it *doesn't* make sense, because everyone should be able to read buildbucket.config, and we don't store any confidential information in refs/meta/config. So I've made that ref readable again.

Please confirm that this has fixed the problem?
Status: Assigned (was: Fixed)
I don't see "Choose Trybots" on my WIP CL. Is it worth trying on a new CL?

I do see https://webrtc.googlesource.com/src/+/refs/meta/config/buildbucket.config just fine.
Can you open the web inspector, hard-refresh the page, and then check for the contents of the response for the request for "buildbucket~config"?
Status: Verified (was: Assigned)
Sorry, I must have missed it the last time, I can definitely see "Choose try jobs" now.

buildbucket~config, of course, gets a 200 response with correct buckets.

Thank you!
I still don't see it. Is this because I'm an admin with my google account? buildbucket~config gets a 200 response, here's some of the contents:

)]}' {gitHost: "webrtc.googlesource.com", gerritHost: "webrtc-review.googlesource.com",…}
buckets
:
[{name: "master.tryserver.webrtc",…}, {name: "master.tryserver.chromium.android",…},…]
0
:
{name: "master.tryserver.webrtc",…}
builders
:
["android_arm64_rel", "android_clang_dbg", "android_compile_arm64_dbg", "android_compile_arm64_rel",…]
0
:
"android_arm64_rel"
1
:
"android_clang_dbg"
2
:
"android_compile_arm64_dbg"
3
:
"android_compile_arm64_rel"
4
:
"android_compile_dbg"
5
:
"android_compile_mips_dbg"
6
:
"android_compile_rel"
7
:
"android_compile_x64_dbg"
8
:
"android_compile_x86_dbg"
9
:
"android_compile_x86_rel"
10
:
"android_dbg"
11
:
"android_experimental"
12
:
"android_more_configs"
13
:
"android_rel"
14
:
"ios32_sim_ios9_dbg"
15
:
"ios64_sim_ios10_dbg"
16
:
"ios64_sim_ios9_dbg"
17
:
"ios_api_framework"
18
:
"ios_arm64_dbg"
19
:
"ios_arm64_rel"
20
:
"ios_dbg"
21
:
"ios_rel"
22
:
"linux32_dbg"
23
:
"linux32_rel"
24
:
"linux_arm"
25
:
"linux_asan"
26
:
"linux_baremetal"
27
:
"linux_compile_dbg"
28
:
"linux_compile_rel"
29
:
"linux_dbg"
30
:
"linux_libfuzzer_rel"
31
:
"linux_memcheck"
32
:
"linux_more_configs"
33
:
"linux_msan"
34
:
"linux_rel"
35
:
"linux_tsan2"
36
:
"linux_ubsan"
37
:
"linux_ubsan_vptr"
38
:
"mac_asan"
39
:
"mac_baremetal"
40
:
"mac_compile_dbg"
41
:
"mac_compile_rel"
42
:
"mac_dbg"
43
:
"mac_rel"
44
:
"presubmit"
45
:
"win_asan"
46
:
"win_baremetal"
47
:
"win_clang_dbg"
48
:
"win_clang_rel"
49
:
"win_compile_dbg"
50
:
"win_compile_rel"
51
:
"win_compile_x64_dbg"
52
:
"win_compile_x64_rel"
53
:
"win_dbg"
54
:
"win_rel"
55
:
"win_x64_clang_dbg"
56
:
"win_x64_clang_rel"
57
:
"win_x64_dbg"
58
:
"win_x64_rel"
59
:
"win_x64_win10"
60
:
"win_x64_win8"
name
:
"master.tryserver.webrtc"
1
:
{name: "master.tryserver.chromium.android",…}
builders
:
["android_archive_rel_ng", "android_arm64_dbg_recipe", "android_blink_rel", "android_clang_dbg_recipe",…]
0
:
"android_archive_rel_ng"
1
:
"android_arm64_dbg_recipe"
2
:
"android_blink_rel"
3
:
"android_clang_dbg_recipe"
4
:
"android_compile_dbg"
5
:
"android_compile_mips_dbg"
6
:
"android_compile_rel"
7
:
"android_compile_x64_dbg"
8
:
"android_compile_x86_dbg"
9
:
"android_coverage"
10
:
"android_cronet"
11
:
"android_cronet_tester"
12
:
"android_n5x_swarming_dbg"
13
:
"android_n5x_swarming_rel"
14
:
"android_optional_gpu_tests_rel"
15
:
"android_unswarmed_n5_rel"
16
:
"android_unswarmed_n5x_rel"
17
:
"cast_shell_android"
18
:
"linux_android_dbg_ng"
19
:
"linux_android_rel_ng"
name
:
"master.tryserver.chromium.android"
2
:
{name: "master.tryserver.chromium.linux",…}
builders
:
["Chromium Linux Codesearch Builder", "ChromiumOS Codesearch Builder", "cast_shell_audio_linux",…]
0
:
"Chromium Linux Codesearch Builder"
1
:
"ChromiumOS Codesearch Builder"
2
:
"cast_shell_audio_linux"
3
:
"cast_shell_linux"
4
:
"chromeos_amd64-generic_chromium_compile_only_ng"
5
:
"chromeos_daisy_chromium_compile_only_ng"
6
:
"chromium_presubmit"
7
:
"closure_compilation"
8
:
"fuchsia"
9
:
"linux_arm"
10
:
"linux_arm64_dbg"
11
:
"linux_arm64_rel"
12
:
"linux_arm_dbg"
13
:
"linux_arm_rel"
14
:
"linux_chromium_archive_rel_ng"
15
:
"linux_chromium_asan_rel_ng"
16
:
"linux_chromium_browser_side_navigation_rel"
17
:
"linux_chromium_cfi_rel_ng"
18
:
"linux_chromium_chromeos_asan_rel_ng"
19
:
"linux_chromium_chromeos_compile_dbg_ng"
20
:
"linux_chromium_chromeos_compile_rel_ng"
21
:
"linux_chromium_chromeos_dbg_ng"
22
:
"linux_chromium_chromeos_msan_rel_ng"
23
:
"linux_chromium_chromeos_ozone_rel_ng"
24
:
"linux_chromium_chromeos_rel_ng"
25
:
"linux_chromium_clobber_deterministic"
26
:
"linux_chromium_clobber_rel_ng"
27
:
"linux_chromium_compile_dbg_32_ng"
28
:
"linux_chromium_compile_dbg_ng"
29
:
"linux_chromium_compile_rel_ng"
30
:
"linux_chromium_dbg_32_ng"
31
:
"linux_chromium_dbg_ng"
32
:
"linux_chromium_gn_upload"
33
:
"linux_chromium_headless_rel"
34
:
"linux_chromium_msan_rel_ng"
35
:
"linux_chromium_ozone_compile_only_ng"
36
:
"linux_chromium_ozone_ng"
37
:
"linux_chromium_rel_ng"
38
:
"linux_chromium_tsan_rel_ng"
39
:
"linux_chromium_ubsan_rel_ng"
40
:
"linux_layout_tests_layout_ng"
41
:
"linux_layout_tests_slimming_paint_v2"
42
:
"linux_mojo"
43
:
"linux_mojo_chromeos"
44
:
"linux_nacl_sdk"
45
:
"linux_nacl_sdk_build"
46
:
"linux_optional_gpu_tests_rel"
47
:
"linux_site_isolation"
48
:
"linux_upload_clang"
name
:
"master.tryserver.chromium.linux"
3
:
{name: "master.tryserver.chromium.mac",…}
4
:
{name: "master.tryserver.chromium.win",…}
gerritHost
:
"webrtc-review.googlesource.com"
gitHost
:
"webrtc.googlesource.com"
That's the correct response. With that in the config, I'd have to look over your shoulder and step through the js debugger to see why it isn't rendering the Choose Tryjobs button. (Being an admin isn't it, I'm an admin.)
Hm, I tried debugging it. _computeChooseTryJobsHidden(_pluginConfig.buckets, _loggedIn) does evaluate to false, but I can't get it to stop at the breakpoint, nor am I able to find the source code for the function.

All right, let's assume this only affects me and keep this issue closed (it's easy for me to work around...)
Ha! I managed to fix it actually.

The problem was my webrtc.org address was listed in my @chromium.org Gerrit user. After removing that and logging out/back in I can see Choose Trybots.

Sign in to add a comment