New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 771498 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

provide build_id property on bulidbot and luci

Project Member Reported by no...@chromium.org, Oct 4 2017

Issue description

on LUCI build_id must be "buildbucket/<buildbucket hostname>/<buildbucket build id>"
on Buildbot build_id must be "buildbot/<master>/<builder>/<number>"

provide the property on all buildbot and LUCI builds

same format is already used in comleted_(builds|steps) BQ tables.

 

Comment 1 by no...@chromium.org, Oct 6 2017

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/ea021a9b6c26f62c29db0d631dbc4c9bcf65000f

commit ea021a9b6c26f62c29db0d631dbc4c9bcf65000f
Author: Nodir Turakulov <nodir@google.com>
Date: Mon Oct 09 19:36:36 2017

[buildbucket] include build_id property

build_id property is a global, universal (buildbot, luci) build identifier.
It can be used by builds to identify themselves.
This format is used in completed_builds and completed_steps tables today.

R=vadimsh@chromium.org
Bug:  771498 
Change-Id: I0acc02a21759779f58455937de257286f3d93e68
Reviewed-on: https://chromium-review.googlesource.com/706335
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/ea021a9b6c26f62c29db0d631dbc4c9bcf65000f/appengine/cr-buildbucket/swarming/swarming.py
[modify] https://crrev.com/ea021a9b6c26f62c29db0d631dbc4c9bcf65000f/appengine/cr-buildbucket/swarming/test/swarming_test.py

Status: Fixed (was: Started)

Comment 4 by no...@chromium.org, Oct 19 2017

Status: Started (was: Fixed)
https://chromium-review.googlesource.com/c/chromium/tools/build/+/706350 needs to land
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/b9f7a3d85a5f9a2f07d7add1c672de82715853e7

commit b9f7a3d85a5f9a2f07d7add1c672de82715853e7
Author: Nodir Turakulov <nodir@google.com>
Date: Tue Dec 05 17:15:04 2017

[buildbot] add build_id property

build_id property is a global, universal (buildbot, luci) build identifier.
It can be used by builds to identify themselves.

R=vadimsh@chromium.org
Bug:  771498 
Change-Id: I8b10f20f61a8ae98c97ef35005b9aa850804a06f
Reviewed-on: https://chromium-review.googlesource.com/706350
Reviewed-by: Katie Thomas <katthomas@google.com>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/b9f7a3d85a5f9a2f07d7add1c672de82715853e7/scripts/slave/unittests/annotated_run_test.py
[modify] https://crrev.com/b9f7a3d85a5f9a2f07d7add1c672de82715853e7/scripts/slave/annotated_run.py
[modify] https://crrev.com/b9f7a3d85a5f9a2f07d7add1c672de82715853e7/scripts/slave/remote_run.py

Project Member

Comment 6 by bugdroid1@chromium.org, Dec 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/5051bc7e73327a4424ee571d37b7aea424908942

commit 5051bc7e73327a4424ee571d37b7aea424908942
Author: Michael Achenbach <machenbach@chromium.org>
Date: Wed Dec 06 08:01:13 2017

Revert "[buildbot] add build_id property"

This reverts commit b9f7a3d85a5f9a2f07d7add1c672de82715853e7.

Reason for revert: Probably causing https://crbug.com/792351

Original change's description:
> [buildbot] add build_id property
> 
> build_id property is a global, universal (buildbot, luci) build identifier.
> It can be used by builds to identify themselves.
> 
> R=​vadimsh@chromium.org
> Bug:  771498 
> Change-Id: I8b10f20f61a8ae98c97ef35005b9aa850804a06f
> Reviewed-on: https://chromium-review.googlesource.com/706350
> Reviewed-by: Katie Thomas <katthomas@google.com>
> Commit-Queue: Nodir Turakulov <nodir@chromium.org>

TBR=nodir@chromium.org,katthomas@google.com

Change-Id: Ieb64407126f51820562ce6773d2c711b7a88a43f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  771498 , 792351
Reviewed-on: https://chromium-review.googlesource.com/809146
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>

[modify] https://crrev.com/5051bc7e73327a4424ee571d37b7aea424908942/scripts/slave/unittests/annotated_run_test.py
[modify] https://crrev.com/5051bc7e73327a4424ee571d37b7aea424908942/scripts/slave/annotated_run.py
[modify] https://crrev.com/5051bc7e73327a4424ee571d37b7aea424908942/scripts/slave/remote_run.py

Project Member

Comment 7 by bugdroid1@chromium.org, Dec 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/909b14eda8dee1186a11569b222b368621eba86a

commit 909b14eda8dee1186a11569b222b368621eba86a
Author: Michael Achenbach <machenbach@chromium.org>
Date: Thu Dec 07 08:20:19 2017

Reland "[buildbot] add build_id property"

This is a reland of b9f7a3d85a5f9a2f07d7add1c672de82715853e7
Original change's description:
> [buildbot] add build_id property
> 
> build_id property is a global, universal (buildbot, luci) build identifier.
> It can be used by builds to identify themselves.
> 
> R=vadimsh@chromium.org
> Bug:  771498 
> Change-Id: I8b10f20f61a8ae98c97ef35005b9aa850804a06f
> Reviewed-on: https://chromium-review.googlesource.com/706350
> Reviewed-by: Katie Thomas <katthomas@google.com>
> Commit-Queue: Nodir Turakulov <nodir@chromium.org>

Bug:  771498 
Change-Id: I07e49bfdca7568e6b7df2b43503dd35028860ad4
Reviewed-on: https://chromium-review.googlesource.com/812505
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/909b14eda8dee1186a11569b222b368621eba86a/scripts/slave/unittests/annotated_run_test.py
[modify] https://crrev.com/909b14eda8dee1186a11569b222b368621eba86a/scripts/slave/annotated_run.py
[modify] https://crrev.com/909b14eda8dee1186a11569b222b368621eba86a/scripts/slave/remote_run.py

Comment 8 by no...@chromium.org, Dec 7 2017

Status: Fixed (was: Started)

Sign in to add a comment