New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 771496 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocking:
issue 740783



Sign in to add a comment

desktop-pwas: PWAs that are installed as shortcuts shouldn't capture links

Project Member Reported by ortuno@chromium.org, Oct 4 2017

Issue description

Currently, if a user adds a shortcut to a PWA, clicking on links to the PWA will open a new App window. We should stop doing this.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d467f977411c7af65b047faea30147a41c4c9f4

commit 0d467f977411c7af65b047faea30147a41c4c9f4
Author: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Date: Mon Nov 27 08:06:23 2017

desktop-pwas: Don't intercept links to apps that open in a tab

When users install a Desktop PWA, the app will open in a window by
default. User can still change the launch container in chrome://apps or
by right clicking the app icon on Chrome OS. When users change the launch
container to tab, we stop intercepting links for that app.

Bug:  771496 
Change-Id: Ie0bd0c7883afbbfffbd94bc577665865699fca6e
Reviewed-on: https://chromium-review.googlesource.com/789731
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519241}
[modify] https://crrev.com/0d467f977411c7af65b047faea30147a41c4c9f4/chrome/browser/extensions/bookmark_app_navigation_throttle.cc
[modify] https://crrev.com/0d467f977411c7af65b047faea30147a41c4c9f4/chrome/browser/extensions/bookmark_app_navigation_throttle_browsertest.cc
[modify] https://crrev.com/0d467f977411c7af65b047faea30147a41c4c9f4/chrome/browser/extensions/browsertest_util.cc

Comment 2 by ortuno@chromium.org, Nov 27 2017

Status: Fixed (was: Assigned)

Sign in to add a comment