New issue
Advanced search Search tips

Issue 771490 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----

Blocking:
issue 403462



Sign in to add a comment

Rename CdmInfo.type to CdmInfo.name

Project Member Reported by xhw...@chromium.org, Oct 4 2017

Issue description

Previously |type| was used to identify the type of a CDM (e.g. Widevine, or Clear Key CDM). As of 5591646b86cd3526357b2775b850bcdb2189a5b4, we use CdmInfo.guid to uniquely identify the type of a CDM to be able to run different CDMs in different processes. Also, GUID is a much better ID than the |type|, which is a free format text string.

With that, we don't need the |type| anymore. However, we still need a display name for the CDM type for various purposes. For example, in the future, we could use this name as the CDM process name.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fcc2a89ebc911d0cf1a05e7b5274a5e612e681d2

commit fcc2a89ebc911d0cf1a05e7b5274a5e612e681d2
Author: Xiaohan Wang <xhwang@chromium.org>
Date: Thu Oct 05 21:52:19 2017

media: Rename CdmInfo |type| to |name|

Previously |type| was used to identify the type of a CDM (e.g. Widevine,
or Clear Key CDM). As of 5591646b86cd3526357b2775b850bcdb2189a5b4, we
use CdmInfo.guid to uniquely identify the type of a CDM to be able to
run different CDMs in different processes. Also, GUID is a much better
ID than the |type|, which is a free format text string.

With that, we don't need the |type| anymore. However, we still need a
display name for the CDM type for various purposes. For example, in the
future, we could use this name as the CDM process name.

This CL renames |type| to |name| and updated the comment.

TBR=thestig@chromium.org,alexmos@chromium.org
BUG= 771490 
TEST=No functionality change

Change-Id: Ia95a77e1c506a551e37798e5a73b6c0d5186ee82
Reviewed-on: https://chromium-review.googlesource.com/699858
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506871}
[modify] https://crrev.com/fcc2a89ebc911d0cf1a05e7b5274a5e612e681d2/chrome/browser/component_updater/widevine_cdm_component_installer.cc
[modify] https://crrev.com/fcc2a89ebc911d0cf1a05e7b5274a5e612e681d2/chrome/browser/media/encrypted_media_browsertest.cc
[modify] https://crrev.com/fcc2a89ebc911d0cf1a05e7b5274a5e612e681d2/chrome/browser/media/library_cdm_test_helper.cc
[modify] https://crrev.com/fcc2a89ebc911d0cf1a05e7b5274a5e612e681d2/chrome/browser/media/library_cdm_test_helper.h
[modify] https://crrev.com/fcc2a89ebc911d0cf1a05e7b5274a5e612e681d2/chrome/common/chrome_content_client.cc
[modify] https://crrev.com/fcc2a89ebc911d0cf1a05e7b5274a5e612e681d2/content/browser/media/cdm_registry_impl_unittest.cc
[modify] https://crrev.com/fcc2a89ebc911d0cf1a05e7b5274a5e612e681d2/content/common/media/cdm_info.cc
[modify] https://crrev.com/fcc2a89ebc911d0cf1a05e7b5274a5e612e681d2/content/public/common/cdm_info.h
[modify] https://crrev.com/fcc2a89ebc911d0cf1a05e7b5274a5e612e681d2/media/cdm/cdm_paths.cc
[modify] https://crrev.com/fcc2a89ebc911d0cf1a05e7b5274a5e612e681d2/media/cdm/cdm_paths.h
[modify] https://crrev.com/fcc2a89ebc911d0cf1a05e7b5274a5e612e681d2/third_party/widevine/cdm/widevine_cdm_common.h

Status: Fixed (was: Assigned)

Sign in to add a comment