#concept-script-fetch-options was introduced in html spec commit: https://github.com/whatwg/html/commit/9275d955dcd604e959cfcc672e0c234b1b8c00db
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d361e84b6569c65f9ad2ac2b717faf16f9a67892 commit d361e84b6569c65f9ad2ac2b717faf16f9a67892 Author: Kouhei Ueno <kouhei@chromium.org> Date: Fri Oct 13 07:01:26 2017 [ES6 modules] Introduce ScriptFetchOptions This CL introduces ScriptFetchOptions, which maps to spec concept "script-fetch-options", and updates mapping to various spec algorithms which use the spec concept. https://html.spec.whatwg.org/multipage/webappapis.html#script-fetch-options This CL should not cause any behavioral changes. Bug: 771486 Change-Id: Ic87cef7cb736df31dd99f5a3b2b72cb19351551f Reviewed-on: https://chromium-review.googlesource.com/680771 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#508629} [modify] https://crrev.com/d361e84b6569c65f9ad2ac2b717faf16f9a67892/third_party/WebKit/Source/core/dom/DynamicModuleResolver.cpp [modify] https://crrev.com/d361e84b6569c65f9ad2ac2b717faf16f9a67892/third_party/WebKit/Source/core/dom/ModuleMap.cpp [modify] https://crrev.com/d361e84b6569c65f9ad2ac2b717faf16f9a67892/third_party/WebKit/Source/core/dom/ModuleMapTest.cpp [modify] https://crrev.com/d361e84b6569c65f9ad2ac2b717faf16f9a67892/third_party/WebKit/Source/core/dom/ModuleScript.cpp [modify] https://crrev.com/d361e84b6569c65f9ad2ac2b717faf16f9a67892/third_party/WebKit/Source/core/dom/ModuleScript.h [modify] https://crrev.com/d361e84b6569c65f9ad2ac2b717faf16f9a67892/third_party/WebKit/Source/core/dom/ScriptLoader.cpp [modify] https://crrev.com/d361e84b6569c65f9ad2ac2b717faf16f9a67892/third_party/WebKit/Source/core/dom/ScriptLoader.h [modify] https://crrev.com/d361e84b6569c65f9ad2ac2b717faf16f9a67892/third_party/WebKit/Source/core/loader/modulescript/ModuleScriptFetchRequest.h [modify] https://crrev.com/d361e84b6569c65f9ad2ac2b717faf16f9a67892/third_party/WebKit/Source/core/loader/modulescript/ModuleScriptLoader.cpp [modify] https://crrev.com/d361e84b6569c65f9ad2ac2b717faf16f9a67892/third_party/WebKit/Source/core/loader/modulescript/ModuleScriptLoader.h [modify] https://crrev.com/d361e84b6569c65f9ad2ac2b717faf16f9a67892/third_party/WebKit/Source/core/loader/modulescript/ModuleScriptLoaderTest.cpp [modify] https://crrev.com/d361e84b6569c65f9ad2ac2b717faf16f9a67892/third_party/WebKit/Source/core/loader/modulescript/ModuleTreeLinker.cpp [modify] https://crrev.com/d361e84b6569c65f9ad2ac2b717faf16f9a67892/third_party/WebKit/Source/core/loader/modulescript/ModuleTreeLinkerTest.cpp [modify] https://crrev.com/d361e84b6569c65f9ad2ac2b717faf16f9a67892/third_party/WebKit/Source/core/workers/WorkletGlobalScope.cpp [modify] https://crrev.com/d361e84b6569c65f9ad2ac2b717faf16f9a67892/third_party/WebKit/Source/platform/loader/BUILD.gn [add] https://crrev.com/d361e84b6569c65f9ad2ac2b717faf16f9a67892/third_party/WebKit/Source/platform/loader/fetch/ScriptFetchOptions.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/60dbde98da0052691c263cf66859eb14514aae28 commit 60dbde98da0052691c263cf66859eb14514aae28 Author: Kouhei Ueno <kouhei@chromium.org> Date: Mon Oct 16 00:00:46 2017 [ES6 modules] Make ModuleScript::CreateForTest take ScriptFetchOptions This CL simplifies ModuleScript::CreateForTest arguments. No behavioral change, and should only affect unit test code. Bug: 771486 Change-Id: Id46a4601e69c8d602bfe1acea2eec8dc12da5d3c Reviewed-on: https://chromium-review.googlesource.com/716440 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#508963} [modify] https://crrev.com/60dbde98da0052691c263cf66859eb14514aae28/third_party/WebKit/Source/core/dom/DynamicModuleResolverTest.cpp [modify] https://crrev.com/60dbde98da0052691c263cf66859eb14514aae28/third_party/WebKit/Source/core/dom/ModuleMapTest.cpp [modify] https://crrev.com/60dbde98da0052691c263cf66859eb14514aae28/third_party/WebKit/Source/core/dom/ModuleScript.cpp [modify] https://crrev.com/60dbde98da0052691c263cf66859eb14514aae28/third_party/WebKit/Source/core/dom/ModuleScript.h [modify] https://crrev.com/60dbde98da0052691c263cf66859eb14514aae28/third_party/WebKit/Source/core/dom/ScriptModuleResolverImplTest.cpp [modify] https://crrev.com/60dbde98da0052691c263cf66859eb14514aae28/third_party/WebKit/Source/core/loader/modulescript/ModuleTreeLinkerTest.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/38111361cbd50c82097d2926476ffb7caf91bd56 commit 38111361cbd50c82097d2926476ffb7caf91bd56 Author: Kouhei Ueno <kouhei@chromium.org> Date: Mon Oct 16 03:49:13 2017 [ES6 modules] ScriptFetchOptions should be kept by both variants of Script ScriptFetchOptions should be kept for both variants of script (module / classic) per spec [1]. This moves up fetch_options_ to be kept by parent class blink::Script from the previous blink::ModuleScript. From this change, ScriptSourceCode no longer needs to keep nonce/parser_state, as we now use ClassicScript::fetch_options_ to keep those values. [1] https://html.spec.whatwg.org/multipage/webappapis.html#concept-script Bonus: Make external/wpt/html/semantics/scripting-1/the-script-element/execution-timing/039.html predictable by removing setTimeout. Bug: 771486 Change-Id: Ie50cb4327aa38c068ed853a1cf939f41947c1e54 Reviewed-on: https://chromium-review.googlesource.com/718241 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#508977} [modify] https://crrev.com/38111361cbd50c82097d2926476ffb7caf91bd56/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/execution-timing/039.html [modify] https://crrev.com/38111361cbd50c82097d2926476ffb7caf91bd56/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp [modify] https://crrev.com/38111361cbd50c82097d2926476ffb7caf91bd56/third_party/WebKit/Source/bindings/core/v8/ScriptController.h [modify] https://crrev.com/38111361cbd50c82097d2926476ffb7caf91bd56/third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.cpp [modify] https://crrev.com/38111361cbd50c82097d2926476ffb7caf91bd56/third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.h [modify] https://crrev.com/38111361cbd50c82097d2926476ffb7caf91bd56/third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp [modify] https://crrev.com/38111361cbd50c82097d2926476ffb7caf91bd56/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp [modify] https://crrev.com/38111361cbd50c82097d2926476ffb7caf91bd56/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h [modify] https://crrev.com/38111361cbd50c82097d2926476ffb7caf91bd56/third_party/WebKit/Source/core/dom/ClassicPendingScript.cpp [modify] https://crrev.com/38111361cbd50c82097d2926476ffb7caf91bd56/third_party/WebKit/Source/core/dom/ClassicScript.cpp [modify] https://crrev.com/38111361cbd50c82097d2926476ffb7caf91bd56/third_party/WebKit/Source/core/dom/ClassicScript.h [modify] https://crrev.com/38111361cbd50c82097d2926476ffb7caf91bd56/third_party/WebKit/Source/core/dom/ModuleScript.cpp [modify] https://crrev.com/38111361cbd50c82097d2926476ffb7caf91bd56/third_party/WebKit/Source/core/dom/ModuleScript.h [modify] https://crrev.com/38111361cbd50c82097d2926476ffb7caf91bd56/third_party/WebKit/Source/core/dom/Script.h [modify] https://crrev.com/38111361cbd50c82097d2926476ffb7caf91bd56/third_party/WebKit/Source/core/exported/WebScriptSource.cpp [modify] https://crrev.com/38111361cbd50c82097d2926476ffb7caf91bd56/third_party/WebKit/Source/core/inspector/InspectorOverlayAgent.cpp [modify] https://crrev.com/38111361cbd50c82097d2926476ffb7caf91bd56/third_party/WebKit/Source/core/loader/WorkletScriptLoader.cpp [modify] https://crrev.com/38111361cbd50c82097d2926476ffb7caf91bd56/third_party/WebKit/Source/core/resize_observer/ResizeObserverTest.cpp
hiroshige is now driving this effort.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/73949801487c40aebb7e204e33de7b6eca41b64e commit 73949801487c40aebb7e204e33de7b6eca41b64e Author: Hiroshige Hayashizaki <hiroshige@chromium.org> Date: Fri Oct 27 17:59:54 2017 Support multiple ConsoleMessages in ModuleScriptFetcher This is preparation for [1], because [1] will add possibly multiple subresource-integrity-related messages there. [1] https://chromium-review.googlesource.com/c/chromium/src/+/738221 This CL also stops nullifying |error_messages| in DocumentModuleScriptFetcher::NotifyFinished() in success cases and uses const reference for |error_messages|, because https://chromium-review.googlesource.com/c/chromium/src/+/738221 will cause console messages even in success cases (related to subresource integrity checks). Bug: 771486 , 772100 Change-Id: I2f719883142e652cb68ea13ddc0dd654c1e7b42f Reviewed-on: https://chromium-review.googlesource.com/738789 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#512232} [modify] https://crrev.com/73949801487c40aebb7e204e33de7b6eca41b64e/third_party/WebKit/Source/core/loader/modulescript/DocumentModuleScriptFetcher.cpp [modify] https://crrev.com/73949801487c40aebb7e204e33de7b6eca41b64e/third_party/WebKit/Source/core/loader/modulescript/DocumentModuleScriptFetcher.h [modify] https://crrev.com/73949801487c40aebb7e204e33de7b6eca41b64e/third_party/WebKit/Source/core/loader/modulescript/ModuleScriptFetcher.cpp [modify] https://crrev.com/73949801487c40aebb7e204e33de7b6eca41b64e/third_party/WebKit/Source/core/loader/modulescript/ModuleScriptFetcher.h [modify] https://crrev.com/73949801487c40aebb7e204e33de7b6eca41b64e/third_party/WebKit/Source/core/loader/modulescript/ModuleScriptLoader.cpp [modify] https://crrev.com/73949801487c40aebb7e204e33de7b6eca41b64e/third_party/WebKit/Source/core/loader/modulescript/ModuleScriptLoader.h [modify] https://crrev.com/73949801487c40aebb7e204e33de7b6eca41b64e/third_party/WebKit/Source/core/loader/modulescript/WorkletModuleScriptFetcher.cpp [modify] https://crrev.com/73949801487c40aebb7e204e33de7b6eca41b64e/third_party/WebKit/Source/core/loader/modulescript/WorkletModuleScriptFetcher.h [modify] https://crrev.com/73949801487c40aebb7e204e33de7b6eca41b64e/third_party/WebKit/Source/core/workers/WorkletModuleResponsesMap.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/859a3de4c564c8a8f6a77704df510d325fe4d57e commit 859a3de4c564c8a8f6a77704df510d325fe4d57e Author: Hiroshige Hayashizaki <hiroshige@chromium.org> Date: Fri Oct 27 21:00:31 2017 Centralize ClassicPendingScript::CreateInline() call sites This merges all ClassicPendingScript::CreateInline() call sites into one in ScriptLoader::PrepareScript(). This - reduces code duplication, - makes PendingScript always created before the last step of ScriptLoader::PrepareScript() and makes TakePrepareScript() always called, and - prepares for https://chromium-review.googlesource.com/c/chromium/src/+/736876. Behavior changes: This CL resets line numbering for nested writes for classic inline scripts controlled by {HTML,XML}ParserScriptRunner. Previously, the line numbering is reset only when the classic inline script is executed inside PrepareScript(). Bug: 771486 , 777612 , 686281 Change-Id: Ibcaf9bcfa958bb302b1d7f5b7f17c501a7ac7027 Reviewed-on: https://chromium-review.googlesource.com/737055 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#512269} [modify] https://crrev.com/859a3de4c564c8a8f6a77704df510d325fe4d57e/third_party/WebKit/Source/core/dom/ScriptLoader.cpp [modify] https://crrev.com/859a3de4c564c8a8f6a77704df510d325fe4d57e/third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp [modify] https://crrev.com/859a3de4c564c8a8f6a77704df510d325fe4d57e/third_party/WebKit/Source/core/xml/parser/XMLParserScriptRunner.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6b8a2c56c3d59789f2d956972324986842653dcc commit 6b8a2c56c3d59789f2d956972324986842653dcc Author: Hiroshige Hayashizaki <hiroshige@chromium.org> Date: Fri Oct 27 21:04:55 2017 Make ScriptFetchOptions members const Bug: 771486 Change-Id: I95c48b91719adedb1e35c0d77186c20f249a93cc Reviewed-on: https://chromium-review.googlesource.com/737522 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#512276} [modify] https://crrev.com/6b8a2c56c3d59789f2d956972324986842653dcc/third_party/WebKit/Source/core/dom/ModuleMapTest.cpp [modify] https://crrev.com/6b8a2c56c3d59789f2d956972324986842653dcc/third_party/WebKit/Source/core/loader/modulescript/ModuleScriptLoader.cpp [modify] https://crrev.com/6b8a2c56c3d59789f2d956972324986842653dcc/third_party/WebKit/Source/core/loader/modulescript/ModuleScriptLoader.h [modify] https://crrev.com/6b8a2c56c3d59789f2d956972324986842653dcc/third_party/WebKit/Source/core/loader/modulescript/ModuleScriptLoaderRegistry.cpp [modify] https://crrev.com/6b8a2c56c3d59789f2d956972324986842653dcc/third_party/WebKit/Source/platform/loader/fetch/ScriptFetchOptions.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/54b14236c966a766c1ca29e754b975e14925f268 commit 54b14236c966a766c1ca29e754b975e14925f268 Author: Hiroshige Hayashizaki <hiroshige@chromium.org> Date: Mon Oct 30 19:32:35 2017 Make ScriptLoader::FetchClassicScript() to take ScriptFetchOptions Bug: 771486 Change-Id: Ic9c98da7001ea320ee7bcd8ab7f92e90ce171b0a Reviewed-on: https://chromium-review.googlesource.com/734318 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#512577} [modify] https://crrev.com/54b14236c966a766c1ca29e754b975e14925f268/third_party/WebKit/Source/core/dom/ScriptLoader.cpp [modify] https://crrev.com/54b14236c966a766c1ca29e754b975e14925f268/third_party/WebKit/Source/core/dom/ScriptLoader.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ed2ac1f367747a8139d0c57c8c1a3574916ee56 commit 3ed2ac1f367747a8139d0c57c8c1a3574916ee56 Author: Hiroshige Hayashizaki <hiroshige@chromium.org> Date: Mon Oct 30 23:57:09 2017 Plumb ScriptFetchOptions to ClassicPendingScript This CL plumbs ScriptFetchOptions from ScriptLoader::PrepareScript() to ClassicPendingScript::options_ to ClassicScript, instead of reconstructing in ClassicPendingScript::GetSource(). Thus this CL removes ScriptLoader::nonce_. Bug: 771486 Change-Id: I3b74da2e65176ae0c04068abba05413b675a28b0 Reviewed-on: https://chromium-review.googlesource.com/736876 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#512680} [modify] https://crrev.com/3ed2ac1f367747a8139d0c57c8c1a3574916ee56/third_party/WebKit/Source/core/dom/ClassicPendingScript.cpp [modify] https://crrev.com/3ed2ac1f367747a8139d0c57c8c1a3574916ee56/third_party/WebKit/Source/core/dom/ClassicPendingScript.h [modify] https://crrev.com/3ed2ac1f367747a8139d0c57c8c1a3574916ee56/third_party/WebKit/Source/core/dom/ScriptLoader.cpp [modify] https://crrev.com/3ed2ac1f367747a8139d0c57c8c1a3574916ee56/third_party/WebKit/Source/core/dom/ScriptLoader.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/17090875f3106056a0d1cb897066ead3573c03f8 commit 17090875f3106056a0d1cb897066ead3573c03f8 Author: Hiroshige Hayashizaki <hiroshige@chromium.org> Date: Tue Oct 31 00:13:40 2017 Add IntegrityMetadataSet to ScriptFetchOptions This CL - introduces integrity-related members to ScriptFetchOptions, - sets them in PrepareScript(), WorkletGlobalScope.cpp and DynamicModuleResolver.cpp as specced, and - uses them for classic scripts, in ClassicPendingScript::Fetch(). For module scripts, the integrity-related members are not used, and are sometimes set incorrectly. This will be fixed in a subsequent CL. Bug: 771486 , 772100 Change-Id: I0983bc6ad02b73472d67bf1b2ce169d2d71c5be3 Reviewed-on: https://chromium-review.googlesource.com/736721 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#512685} [modify] https://crrev.com/17090875f3106056a0d1cb897066ead3573c03f8/third_party/WebKit/Source/core/dom/ClassicPendingScript.cpp [modify] https://crrev.com/17090875f3106056a0d1cb897066ead3573c03f8/third_party/WebKit/Source/core/dom/ClassicPendingScript.h [modify] https://crrev.com/17090875f3106056a0d1cb897066ead3573c03f8/third_party/WebKit/Source/core/dom/DynamicModuleResolver.cpp [modify] https://crrev.com/17090875f3106056a0d1cb897066ead3573c03f8/third_party/WebKit/Source/core/dom/ScriptLoader.cpp [modify] https://crrev.com/17090875f3106056a0d1cb897066ead3573c03f8/third_party/WebKit/Source/core/dom/ScriptLoader.h [modify] https://crrev.com/17090875f3106056a0d1cb897066ead3573c03f8/third_party/WebKit/Source/core/workers/WorkletGlobalScope.cpp [modify] https://crrev.com/17090875f3106056a0d1cb897066ead3573c03f8/third_party/WebKit/Source/platform/loader/fetch/ScriptFetchOptions.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/214d16835a233ef1e01bcf54412803cc3593ce8e commit 214d16835a233ef1e01bcf54412803cc3593ce8e Author: Hiroshige Hayashizaki <hiroshige@chromium.org> Date: Tue Oct 31 01:50:26 2017 Support integrity attribute for module scripts This CL enables subresource integrity check for module scripts, by - Clearing ScriptFetchOptions' integrity for descendant module scripts in ModuleTreeLinker.cpp, as specced, - Setting FetchParameters' integrity according to ScriptFetchOptions in ModuleScriptLoader::Fetch(), and - Checking the integrity check result in WasModuleLoadSuccessful() and reports console messages if any. For this, SubresourceIntegrityHelper::GetConsoleMessages() is introduced. Bug: 771486 , 772100 Change-Id: I3f01fd018dad625de9440fe4ab7e1d9ee7feb5ab Reviewed-on: https://chromium-review.googlesource.com/738221 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#512705} [delete] https://crrev.com/c7cb3e9057a8420d0f54db86dc581bc33b94e4c9/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/integrity-expected.txt [modify] https://crrev.com/214d16835a233ef1e01bcf54412803cc3593ce8e/third_party/WebKit/Source/core/loader/SubresourceIntegrityHelper.cpp [modify] https://crrev.com/214d16835a233ef1e01bcf54412803cc3593ce8e/third_party/WebKit/Source/core/loader/SubresourceIntegrityHelper.h [modify] https://crrev.com/214d16835a233ef1e01bcf54412803cc3593ce8e/third_party/WebKit/Source/core/loader/modulescript/DocumentModuleScriptFetcher.cpp [modify] https://crrev.com/214d16835a233ef1e01bcf54412803cc3593ce8e/third_party/WebKit/Source/core/loader/modulescript/ModuleScriptLoader.cpp [modify] https://crrev.com/214d16835a233ef1e01bcf54412803cc3593ce8e/third_party/WebKit/Source/core/loader/modulescript/ModuleTreeLinker.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b33356f4b30366ac8d58cc725e3a3c832bb2ee9a commit b33356f4b30366ac8d58cc725e3a3c832bb2ee9a Author: Kouhei Ueno <kouhei@chromium.org> Date: Mon Nov 13 20:11:01 2017 [ES6 modules] Clean up: Modulator::CompileModule to take ScriptFetchOptions directly Bug: 771486 Change-Id: I37311373c130878c87201166266d320dba17c39e Reviewed-on: https://chromium-review.googlesource.com/765618 Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Hongchan Choi <hongchan@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#516022} [modify] https://crrev.com/b33356f4b30366ac8d58cc725e3a3c832bb2ee9a/third_party/WebKit/Source/bindings/core/v8/ReferrerScriptInfo.h [modify] https://crrev.com/b33356f4b30366ac8d58cc725e3a3c832bb2ee9a/third_party/WebKit/Source/bindings/core/v8/ScriptModule.cpp [modify] https://crrev.com/b33356f4b30366ac8d58cc725e3a3c832bb2ee9a/third_party/WebKit/Source/bindings/core/v8/ScriptModule.h [modify] https://crrev.com/b33356f4b30366ac8d58cc725e3a3c832bb2ee9a/third_party/WebKit/Source/bindings/core/v8/ScriptModuleTest.cpp [modify] https://crrev.com/b33356f4b30366ac8d58cc725e3a3c832bb2ee9a/third_party/WebKit/Source/core/dom/DynamicModuleResolverTest.cpp [modify] https://crrev.com/b33356f4b30366ac8d58cc725e3a3c832bb2ee9a/third_party/WebKit/Source/core/dom/Modulator.h [modify] https://crrev.com/b33356f4b30366ac8d58cc725e3a3c832bb2ee9a/third_party/WebKit/Source/core/dom/ModulatorImplBase.cpp [modify] https://crrev.com/b33356f4b30366ac8d58cc725e3a3c832bb2ee9a/third_party/WebKit/Source/core/dom/ModulatorImplBase.h [modify] https://crrev.com/b33356f4b30366ac8d58cc725e3a3c832bb2ee9a/third_party/WebKit/Source/core/dom/ModuleScript.cpp [modify] https://crrev.com/b33356f4b30366ac8d58cc725e3a3c832bb2ee9a/third_party/WebKit/Source/core/dom/ScriptModuleResolverImplTest.cpp [modify] https://crrev.com/b33356f4b30366ac8d58cc725e3a3c832bb2ee9a/third_party/WebKit/Source/core/loader/modulescript/ModuleScriptLoaderTest.cpp [modify] https://crrev.com/b33356f4b30366ac8d58cc725e3a3c832bb2ee9a/third_party/WebKit/Source/core/loader/modulescript/ModuleTreeLinkerTest.cpp [modify] https://crrev.com/b33356f4b30366ac8d58cc725e3a3c832bb2ee9a/third_party/WebKit/Source/core/testing/DummyModulator.cpp [modify] https://crrev.com/b33356f4b30366ac8d58cc725e3a3c832bb2ee9a/third_party/WebKit/Source/core/testing/DummyModulator.h [modify] https://crrev.com/b33356f4b30366ac8d58cc725e3a3c832bb2ee9a/third_party/WebKit/Source/modules/animationworklet/AnimationWorkletGlobalScopeTest.cpp [modify] https://crrev.com/b33356f4b30366ac8d58cc725e3a3c832bb2ee9a/third_party/WebKit/Source/modules/animationworklet/AnimationWorkletThreadTest.cpp [modify] https://crrev.com/b33356f4b30366ac8d58cc725e3a3c832bb2ee9a/third_party/WebKit/Source/modules/webaudio/AudioWorkletGlobalScopeTest.cpp [modify] https://crrev.com/b33356f4b30366ac8d58cc725e3a3c832bb2ee9a/third_party/WebKit/Source/modules/webaudio/AudioWorkletThreadTest.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f5801db1a731e5ec631ed70fdaf8ece125ed744 commit 2f5801db1a731e5ec631ed70fdaf8ece125ed744 Author: Kouhei Ueno <kouhei@chromium.org> Date: Tue Nov 14 03:48:55 2017 javascript url: Add spec ref for ScriptFetchOptions to use Bug: 771486 Change-Id: I05c2772a10cc0591099e61915756f22f9c9ddeda Reviewed-on: https://chromium-review.googlesource.com/765625 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#516180} [modify] https://crrev.com/2f5801db1a731e5ec631ed70fdaf8ece125ed744/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp
Comment 1 by kouhei@chromium.org
, Oct 4 2017