New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 771444 link

Starred by 2 users
Status: Fixed
Owner:
█ roc...@chromium.org
please use my google.com address
Closed: Oct 2017
Cc:
█ lhchavez@chromium.org
█ joenotcharles@chromium.org
█ roc...@chromium.org
█ yzshen@chromium.org
yusukes@chromium.org
hidehiko@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Mojo: Message ID scrambling needs to be disabled for Chrome OS

Project Member Reported by roc...@chromium.org, Oct 4 2017 
It gets enabled in spite of the !is_chromeos condition, because enabled_nacl=true anyway.

This ends up breaking ARC.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aeaffa769748b7c3118cf06aef16b667a725f5d7

commit aeaffa769748b7c3118cf06aef16b667a725f5d7
Author: Ken Rockot <rockot@chromium.org>
Date: Wed Oct 04 06:22:12 2017

Mojo: Fix scrambled message ID build conditions

This corrects the condition used to enable scrambled message
IDs, ensuring that they are only enabled on Windows, Mac, and
Linux desktop builds, and NOT on Chrome OS.

Bug: 673417, 771444 

TBR=yzshen@chromium.org

Change-Id: I6018e22f31e91b362ca2ff3b5801dd98a5cefc15
Reviewed-on: https://chromium-review.googlesource.com/699854
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506321}
[modify] https://crrev.com/aeaffa769748b7c3118cf06aef16b667a725f5d7/mojo/public/tools/bindings/mojom.gni

Comment 2 by hashimoto@chromium.org, Oct 4 2017

Cc: joenotcharles@chromium.org lhchavez@chromium.org yusukes@chromium.org yzshen@chromium.org roc...@chromium.org hidehiko@chromium.org
 Issue 771583  has been merged into this issue.

Comment 3 by roc...@chromium.org, Oct 4 2017

Status: Fixed (was: Started)
►

Sign in to add a comment