recent change to telemetry breaks power_LoadTest |
|||||
Issue descriptionHi there, This change https://chromium.googlesource.com/catapult.git/+/ce556f01f55fd0f0ca38536a6c9a3dd85aa6c41c breaks power_LoadTest because the datastructure changes size during the iteration. I'm not sure what's happening exactly, but the error we get is Unhandled RuntimeError: Set changed size during iteration. This breaks running power_LoadTest in the lab. One workaround that has worked for me is to put the contexts into a set, and pop them out until the set is empty. But I'm sure there's some underlying reason why the size changes underneath us. Either way, please revert the CL or come up with a fix for the iteration, since our test (and maybe more stuff) depend on this.
,
Oct 4 2017
yep, that's where I noticed it first. So flash latest Chrome OS today. run power_LoadTest. >> see error
,
Oct 5 2017
Issue 771844 has been merged into this issue.
,
Oct 5 2017
,
Oct 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/a17c448e6e143da24eca02af67654c450298a5ba commit a17c448e6e143da24eca02af67654c450298a5ba Author: Achuith Bhandarkar <achuith@chromium.org> Date: Thu Oct 05 20:38:46 2017 Copy set so its size doesn't change. We see the following error: Unhandled RuntimeError: Set changed size during iteration. BUG= chromium:771421 Change-Id: I567a3b8f14666f5be27cabf7e063396949a2ae92 TEST=testGaiaLogin Reviewed-on: https://chromium-review.googlesource.com/703155 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> [modify] https://crrev.com/a17c448e6e143da24eca02af67654c450298a5ba/telemetry/telemetry/internal/backends/chrome/oobe.py
,
Oct 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/73697f66cb305cde6872a102dbdd096aa8d56217 commit 73697f66cb305cde6872a102dbdd096aa8d56217 Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org> Date: Fri Oct 06 04:36:15 2017 Roll src/third_party/catapult/ aeaf34ca0..778430a2f (3 commits) https://chromium.googlesource.com/catapult.git/+log/aeaf34ca03f8..778430a2f76b $ git log aeaf34ca0..778430a2f --date=short --no-merges --format='%ad %ae %s' 2017-10-05 oysteine trace-viewer: Let the gzip_importer use Pako directly instead of JSZip 2017-10-05 simonhatch Dashboard - Generate same tir_label for /add_histograms as chartjson. 2017-10-05 achuith Copy set so its size doesn't change. Created with: roll-dep src/third_party/catapult BUG= 771421 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I5a36807411db3f0d4b44275cf2c517f1e78bb986 Reviewed-on: https://chromium-review.googlesource.com/704261 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#506968} [modify] https://crrev.com/73697f66cb305cde6872a102dbdd096aa8d56217/DEPS
,
Oct 6 2017
,
Jan 22 2018
,
Jan 23 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by achuith@chromium.org
, Oct 3 2017Owner: achuith@chromium.org