New issue
Advanced search Search tips

Issue 771399 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 709366



Sign in to add a comment

Set the blacklist to default for server previews

Project Member Reported by ryansturm@chromium.org, Oct 3 2017

Issue description

As the blacklist transition launches, so should the old behavior be removed along with the field trial.
 
Blocking: 709366
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b37f039f55c2779f27782b2d9c813d004f298453

commit b37f039f55c2779f27782b2d9c813d004f298453
Author: Ryan Sturm <ryansturm@chromium.org>
Date: Mon Oct 16 20:15:35 2017

Removing LoFi prefs behavior

This removes the prefs that were used to control LoFi/LitePages before
the blacklist. This change also removes the transition field trial as
this feature is planned to launch to 100% everywhere.

Bug:  771399 
Change-Id: I4f88c56a6c1470755172ecb9e4591d3dfdc3888b
Reviewed-on: https://chromium-review.googlesource.com/699423
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509150}
[modify] https://crrev.com/b37f039f55c2779f27782b2d9c813d004f298453/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/b37f039f55c2779f27782b2d9c813d004f298453/chrome/browser/previews/previews_infobar_delegate.cc
[modify] https://crrev.com/b37f039f55c2779f27782b2d9c813d004f298453/chrome/browser/previews/previews_infobar_delegate_unittest.cc
[modify] https://crrev.com/b37f039f55c2779f27782b2d9c813d004f298453/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc
[modify] https://crrev.com/b37f039f55c2779f27782b2d9c813d004f298453/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h
[modify] https://crrev.com/b37f039f55c2779f27782b2d9c813d004f298453/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.cc
[modify] https://crrev.com/b37f039f55c2779f27782b2d9c813d004f298453/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc
[modify] https://crrev.com/b37f039f55c2779f27782b2d9c813d004f298453/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.cc
[modify] https://crrev.com/b37f039f55c2779f27782b2d9c813d004f298453/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.h
[modify] https://crrev.com/b37f039f55c2779f27782b2d9c813d004f298453/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc
[modify] https://crrev.com/b37f039f55c2779f27782b2d9c813d004f298453/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc
[modify] https://crrev.com/b37f039f55c2779f27782b2d9c813d004f298453/components/data_reduction_proxy/core/browser/data_reduction_proxy_prefs.cc
[modify] https://crrev.com/b37f039f55c2779f27782b2d9c813d004f298453/components/data_reduction_proxy/core/browser/data_reduction_proxy_service.cc
[modify] https://crrev.com/b37f039f55c2779f27782b2d9c813d004f298453/components/data_reduction_proxy/core/browser/data_reduction_proxy_service.h
[modify] https://crrev.com/b37f039f55c2779f27782b2d9c813d004f298453/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc
[modify] https://crrev.com/b37f039f55c2779f27782b2d9c813d004f298453/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h
[modify] https://crrev.com/b37f039f55c2779f27782b2d9c813d004f298453/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc
[modify] https://crrev.com/b37f039f55c2779f27782b2d9c813d004f298453/components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc
[modify] https://crrev.com/b37f039f55c2779f27782b2d9c813d004f298453/components/data_reduction_proxy/core/common/data_reduction_proxy_params.h
[modify] https://crrev.com/b37f039f55c2779f27782b2d9c813d004f298453/components/data_reduction_proxy/core/common/data_reduction_proxy_pref_names.cc
[modify] https://crrev.com/b37f039f55c2779f27782b2d9c813d004f298453/components/data_reduction_proxy/core/common/data_reduction_proxy_pref_names.h
[modify] https://crrev.com/b37f039f55c2779f27782b2d9c813d004f298453/testing/variations/fieldtrial_testing_config.json
[modify] https://crrev.com/b37f039f55c2779f27782b2d9c813d004f298453/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/b37f039f55c2779f27782b2d9c813d004f298453/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Assigned)
Cc: dougarnett@chromium.org ryansturm@chromium.org
 Issue 759052  has been merged into this issue.

Comment 5 by efoo@chromium.org, Dec 5 2017

Components: Blink>Previews

Comment 6 by efoo@chromium.org, Dec 5 2017

Components: -UI>Browser>Previews

Sign in to add a comment